mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Probst <markus.probst@posteo.de>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Kari Argillander" <kari.argillander@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH RFC 2/4] rust: add basic serial device bus abstractions
Date: Sun, 08 Feb 2026 14:30:54 +0000	[thread overview]
Message-ID: <40a161f055ad3410bba82c1a07fb3c674241c599.camel@posteo.de> (raw)
In-Reply-To: <DFNN75KWL8B9.1YHK1ZRV43W7O@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 2861 bytes --]

On Tue, 2026-01-13 at 18:37 +0100, Danilo Krummrich wrote:
> On Tue Jan 13, 2026 at 5:15 PM CET, Markus Probst wrote:
> > > > +impl<T: Driver + 'static> Adapter<T> {
> > > > +    const OPS: &'static bindings::serdev_device_ops = &bindings::serdev_device_ops {
> > > > +        receive_buf: if T::HAS_RECEIVE {
> > > > +            Some(Self::receive_buf_callback)
> > > > +        } else {
> > > > +            None
> > > > +        },
> > > > +        write_wakeup: if T::HAS_WRITE_WAKEUP {
> > > > +            Some(Self::write_wakeup_callback)
> > > > +        } else {
> > > > +            Some(bindings::serdev_device_write_wakeup)
> > > > +        },
> > > > +    };
> > > > +    const INITIAL_OPS: &'static bindings::serdev_device_ops = &bindings::serdev_device_ops {
> > > > +        receive_buf: Some(Self::initial_receive_buf_callback),
> > > > +        write_wakeup: if T::HAS_WRITE_WAKEUP_INITIAL {
> > > > +            Some(Self::initial_write_wakeup_callback)
> > > > +        } else {
> > > > +            Some(bindings::serdev_device_write_wakeup)
> > > > +        },
> > > > +    };
> > > > +    const NO_OPS: &'static bindings::serdev_device_ops = &bindings::serdev_device_ops {
> > > > +        receive_buf: None,
> > > > +        write_wakeup: Some(bindings::serdev_device_write_wakeup),
> > > > +    };
> > > > +
> > > > +    extern "C" fn probe_callback(sdev: *mut bindings::serdev_device) -> kernel::ffi::c_int {
> > > > +        // SAFETY: The serial device bus only ever calls the probe callback with a valid pointer to
> > > > +        // a `struct serdev_device`.
> > > > +        //
> > > > +        // INVARIANT: `sdev` is valid for the duration of `probe_callback()`.
> > > > +        let sdev = unsafe { &*sdev.cast::<Device<device::CoreInternal>>() };
> > > > +        let info = <Self as driver::Adapter>::id_info(sdev.as_ref());
> > > > +
> > > > +        from_result(|| {
> > > > +            let data = try_pin_init!(Drvdata {
> > > > +                driver <- T::probe(sdev, info),
> > > > +                initial_data: Some(Default::default()).into(),
> > > > +                late_probe_data: None.into(),
> > > > +            });
> > > > +
> > > > +            sdev.as_ref().set_drvdata(data)?;
> 
> This does not work, a driver can obtain its device private data with
> Device::<Bound>::drvdata() [1].
> 
> For this the driver must assert the correct type, but since you use a private
> type instead of the type given by the driver, i.e. T, Device::<Bound>::drvdata()
> will always fail for the driver.
> 
> [1] https://rust.docs.kernel.org/kernel/device/struct.Device.html#method.drvdata
> 
What do you suggest as alternative? Besides from the "initial data"
debate, I still need to store at least one `Completion` to ensure
safety.

Thanks
- Markus Probst

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 870 bytes --]

  parent reply	other threads:[~2026-02-08 14:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-20 18:44 [PATCH RFC 0/4] " Markus Probst
2025-12-20 18:44 ` [PATCH RFC 1/4] serdev: Export internal is_serdev_device() for drivers Markus Probst
2025-12-21 16:10   ` Greg Kroah-Hartman
2025-12-21 16:28     ` Markus Probst
2025-12-21 16:46       ` Greg Kroah-Hartman
2025-12-21 17:36       ` Danilo Krummrich
2025-12-21 17:40   ` Danilo Krummrich
2025-12-20 18:44 ` [PATCH RFC 2/4] rust: add basic serial device bus abstractions Markus Probst
2025-12-21  9:19   ` Dirk Behme
2025-12-21 12:41     ` Markus Probst
2025-12-25 15:13   ` Kari Argillander
2026-01-13 16:15     ` Markus Probst
2026-01-13 17:37       ` Danilo Krummrich
2026-01-13 17:59         ` Markus Probst
2026-01-13 19:10           ` Danilo Krummrich
2026-02-08 14:30         ` Markus Probst [this message]
2025-12-26 15:09   ` Kari Argillander
2025-12-20 18:44 ` [PATCH RFC 3/4] samples: rust: add Rust serial device bus sample device driver Markus Probst
2025-12-21  9:11   ` Dirk Behme
2025-12-21 12:39     ` Markus Probst
2025-12-20 18:44 ` [PATCH RFC 4/4] rust: Add serdev rust abstractions to MAINTAINERS file Markus Probst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40a161f055ad3410bba82c1a07fb3c674241c599.camel@posteo.de \
    --to=markus.probst@posteo.de \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kari.argillander@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=robh@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®