From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADAA4CCA47B for ; Thu, 14 Jul 2022 09:32:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237477AbiGNJcU (ORCPT ); Thu, 14 Jul 2022 05:32:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238180AbiGNJb4 (ORCPT ); Thu, 14 Jul 2022 05:31:56 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A5BF193EB for ; Thu, 14 Jul 2022 02:31:55 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id n18so1870564lfq.1 for ; Thu, 14 Jul 2022 02:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=PMZaNjQtAbx8J0mKRSpXwktuMPwXaREJXWQ/VLykmlA=; b=CV/iF5PngbOmaQbK3ZOIIcJ9SkDO4TLcvHWghMhvpmE5BTDLqPUTFdvd0hSXgVQ174 WV47TTX/ZyVZ8aP1Hmx+EUVcDNTW5QVHrOsh8CU+7tZ0Hhm9jc1Vbw6/+py2Tqsdz5f5 AK/ChQhXHfqBx5I6jO3qkMqAvOY1uaMH92HWBnajolSa4s24wa8KnV1QYZ4aqvGkLS+n ZH0ZkcVOzgDNBUMtHwGdRiai9nC4NZ9c54hWxZDofGgx97xREC/MYbpwtTxmcDx9Fr4h j7ry1oGVBkEeMedlHOfb6ugnqwjr+DgglfIMi0/JHz5X5biUsDMhreLIUrraAUF/nMoE PI5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=PMZaNjQtAbx8J0mKRSpXwktuMPwXaREJXWQ/VLykmlA=; b=MZ5/pZvy6C6ZEgCn07An6czG1y9hdn6qaJRkmrI0bpf3DYaAE65gGAOv5MqxA13uWL AM8+45P4HeYbHLfatcoxBTjUB6ZytwNCrYzNQ7CXrf1aGmTEliXDnrurMMgEqMXd1dPb 2v85tKiTlyoMtaDbPjHrUijSjKP7/ToSAtxGIS0SdRI9lhx2Qf1LJo3nr2ES+0PEcsOS nAb0Qsz0H1InoQg3uEepMDMDBRZqNmAiWXrSXZAEDii47IKXvp7SohH9bHUlNwljmWZp Bqi/JVPq4Zvqle3jyDuQeW1LB7aiVvs5QFry8ELS4sG6WqpJPB8sB9q7+QpFNdLtqdwy dlWw== X-Gm-Message-State: AJIora88CZiPQZFyuRjMNYFeDLwJny5f7bABHLY2OCXdAbTGsvO8SGy1 4zBXDYEzKggT0i19C6xchOwQnw== X-Google-Smtp-Source: AGRyM1sj75WrIm4R5Qs3nZKUQGBZwT2cTSTGxK9L3cPa36VVhOBtfYdLvyXmgesp8yOvZ0gQtlHQoQ== X-Received: by 2002:ac2:42c5:0:b0:489:ce27:a777 with SMTP id n5-20020ac242c5000000b00489ce27a777mr4692866lfl.596.1657791113767; Thu, 14 Jul 2022 02:31:53 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id y12-20020a05651c106c00b0025d53e34fe7sm187744ljm.56.2022.07.14.02.31.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jul 2022 02:31:53 -0700 (PDT) Message-ID: <40a60647-01f2-1e3f-88aa-8625903e1081@linaro.org> Date: Thu, 14 Jul 2022 11:31:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 29/30] phy: qcom-qmp-pcie-msm8996: drop reset lane suffix Content-Language: en-US To: Johan Hovold , Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220707134725.3512-1-johan+linaro@kernel.org> <20220707134725.3512-30-johan+linaro@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220707134725.3512-30-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/07/2022 15:47, Johan Hovold wrote: > The lane reset is defined in the "lane" node so there's no need to keep > adding a redundant lane-number suffix to the reset name. > > Update driver to support the new binding where the "lane" reset name has > been deprecated by instead requesting the reset by index. > > Signed-off-by: Johan Hovold > --- > drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c > index af2f14a53b38..1734fb01955a 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c > @@ -909,9 +909,7 @@ int qcom_qmp_phy_pcie_msm8996_create(struct device *dev, struct device_node *np, > "failed to get lane%d pipe clock\n", id); > } > > - /* Get lane reset, if any */ > - snprintf(prop_name, sizeof(prop_name), "lane%d", id); > - qphy->lane_rst = of_reset_control_get_exclusive(np, prop_name); I guess prop_name variable should be removed here. Best regards, Krzysztof