From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBAB68405C for ; Mon, 3 Nov 2025 10:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762166033; cv=none; b=pR0cDtkk95e287TLA04nyMNl9jFAVxr3l32Cuqj432Lb7wg78fK/FqZJqX6xRwMGK7zs8h8A78r4QbxS/+CDdIcTomiGWUYzMoAOCn6zztWekdyAHsd848ex7BDetKd0UTPJ4ktk3XO9zYMtVT5F4vEb3J6Kpz6dS+b0BXjw/M0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762166033; c=relaxed/simple; bh=Hld3A20ypq7EfrSD1xxAy8u3Il974vGYXEhaVccKVbE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LocXyedSRVQqNplUd3D4MoaoEXJq+7ubC47VxdaZLIvLm0/yBzn1yzT7EeKQVoQ4/yiIhyuRCwo1u5cXxgA4xF0njIi9k7UfzFZifWlS7abIW8sXR0rug1p00n4G4DY9gGpzyuq4zCPj68634uM0A6nb8xSvrpjlO1dmvj4QUGU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hUEkTrmw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jpJeNCdq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hUEkTrmw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jpJeNCdq" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A36IhKG2247233 for ; Mon, 3 Nov 2025 10:33:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rn1LUOBG2CbQbe/cqiBEL/Tz9s8YyLm1nNaeiZPfffg=; b=hUEkTrmwENBVDoHQ pO0Coo5l/1RMKfRpy1fMRc8Ms6HswuFzIXv/MOAIeR4GFj5p+YpQYGm8lI7iRWjd Ngdw14JMh5TpMWMClvp6flnUxdD0RsCa4/KiabBdgPHPjJgssLTCxMZ/jurDWrHE jRVO4aXIzaRuKalV1BNl//l/iMax683Y4aHdC9ZkIcfvqwHQCF7mhMVclmNW8tq+ ijQ4lg7+P78Jg/RsdaiLpSbpFAN0kcVnRZQyt+V20amvEBgwBgnzGSkEl8qtjYLD zl7/wbIO2TE1Ymrd76Cw6ceJhVlAL7LsZ4jXaE6GYJiDYXAcsE4J4NqwOM9ghPrH C8a2bQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a6q0ygte7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Nov 2025 10:33:51 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2954d676f9dso15128745ad.0 for ; Mon, 03 Nov 2025 02:33:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762166031; x=1762770831; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rn1LUOBG2CbQbe/cqiBEL/Tz9s8YyLm1nNaeiZPfffg=; b=jpJeNCdqnaOIgeca2Se4ubNFY0s1hFVXvg3r/aSGPzEgS7hwEnWgI8qMq8F1jP3Wru 2LJABikgfghCDEOrwn0tjetruKUiNIX1VOnnEs0lzI3IWvBmm/3EZlOZ3oX0rTYynsD0 FMbL/Mk8/1wRL/5qmrbNOvhckRWG7aT8YUiYSKHpUJfVCC69GoVJFgdkcBU1pnIVHPxZ Ll+TBPNihiR21+kBV1h3zpndnvnWs1mcrZG4Yy5x+qVMWO41NCEzkIIjZCbnu4tb9KSE 5BREKxSe3w1zXz8CxSqqeswrgnHGknO4cTiAumykImFRZv0KoRn5soiZTGVkE/DOfQDU 9qnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762166031; x=1762770831; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rn1LUOBG2CbQbe/cqiBEL/Tz9s8YyLm1nNaeiZPfffg=; b=FlEtjWZluCWVR3XCSLPWo9RkRrS7q3YPtQRiSffim0DxUbPuC0i4xyi1ZpAny+W08C Ewnmt5CWGB9vY58i9HEV/RUtuvMVx9da75uCVDUzpcIxE+v4avkaOCVmiJ2JeSpv1mOk 3+IlQiI+j2cVXOWhN4wDba4pXje3O7quDwCtjIC8i61gM/m/2U4J36QEwBNnV4iwU+gX i3vV/tBkt0leigIeLxD5iwqfaxBCb8OSc9YajWWtyYAwg8hq0DxhdklbjSjObyPaoqzF Pmv7v7lF9+98rfjXoB40ggZ8/XRncP7zMRHWmMVwK5TUCueGd/QYzLfE10ufjteCQuN6 64bA== X-Forwarded-Encrypted: i=1; AJvYcCViZ+0yLPMQdnkclsa6wb9C/GKR11qXV+7g6sEul5G4Ur9HNPrvJvEkDfY85dhRclPGFWn/RRFwZt/mH6Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+2RL4r05O94CdkASu6cvqn2AmAFdUGRVtTM8Hek/VGdXI5Qrz 47Na6nFNkhm8glAOVvJgvgbg+pdDhH1xD5JIN4XoTMqi+XcPil3TkwNS24q+3OZVKmjQq+jL2uX ccVwJHXsz6LInhV7GauWyn03fB35qaiW1rv46VfQbPBIW/ApQ9r8KfradgWx4qQyIUSA= X-Gm-Gg: ASbGnctEei/2nk81tHUOvTyWaBu/MjC+lsrFLWu7+Jo/YcC0haK9IUutHN2XKjOlTQ5 IHe01Y+kXmyd3TSVjsu4BGut/OQhwxJ8ahGeTZ8CRizyBDvzx6jPVYSvLmVUsYTTqdfzqQf8m06 Avu5VNgE8bh78h4lzn0+XI/TF0LwsfmO7GM59PyMfIurdC796H5K/Jx/Rvu6wYnO45kX/2nsVCk XO+SZl+byKvydhogCCdPveA6V9L9XEYi27X8wiX7C4SxtdigVOuuDxiJN1gbF71daR1X85xlfH7 nBRrOXVwJ7zip7XeX39F/iuub+sZXJMSPfAxPQwWC3Z5mO5E6tE+YoztzHJWe7fjO0sH/ILdApS V+LAs3kY/QKNQcZBUmcASCKwgTbPXDf9pNJhRAaTgQAOq4ee2+DlbHqKA5WtZhtI0kaodhyp/e0 7hwD2DOMgwZkW5mS5qNUTcnw== X-Received: by 2002:a17:902:ec86:b0:295:b46f:a6c2 with SMTP id d9443c01a7336-295b46fa745mr32601125ad.37.1762166030471; Mon, 03 Nov 2025 02:33:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuzMJXftYovpjYt4udUUg3xGT7FWWThDT/vHq5zHRYdVP1AK/845Nocr0Dh94zZj1rYIPw4w== X-Received: by 2002:a17:902:ec86:b0:295:b46f:a6c2 with SMTP id d9443c01a7336-295b46fa745mr32600815ad.37.1762166029930; Mon, 03 Nov 2025 02:33:49 -0800 (PST) Received: from [10.190.211.199] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-341599676d6sm589527a91.9.2025.11.03.02.33.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Nov 2025 02:33:49 -0800 (PST) Message-ID: <40a6395e-26f6-4bad-88af-d89479b6fc28@oss.qualcomm.com> Date: Mon, 3 Nov 2025 16:03:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] soc: qcom: smem: Register gunyah watchdog device To: Bjorn Andersson Cc: Konrad Dybcio , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pavan Kondeti , Neil Armstrong , Dmitry Baryshkov References: <20251031-gunyah_watchdog-v4-0-7abb1ee11315@oss.qualcomm.com> <20251031-gunyah_watchdog-v4-1-7abb1ee11315@oss.qualcomm.com> Content-Language: en-US From: Hrishabh Rajput In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=NYbrFmD4 c=1 sm=1 tr=0 ts=6908850f cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Oglo4aDHNYH22b3EH6wA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: eMaG0LZgU89s7J89NR1yd6EcOqaamxK5 X-Proofpoint-ORIG-GUID: eMaG0LZgU89s7J89NR1yd6EcOqaamxK5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTAzMDA5NiBTYWx0ZWRfX07LMJ/COfV+3 jMW5PS/ZczCEtpi4YhEESQOc6ZJtPXlv15uvBcWYHW9ZyaJv3hScFjL6MkH63CM1xFvd29VhExY v/Ffvw2ZMLCUNJJ/MDDJFO1Irh1Ke6NFRp54A2jypDtwgJolOvhZxR5JZFo9PWR++jQEoM2UAyr RQtpMT4QyTCsyWWgN4A19zUkgjqcZi6xSjdA6n7YAmoueoJNOfZPDC7khL9i4gu2iybm7T5e8PL mPJ1eLvt88EpNKGTRid1hdeLG8VCh2Bn+/TR8752n+60YPFnLcyONciZNVRr33Z9N+oWFojgqWK a6MACvd8qmrhQa81t4WaF9zeyaKxdl0DC/idcfkGHEbCh5YHMbBU3yHP6s3ff6gBL2sUw5iiyhM oHS+IK1VSj+qkl82ddIuHKb2qnIwaQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-03_01,2025-10-29_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511030096 On 11/2/2025 12:15 AM, Bjorn Andersson wrote: > On Fri, Oct 31, 2025 at 10:18:13AM +0000, Hrishabh Rajput via B4 Relay wrote: >> From: Hrishabh Rajput >> >> To restrict gunyah watchdog initialization to Qualcomm platforms, >> register the watchdog device in the SMEM driver. >> >> When Gunyah is not present or Gunyah emulates MMIO-based >> watchdog, we expect Qualcomm watchdog or ARM SBSA watchdog device to be >> present in the devicetree. If none of these device nodes are detected, >> we register the SMC-based Gunyah watchdog device. >> >> Signed-off-by: Hrishabh Rajput >> --- >> drivers/soc/qcom/smem.c | 37 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> >> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c >> index cf425930539e..40e4749fab02 100644 >> --- a/drivers/soc/qcom/smem.c >> +++ b/drivers/soc/qcom/smem.c >> @@ -1118,6 +1118,34 @@ static int qcom_smem_resolve_mem(struct qcom_smem *smem, const char *name, >> return 0; >> } >> >> +static int register_gunyah_wdt_device(void) >> +{ >> + struct platform_device *gunyah_wdt_dev; >> + struct device_node *np; >> + >> + /* >> + * When Gunyah is not present or Gunyah is emulating a memory-mapped >> + * watchdog, either of Qualcomm watchdog or ARM SBSA watchdog will be >> + * present. Skip initialization of SMC-based Gunyah watchdog if that is >> + * the case. > E.g. qcom-apq8064.dtsi doesn't define either qcom,kpss-wdt, nor > arm,sbsa-gwdt, does that imply that it implements the Gunyah watchdog? It doesn't implement Gunyah watchdog. For platforms like these we've kept a STATUS SMC call in the gunyah_wdt_probe(). The SMC Call is expected to fail on platforms which do not have support for SMC based Gunyah watchdog, which in turn will fail the probe. Let us know if there's a better way to handle this. >> + */ >> + np = of_find_compatible_node(NULL, NULL, "qcom,kpss-wdt"); >> + if (np) { >> + of_node_put(np); >> + return 0; >> + } >> + >> + np = of_find_compatible_node(NULL, NULL, "arm,sbsa-gwdt"); >> + if (np) { >> + of_node_put(np); >> + return 0; >> + } >> + >> + gunyah_wdt_dev = platform_device_register_simple("gunyah-wdt", -1, >> + NULL, 0); >> + return PTR_ERR_OR_ZERO(gunyah_wdt_dev); >> +} >> + >> static int qcom_smem_probe(struct platform_device *pdev) >> { >> struct smem_header *header; >> @@ -1236,11 +1264,20 @@ static int qcom_smem_probe(struct platform_device *pdev) >> if (IS_ERR(smem->socinfo)) >> dev_dbg(&pdev->dev, "failed to register socinfo device\n"); >> >> + ret = register_gunyah_wdt_device(); >> + if (ret) >> + dev_dbg(&pdev->dev, "failed to register watchdog device\n"); >> + >> return 0; >> } >> >> static void qcom_smem_remove(struct platform_device *pdev) >> { >> + /* >> + * Gunyah watchdog is intended to be a persistent module. Hence, the >> + * watchdog device is not unregistered. >> + */ > Why? I don't see why the code needs to encode such policy, please > explain. You're right, there is no such need. We're at wrong here. We had an incorrect understanding of watchdog drivers being persistent. We will be implementing the module_exit() for the Gunyah watchdog making it not persistent. Thanks, Hrishabh