mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Baek Kyu, Kim" <pocj8ur4in@gmail.com>
Cc: mail@mariuszachmann.de, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (corsair-cpro) Cache fan target only after a successful command
Date: Sun, 25 Oct 2026 17:33:05 -0700	[thread overview]
Message-ID: <40aa68b7-5809-4d19-98da-a2ec101e11f3@roeck-us.net> (raw)
In-Reply-To: <20261020160941.36787-1-pocj8ur4in@gmail.com>

On Wed, Oct 21, 2026 at 01:09:41AM +0900, Baek Kyu, Kim wrote:
> set_target() updates the cached fan target before sending the command.
> If the command fails, subsequent fanN_target reads report the failed
> request instead of the previous value. For example, after successfully
> setting 1200 RPM, a rejected request for 1800 RPM returns an error but
> leaves fanN_target reporting 1800. A failed request also replaces
> -ENODATA when no target has been successfully set.
> 
> Update the target cache under the existing mutex only after
> send_usb_cmd() succeeds, as set_pwm() already does when invalidating
> the target. Preserve the previous cached value and return the original
> error on failure.
> 
> Fixes: 40c3a4454225 ("hwmon: add Corsair Commander Pro driver")
> Signed-off-by: Baek Kyu, Kim <pocj8ur4in@gmail.com>

Applied.

Thanks,
Guenter

      reply	other threads:[~2026-10-26  0:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 16:09 Baek Kyu, Kim
2026-10-26  0:33 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40aa68b7-5809-4d19-98da-a2ec101e11f3@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@mariuszachmann.de \
    --cc=pocj8ur4in@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®