mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Russell King <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org, patches@armlinux.org.uk
Subject: Re: [PATCH] ARM: zynq: slcr: fix function prototype kernel-doc warnings
Date: Mon, 15 Jan 2024 09:12:44 +0100	[thread overview]
Message-ID: <40acc2a6-0619-4cf6-ae0a-7438b07b0967@amd.com> (raw)
In-Reply-To: <20240114051730.16796-1-rdunlap@infradead.org>



On 1/14/24 06:17, Randy Dunlap wrote:
> Use the same name in the function prototype description and the function
> to prevent kernel-doc warnings:
> 
> slcr.c:158: warning: expecting prototype for zynq_slcr_cpu_state(). Prototype was for zynq_slcr_cpu_state_read() instead
> slcr.c:176: warning: expecting prototype for zynq_slcr_cpu_state(). Prototype was for zynq_slcr_cpu_state_write() instead
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Michal Simek <michal.simek@amd.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: patches@armlinux.org.uk
> ---
> KernelVersion: 0dd3ee31125508cd67f7e717
> 
>   arch/arm/mach-zynq/slcr.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff -- a/arch/arm/mach-zynq/slcr.c b/arch/arm/mach-zynq/slcr.c
> --- a/arch/arm/mach-zynq/slcr.c
> +++ b/arch/arm/mach-zynq/slcr.c
> @@ -146,7 +146,7 @@ void zynq_slcr_cpu_stop(int cpu)
>   }
>   
>   /**
> - * zynq_slcr_cpu_state - Read/write cpu state
> + * zynq_slcr_cpu_state_read - Read cpu state
>    * @cpu:	cpu number
>    *
>    * SLCR_REBOOT_STATUS save upper 2 bits (31/30 cpu states for cpu0 and cpu1)
> @@ -165,7 +165,7 @@ bool zynq_slcr_cpu_state_read(int cpu)
>   }
>   
>   /**
> - * zynq_slcr_cpu_state - Read/write cpu state
> + * zynq_slcr_cpu_state_write - Write cpu state
>    * @cpu:	cpu number
>    * @die:	cpu state - true if cpu is going to die
>    *


Applied.
Thanks,
Michal

      reply	other threads:[~2024-01-15  8:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-14  5:17 Randy Dunlap
2024-01-15  8:12 ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40acc2a6-0619-4cf6-ae0a-7438b07b0967@amd.com \
    --to=michal.simek@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=patches@armlinux.org.uk \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®