From: Mark Brown <broonie@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: linux-spi@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
stable@vger.kernel.org,
Daire McNamara <daire.mcnamara@microchip.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: microchip-core: prevent RX overflows when transmit size > FIFO size
Date: Wed, 15 Jan 2025 19:33:24 +0000 [thread overview]
Message-ID: <40aecf85-1d30-464f-bd67-59eb8fc62700@sirena.org.uk> (raw)
In-Reply-To: <20250115-resubmit-glove-ca6ce06c9d4f@spud>
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
On Wed, Jan 15, 2025 at 06:22:55PM +0000, Conor Dooley wrote:
> Moving it out of the interrupt handler entirely probably makes the code
> a lot easier to reason about, so I think I'd actually rather do that.
> That said, I don't think I would want that change going into fixes as it's
> a pretty intrusive change, although given where we are in the cycle it
> ain't as much of a problem since I'd not be sending it until after 6.13
> is released anyway.
OTOH the patch you sent will lock up hard if the RX FIFO gets stuck for
some other reason which is always a bit concerning...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-01-15 19:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 17:13 Conor Dooley
2025-01-14 19:44 ` Mark Brown
2025-01-15 18:22 ` Conor Dooley
2025-01-15 19:33 ` Mark Brown [this message]
2025-01-29 13:27 ` Mukesh Kumar Savaliya
2025-01-29 16:30 ` Conor Dooley
2025-03-04 12:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40aecf85-1d30-464f-bd67-59eb8fc62700@sirena.org.uk \
--to=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=daire.mcnamara@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®