From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C50BA126C03; Mon, 30 Mar 2026 07:38:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774856307; cv=none; b=NaVsc8KMKwTCMzX6f87EEqpBgSUIS9X9vKwmqhy/LYXwm5PK760SDqISa9nEntCxW7wEbHteGaSm/M4SxvJC3ktuY32K65yNHCQYoSYf3scBjsRDFUyTzV8dCnrEt5QJ+ayGv8ae0qvYANnazuHQ6s9jQ2ewQTdSR29SqZzOsCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774856307; c=relaxed/simple; bh=4HA1U25ikYzRfB3o1Pk3ZaCNGS6qso5p8aBQrgsCtuI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ec2CMEc5Ddlot7h782JfJWALONhvE3+UBwHkeYdaT06m9dvjZB2j8Q6soTdV7vDBGbpOzc7bdouE6bg75eO0y5OrnLR3uLWKAH+5RUAK8HTeM9LKoRZ9JAmGGr6UebHVTEVlhV8YOKHK70Mo10VZ4z1ZF47MyVKzaKxSAXf6xFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=dKFyz1Hb; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="dKFyz1Hb" Received: from [192.168.0.43] (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9825720FF; Mon, 30 Mar 2026 09:37:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774856222; bh=4HA1U25ikYzRfB3o1Pk3ZaCNGS6qso5p8aBQrgsCtuI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dKFyz1HbfEL1Cx6zC5k0ZnH+jGF2jGq/xMINENXHMFbi1vArQIcB4qBhBzbIPwiVT FPCGNlNBig3TmC9coFWlwoWipl84SCKmUmHtsfbMiEE9Np92/3gVUgsW7uThLEqcjJ XUnnj9tI4BsqGOzepkatdUAoh6Lxyckj/YSmRfLA= Message-ID: <40b164b4-de07-42cc-873c-8d997e5f3de6@ideasonboard.com> Date: Mon, 30 Mar 2026 08:38:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/14] media: rzg2l-cru: Remove wrong locking comment To: Jacopo Mondi , Mauro Carvalho Chehab , Laurent Pinchart , Biju Das , Hans Verkuil , Sakari Ailus , Tommaso Merciai Cc: =?UTF-8?Q?Barnab=C3=A1s_P=C5=91cze?= , Lad Prabhakar , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jacopo Mondi References: <20260327-b4-cru-rework-v1-0-3b7d0430f538@ideasonboard.com> <20260327-b4-cru-rework-v1-7-3b7d0430f538@ideasonboard.com> Content-Language: en-US From: Dan Scally In-Reply-To: <20260327-b4-cru-rework-v1-7-3b7d0430f538@ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jacopo On 27/03/2026 17:10, Jacopo Mondi wrote: > From: Jacopo Mondi > > A function documented as "need to hold qlock before calling" actually > takes the lock itself. > > Drop the comment and prepare to replace it with proper annotations where > appropriate. > > Signed-off-by: Jacopo Mondi > --- Reviewed-by: Daniel Scally > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index 2e94788c3a13..27079c17a54c 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -106,7 +106,6 @@ __rzg2l_cru_read_constant(struct rzg2l_cru_dev *cru, u32 offset) > __rzg2l_cru_read_constant(cru, offset) : \ > __rzg2l_cru_read(cru, offset)) > > -/* Need to hold qlock before calling */ > static void return_unused_buffers(struct rzg2l_cru_dev *cru, > enum vb2_buffer_state state) > { >