From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84AEB79FE for ; Sat, 6 Jan 2024 15:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wsrEzVO7" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a2a360dbc11so1745366b.2 for ; Sat, 06 Jan 2024 07:28:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704554927; x=1705159727; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JqQSYLD6Y1gr/LDRvUK1g3O32845VQpwLDm/7pkTGqc=; b=wsrEzVO7RJ6GSeK5TG60cdu7n9z+Vvg0yUjpwHoFo6PtALB9kfQHcn0hDhvWFCfl+z D2M0GaTp5DQADm5tk1vGXLadg/QjDp9sKs3/bG/rFJa4u9/mOePkCBR4RFWzsELGPYuZ mCiYWUiiBFDBeAbMPcBePEoYmj/JLGYZFIms0HSmXFBC5EnTvAWuGLQfaYuQFGOmST0c h0kZmln6Ml72MRTEKfDuqDbJwEqb9fDQcBBMT/luAHfq4B8tY0bC3lpd4PFcukwh5QAg wvRwz3xll2i+FhriHJLFMtTI1S+oARcU2dInQ7UuN5IMTboBaS7k+JZM/9WMxlDgYaCp l6MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704554927; x=1705159727; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JqQSYLD6Y1gr/LDRvUK1g3O32845VQpwLDm/7pkTGqc=; b=RthOtqxAT7ourvVqpSnMn4Ezdj18ORmP/DP+uxENipGHCgCQZWa6RMdDrayvvDgQkV 09lobZOIMAOSRG0KD3vAc6QiZAYG4B/suK5iAjyi1DD5/NNZ28U0Hz8RjqavcGxRcrqU yJ1isbb3sg3NGgVltkHlfW/7P2qV2chBh30VHkk0UTQKxG10g2KuPpJlUCPC8YFqT6+A Yc/W+eM7ONrovnQw2loRQQsKvolTGhgGPR+J1RJdeyh95jKsXXoiNnuWPsG8qxDHOH0j fr4nvExGqs/iG5EmSXf6Rw69ZxWf4LspZuAtPCdUVI3mnTbiakKLjhzdiygWS/cBKEVx zirA== X-Gm-Message-State: AOJu0YwCBhowXuZhwKCbwVZIg43I8jrAX8Ag3wA+TmoPEBzfP19nGBpX bB+uA0lYOE0lQF7N31Y6YCjDQda4IrzD5Q== X-Google-Smtp-Source: AGHT+IGsjSq59vSgfMblBL5/zjbLkXeESIfE0JYSbwYvKQ4C5Xqepl3SPwcwDY4p/oZsX7cU4fe2oQ== X-Received: by 2002:a17:906:fc0d:b0:a28:afd9:8576 with SMTP id ov13-20020a170906fc0d00b00a28afd98576mr396374ejb.109.1704554926840; Sat, 06 Jan 2024 07:28:46 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.112]) by smtp.gmail.com with ESMTPSA id dq16-20020a170907735000b00a269357c2e7sm2068038ejc.36.2024.01.06.07.28.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Jan 2024 07:28:46 -0800 (PST) Message-ID: <40b4d29e-fa5c-43d5-8ccb-4a5a41150546@linaro.org> Date: Sat, 6 Jan 2024 16:28:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] reset: gpio: Add GPIO-based reset controller Content-Language: en-US To: Biju Das , Srinivas Kandagatla , Banajit Goswami , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linux-arm-msm@vger.kernel.org" , "linux-sound@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: Bartosz Golaszewski , Sean Anderson References: <20240105155918.279657-1-krzysztof.kozlowski@linaro.org> <20240105155918.279657-2-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05/01/2024 17:39, Biju Das wrote: > Hi Krzysztof Kozlowski, > > Thanks for the patch. > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Friday, January 5, 2024 3:59 PM >> Subject: [PATCH v2 1/4] reset: gpio: Add GPIO-based reset controller >> >> Add a simple driver to control GPIO-based resets using the reset >> controller API for the cases when the GPIOs are shared and reset should be >> coordinated. The driver is expected to be used by reset core framework >> for ad-hoc reset controllers. >> >> Cc: Bartosz Golaszewski >> Cc: Sean Anderson >> Signed-off-by: Krzysztof Kozlowski >> --- >> MAINTAINERS | 5 ++ >> drivers/reset/Kconfig | 9 +++ >> drivers/reset/Makefile | 1 + >> drivers/reset/reset-gpio.c | 121 +++++++++++++++++++++++++++++++++++++ >> 4 files changed, 136 insertions(+) >> create mode 100644 drivers/reset/reset-gpio.c >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 7fe27cd60e1b..a0fbd4814bc7 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -8866,6 +8866,11 @@ F: Documentation/i2c/muxes/i2c-mux-gpio.rst >> F: drivers/i2c/muxes/i2c-mux-gpio.c >> F: include/linux/platform_data/i2c-mux-gpio.h >> >> +GENERIC GPIO RESET DRIVER >> +M: Krzysztof Kozlowski >> +S: Maintained >> +F: drivers/reset/reset-gpio.c >> + >> GENERIC HDLC (WAN) DRIVERS >> M: Krzysztof Halasa >> S: Maintained >> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index >> ccd59ddd7610..bb1b5a326eb7 100644 >> --- a/drivers/reset/Kconfig >> +++ b/drivers/reset/Kconfig >> @@ -66,6 +66,15 @@ config RESET_BRCMSTB_RESCAL >> This enables the RESCAL reset controller for SATA, PCIe0, or PCIe1 >> on >> BCM7216. >> >> +config RESET_GPIO >> + tristate "GPIO reset controller" >> + help >> + This enables a generic reset controller for resets attached via >> + GPIOs. Typically for OF platforms this driver expects "reset- >> gpios" >> + property. >> + >> + If compiled as module, it will be called reset-gpio. >> + >> config RESET_HSDK >> bool "Synopsys HSDK Reset Driver" >> depends on HAS_IOMEM >> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile index >> 8270da8a4baa..fd8b49fa46fc 100644 >> --- a/drivers/reset/Makefile >> +++ b/drivers/reset/Makefile >> @@ -11,6 +11,7 @@ obj-$(CONFIG_RESET_BCM6345) += reset-bcm6345.o >> obj-$(CONFIG_RESET_BERLIN) += reset-berlin.o >> obj-$(CONFIG_RESET_BRCMSTB) += reset-brcmstb.o >> obj-$(CONFIG_RESET_BRCMSTB_RESCAL) += reset-brcmstb-rescal.o >> +obj-$(CONFIG_RESET_GPIO) += reset-gpio.o >> obj-$(CONFIG_RESET_HSDK) += reset-hsdk.o >> obj-$(CONFIG_RESET_IMX7) += reset-imx7.o >> obj-$(CONFIG_RESET_INTEL_GW) += reset-intel-gw.o diff --git >> a/drivers/reset/reset-gpio.c b/drivers/reset/reset-gpio.c new file mode >> 100644 index 000000000000..cf0a867cbc5f >> --- /dev/null >> +++ b/drivers/reset/reset-gpio.c >> @@ -0,0 +1,121 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +struct reset_gpio_priv { >> + struct reset_controller_dev rc; >> + struct gpio_desc *reset; >> +}; >> + >> +static inline struct reset_gpio_priv >> +*rc_to_reset_gpio(struct reset_controller_dev *rc) { >> + return container_of(rc, struct reset_gpio_priv, rc); } >> + >> +static int reset_gpio_assert(struct reset_controller_dev *rc, unsigned >> +long id) { >> + struct reset_gpio_priv *priv = rc_to_reset_gpio(rc); >> + >> + gpiod_set_value_cansleep(priv->reset, 1); >> + >> + return 0; >> +} >> + >> +static int reset_gpio_deassert(struct reset_controller_dev *rc, >> + unsigned long id) >> +{ >> + struct reset_gpio_priv *priv = rc_to_reset_gpio(rc); >> + >> + gpiod_set_value_cansleep(priv->reset, 0); >> + >> + return 0; >> +} >> + >> +static int reset_gpio_status(struct reset_controller_dev *rc, unsigned >> +long id) { >> + struct reset_gpio_priv *priv = rc_to_reset_gpio(rc); >> + >> + return gpiod_get_value_cansleep(priv->reset); >> +} >> + >> +static const struct reset_control_ops reset_gpio_ops = { >> + .assert = reset_gpio_assert, >> + .deassert = reset_gpio_deassert, >> + .status = reset_gpio_status, >> +}; >> + >> +static void reset_gpio_of_args_put(void *data) { >> + of_node_put(data); >> +} >> + >> +static int reset_gpio_probe(struct platform_device *pdev) { >> + struct device *dev = &pdev->dev; >> + struct device_node **platdata = dev_get_platdata(dev); >> + struct of_phandle_args gpio_args; >> + struct reset_gpio_priv *priv; >> + int ret; >> + >> + if (!platdata || !*platdata) > > Maybe, if (!(platdata && *platdata)) which reduces 1 inversion operation. I would not call it easier to understand... To me !A and !*A are quite obvious and easy to read instantly because !A is obvious: check if it is not NULL. Therefore original check is obvious: is NULL or points to NULL? Then exit. Now your check is a bit more complicated. It is not even frequent code pattern which my brain used to see. You want to check if both are not NULL and then negate it, wait, no, opposite, check if they are something and then negate? To me it is really opposite of readable code. Best regards, Krzysztof