Re: [PATCH v2 2/2] soc: ti: k3-ringacc: Fix DMA ring initialization kernel-doc

["Kumar, Udit" <u-kumar1@ti.com>]

On 9/23/2026 11:46 AM, Karl Mehltretter wrote:
> The heading for k3_ringacc_init_data repeats struct, so kernel-doc
> cannot match it to the declaration. Its three fields are also missing
> descriptions.
> 
> Use the structure name and describe the firmware handle, device ID,
> and total number of available rings used during DMA ring initialization.
> 
> Fixes: d782298c6f6b ("soc: ti: k3-ringacc: add AM64 DMA rings support.")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> 
> Notes (ti-ringacc-v2):
>     Changes in v2:
>     - Describe num_rings as the total number of available rings in the
>       comment and commit message, as pointed out by Udit Kumar.
>     
>     Patch 1 is unchanged.
>     
>     v1: https://lore.kernel.org/r/20260919163721.89044-1-kmehltretter@gmail.com/
> 
>  include/linux/soc/ti/k3-ringacc.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/soc/ti/k3-ringacc.h b/include/linux/soc/ti/k3-ringacc.h
> index 2de6031b9424..7b7fc237c08f 100644
> --- a/include/linux/soc/ti/k3-ringacc.h
> +++ b/include/linux/soc/ti/k3-ringacc.h
> @@ -254,7 +254,10 @@ u32 k3_ringacc_get_tisci_dev_id(struct k3_ring *ring);
>  struct ti_sci_handle;
>  
>  /**
> - * struct struct k3_ringacc_init_data - Initialization data for DMA rings
> + * struct k3_ringacc_init_data - Initialization data for DMA rings
> + * @tisci: TI SCI firmware handle
> + * @tisci_dev_id: TI SCI device ID of the DMA controller
> + * @num_rings: Total number of available rings
>   */

Reviewed-by: Udit Kumar <u-kumar1@ti.com>

>  struct k3_ringacc_init_data {
>  	const struct ti_sci_handle *tisci;