From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD95C433F5 for ; Wed, 23 Feb 2022 03:42:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235872AbiBWDnI (ORCPT ); Tue, 22 Feb 2022 22:43:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237640AbiBWDmw (ORCPT ); Tue, 22 Feb 2022 22:42:52 -0500 Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 509413EF1F for ; Tue, 22 Feb 2022 19:42:18 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id A24D2580207; Tue, 22 Feb 2022 22:42:17 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 22 Feb 2022 22:42:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; bh=yh5oiXgQfk3oTq k3JJphdKYAq5z0QRmGrTaoXUwh8dY=; b=XFQyzDyQnbr8GPgWEC0QohCixgGBA5 QyKJv7rhS5iKSD6xvnEeucOopxsu5wDZzjlbctjyuYemdoRU1e/cITDhx1NkMP3n AMM6nbqXHiwYSI8lU3p/qmoyZJYYm5TTo+wie9kO19O/cLBP+PdEEqfbca60myY8 WmxALNTIM5CIG5NScDHBlaDiS5xwwpArioYnw9ZokBV55/GZgyooEh8Eq+5Wcac/ bSDCTCzfLv7EXrJcEZe4N2pcFjFWQaBPOVFwBttHqZ2+3/zfkkIr4pIuk6nFlyej wIyEZtiIsNCvIgLvFpo1XOcswLamNLhygfk59TXk4za3Td9EkfNuRlyQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=yh5oiXgQfk3oTqk3JJphdKYAq5z0QRmGrTaoXUwh8 dY=; b=KWvruJy0TUDUb0FnKQ4Jckq/i6SoiMzTAYZTh3cQ/p/Tkks+fgLOx1wj1 jdRYFNFV4yvSuHkAMe/A3f5RTM7ajobiU9LoSSwwYWQqdBh7y3122oKcB+kdl2f2 Ccm6Jbv3QXC6w4UNl19iM1IEnJDTv15SQkjOX4BInjYZNnly9nCdlyMq9/IYmrxk CRspxCW256sMqLxPhPtR8AsHRKVvJVHtN564mDe2uzoN1vX7ZS425M5wBPA78ocY ZCb4AmJo7eYyiqdlXMmwj1znMmbAD4djeXRe9SNTnf5XEaNpeL5IzBuAO4L5sWjC 8VQscogV525381bV3zzPE5H+Q2BsQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeelgdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefurghmuhgv lhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenucggtf frrghtthgvrhhnpefgveffteelheffjeeukedvkedviedtheevgeefkeehueeiieeuteeu gfettdeggeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Feb 2022 22:42:16 -0500 (EST) Subject: Re: [PATCH v10 12/18] phy: sun4i-usb: Rework HCI PHY (aka. "pmu_unk1") handling To: Andre Przywara Cc: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Rob Herring , Ondrej Jirman , Icenowy Zheng , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , linux-phy@lists.infradead.org References: <20220211122643.1343315-1-andre.przywara@arm.com> <20220211122643.1343315-13-andre.przywara@arm.com> From: Samuel Holland Message-ID: <40b6855b-7fac-e9bf-af9b-885d54530054@sholland.org> Date: Tue, 22 Feb 2022 21:42:15 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20220211122643.1343315-13-andre.przywara@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/22 6:26 AM, Andre Przywara wrote: > As Icenowy pointed out, newer manuals (starting with H6) actually > document the register block at offset 0x800 as "HCI controller and PHY > interface", also describe the bits in our "PMU_UNK1" register. > Let's put proper names to those "unknown" variables and symbols. > > While we are at it, generalise the existing code by allowing a bitmap > of bits to clear and set, to cover newer SoCs: The A100 and H616 use a > different bit for the SIDDQ control. > > Signed-off-by: Andre Przywara Acked-by: Samuel Holland Tested-by: Samuel Holland Tested on D1, which also requires this patch.