mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Zi Yan <ziy@nvidia.com>,
	linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Yang Shi <shy828301@gmail.com>, Mel Gorman <mgorman@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] mm/migrate: move common code to numa_migrate_check (was numa_migrate_prep)
Date: Mon, 12 Aug 2024 11:06:49 +0200	[thread overview]
Message-ID: <40b6c730-a5ff-4bf3-b284-179098bda0fb@redhat.com> (raw)
In-Reply-To: <87msliv5wd.fsf@yhuang6-desk2.ccr.corp.intel.com>

On 12.08.24 04:20, Huang, Ying wrote:
> David Hildenbrand <david@redhat.com> writes:
> 
>> On 09.08.24 16:59, Zi Yan wrote:
>>> do_numa_page() and do_huge_pmd_numa_page() share a lot of common code. To
>>> reduce redundancy, move common code to numa_migrate_prep() and rename
>>> the function to numa_migrate_check() to reflect its functionality.
>>> Now do_huge_pmd_numa_page() also checks shared folios to set
>>> TNF_SHARED flag.
>>
>> Yeah, I was also wondering why we didn't check that in the PMD case.
> 
> IIUC, before commit 728be28fae8c ("mm: migrate: remove THP mapcount
> check in numamigrate_isolate_page()"), we don't allow to migrate THP
> with mapcount > 1.  So, it's unnecessary to set TNF_SHARED flag at that
> time.  However, after that commit, we need to do it.

Thanks for the pointer, rings a bell. Indeed, the check was remove for a 
different purpose, so introducing a check for setting the flag makes sense.

-- 
Cheers,

David / dhildenb


      reply	other threads:[~2024-08-12  9:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09 14:59 [PATCH v3 0/3] do_numa_page(),do_huge_pmd_numa_page() fix and cleanup Zi Yan
2024-08-09 14:59 ` [PATCH v3 1/3] mm/numa: no task_numa_fault() call if PTE is changed Zi Yan
2024-08-09 15:29   ` David Hildenbrand
2024-08-09 14:59 ` [PATCH v3 2/3] mm/numa: no task_numa_fault() call if PMD " Zi Yan
2024-08-09 15:29   ` David Hildenbrand
2024-08-09 14:59 ` [PATCH v3 3/3] mm/migrate: move common code to numa_migrate_check (was numa_migrate_prep) Zi Yan
2024-08-09 15:32   ` David Hildenbrand
2024-08-12  2:20     ` Huang, Ying
2024-08-12  9:06       ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40b6c730-a5ff-4bf3-b284-179098bda0fb@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=shy828301@gmail.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=ying.huang@intel.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®