From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47963C35280 for ; Mon, 30 Sep 2019 12:52:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E752218AC for ; Mon, 30 Sep 2019 12:52:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731012AbfI3MwO (ORCPT ); Mon, 30 Sep 2019 08:52:14 -0400 Received: from foss.arm.com ([217.140.110.172]:53586 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729984AbfI3MwO (ORCPT ); Mon, 30 Sep 2019 08:52:14 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 32B911000; Mon, 30 Sep 2019 05:52:13 -0700 (PDT) Received: from [10.1.197.57] (e110467-lin.cambridge.arm.com [10.1.197.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 634143F706; Mon, 30 Sep 2019 05:52:11 -0700 (PDT) Subject: Re: [PATCH 00/11] of: dma-ranges fixes and improvements To: Marek Vasut , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Florian Fainelli , Stefan Wahren , Frank Rowand , Arnd Bergmann , Geert Uytterhoeven , Simon Horman , Lorenzo Pieralisi , Oza Pawandeep References: <20190927002455.13169-1-robh@kernel.org> <106d5b37-5732-204f-4140-8d528256a59b@gmail.com> From: Robin Murphy Message-ID: <40bdf7cf-3bb1-24f8-844d-3eefbc761aba@arm.com> Date: Mon, 30 Sep 2019 13:52:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <106d5b37-5732-204f-4140-8d528256a59b@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/09/2019 13:40, Marek Vasut wrote: > On 9/27/19 2:24 AM, Rob Herring wrote: >> This series fixes several issues related to 'dma-ranges'. Primarily, >> 'dma-ranges' in a PCI bridge node does correctly set dma masks for PCI >> devices not described in the DT. A common case needing dma-ranges is a >> 32-bit PCIe bridge on a 64-bit system. This affects several platforms >> including Broadcom, NXP, Renesas, and Arm Juno. There's been several >> attempts to fix these issues, most recently earlier this week[1]. >> >> In the process, I found several bugs in the address translation. It >> appears that things have happened to work as various DTs happen to use >> 1:1 addresses. >> >> First 3 patches are just some clean-up. The 4th patch adds a unittest >> exhibiting the issues. Patches 5-9 rework how of_dma_configure() works >> making it work on either a struct device child node or a struct >> device_node parent node so that it works on bus leaf nodes like PCI >> bridges. Patches 10 and 11 fix 2 issues with address translation for >> dma-ranges. >> >> My testing on this has been with QEMU virt machine hacked up to set PCI >> dma-ranges and the unittest. Nicolas reports this series resolves the >> issues on Rpi4 and NXP Layerscape platforms. > > With the following patches applied: > https://patchwork.ozlabs.org/patch/1144870/ > https://patchwork.ozlabs.org/patch/1144871/ Can you try it without those additional patches? This series aims to make the parsing work properly generically, such that we shouldn't need to add an additional PCI-specific version of almost the same code. Robin.