mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian W MORRISON <ianwmorrison@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org, hadess@hadess.net,
	Larry.Finger@lwfinger.net, hdegoede@redhat.com,
	jes.sorensen@gmail.com, kvalo@qca.qualcomm.com
Subject: [PATCH v5] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c
Date: Sun, 7 May 2017 20:04:59 +1000	[thread overview]
Message-ID: <40c81df4-d17f-c374-e5a8-c5b8edd914b5@gmail.com> (raw)
In-Reply-To: <8b27a07c-ecb1-21be-bf8f-e7365ec000f4@gmail.com>

A kernel cloned from 
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and 
built with the latest RTL8723BS driver included (CONFIG_RTL8723BS=m) 
fails when booting on an Intel Atom device with the RTL8723BS wifi 
chipset due to an error in 
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c.

The kernel when booted with Ubuntu 17.04 results in an unusable system 
however with the following patch booting is successful and the system 
is usable. The patch and kernel builds have been tested against on an 
Intel Compute Stick (STCK1A32WFC model).

This version of the patch (version 5) has tabs rather than spaces, no 
wrap around, a changelog and a sign-off email. 

Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Ian W Morrison <ianwmorrison@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index f17f4fb..2ee9df5 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter, struct device *dev)
 		pwdev_priv->power_mgmt = true;
 	else
 		pwdev_priv->power_mgmt = false;
-	kfree((u8 *)wdev);
 
 	return ret;
 
-- 
1.9.1

  reply	other threads:[~2017-05-07 22:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-07  3:37 [PATCH v3] " Ian W MORRISON
2017-05-07  4:01 ` [PATCH v4] " Ian W MORRISON
2017-05-07 10:04   ` Ian W MORRISON [this message]
2017-05-08 13:40     ` [PATCH v6] " Ian W MORRISON
2017-05-08 14:42     ` [PATCH v5] " Andy Shevchenko
2017-05-08 15:06 Ian W MORRISON

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40c81df4-d17f-c374-e5a8-c5b8edd914b5@gmail.com \
    --to=ianwmorrison@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hadess@hadess.net \
    --cc=hdegoede@redhat.com \
    --cc=jes.sorensen@gmail.com \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome