From: Andrew Lunn <andrew@lunn.ch>
To: Frank Sae <Frank.Sae@motor-comm.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Masahiro Yamada <masahiroy@kernel.org>,
Parthiban.Veerasooran@microchip.com,
linux-kernel@vger.kernel.org, xiaogang.fan@motor-comm.com,
fei.zhang@motor-comm.com, hua.sun@motor-comm.com
Subject: Re: [PATCH net-next v3 05/14] motorcomm:yt6801: Implement the .ndo_open function
Date: Fri, 28 Feb 2025 15:32:20 +0100 [thread overview]
Message-ID: <40d06932-3704-4eea-887f-ba286085532d@lunn.ch> (raw)
In-Reply-To: <20250228100020.3944-6-Frank.Sae@motor-comm.com>
> +static int fxgmac_open(struct net_device *netdev)
> +{
> + struct fxgmac_pdata *priv = netdev_priv(netdev);
> + int ret;
> +
> + mutex_lock(&priv->mutex);
What is this mutex protecting? Where it is defined you have:
struct mutex mutex; /* Driver lock */
which does not help at all. Why is the RTNL lock not sufficient?
Andrew
next prev parent reply other threads:[~2025-02-28 14:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 10:00 [PATCH net-next v3 00/14] net:yt6801: Add Motorcomm yt6801 PCIe driver Frank Sae
2025-02-28 10:00 ` [PATCH net-next v3 02/14] motorcomm:yt6801: Add support for a pci table in this module Frank Sae
2025-03-06 13:29 ` Philipp Stanner
2025-02-28 10:00 ` [PATCH net-next v3 03/14] motorcomm:yt6801: Implement pci_driver shutdown Frank Sae
2025-02-28 10:00 ` [PATCH net-next v3 05/14] motorcomm:yt6801: Implement the .ndo_open function Frank Sae
2025-02-28 14:32 ` Andrew Lunn [this message]
2025-02-28 10:00 ` [PATCH net-next v3 06/14] motorcomm:yt6801: Implement the fxgmac_start function Frank Sae
2025-02-28 14:10 ` Andrew Lunn
2025-02-28 10:00 ` [PATCH net-next v3 07/14] phy:motorcomm: Add PHY_INTERFACE_MODE_INTERNAL to support YT6801 Frank Sae
2025-02-28 10:14 ` Russell King (Oracle)
2025-02-28 10:00 ` [PATCH net-next v3 08/14] motorcomm:yt6801: Implement the fxgmac_hw_init function Frank Sae
2025-02-28 10:00 ` [PATCH net-next v3 12/14] motorcomm:yt6801: Implement pci_driver suspend and resume Frank Sae
2025-02-28 10:00 ` [PATCH net-next v3 13/14] motorcomm:yt6801: Add makefile and Kconfig Frank Sae
2025-02-28 10:00 ` [PATCH net-next v3 14/14] motorcomm:yt6801: update ethernet documentation and maintainer Frank Sae
2025-02-28 10:01 ` [PATCH net-next v3 01/14] motorcomm:yt6801: Implement mdio register Frank Sae
2025-02-28 14:01 ` Andrew Lunn
2025-02-28 10:01 ` [PATCH net-next v3 04/14] motorcomm:yt6801: Implement the fxgmac_init function Frank Sae
2025-02-28 10:01 ` [PATCH net-next v3 09/14] motorcomm:yt6801: Implement the poll functions Frank Sae
2025-02-28 10:01 ` [PATCH net-next v3 11/14] motorcomm:yt6801: Implement some net_device_ops function Frank Sae
2025-02-28 10:01 ` [PATCH net-next v3 10/14] motorcomm:yt6801: Implement .ndo_start_xmit function Frank Sae
2025-03-04 15:48 ` [PATCH net-next v3 00/14] net:yt6801: Add Motorcomm yt6801 PCIe driver Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40d06932-3704-4eea-887f-ba286085532d@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Sae@motor-comm.com \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fei.zhang@motor-comm.com \
--cc=hkallweit1@gmail.com \
--cc=hua.sun@motor-comm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiaogang.fan@motor-comm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®