From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751506AbdHFTZG (ORCPT ); Sun, 6 Aug 2017 15:25:06 -0400 Received: from mout.web.de ([212.227.17.11]:53527 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbdHFTZF (ORCPT ); Sun, 6 Aug 2017 15:25:05 -0400 Subject: [PATCH 5/5] mtip32xx: Adjust an input validation check in mtip_hw_debugfs_exit() From: SF Markus Elfring To: Bart Van Assche , Jens Axboe , Johannes Thumshirn , Ming Lei , Sagi Grimberg Cc: LKML , kernel-janitors@vger.kernel.org References: <524db5d1-1411-a839-6461-7c33403c1843@users.sourceforge.net> Message-ID: <40d24351-3d62-e4f7-751a-637c0c3b7977@users.sourceforge.net> Date: Sun, 6 Aug 2017 21:24:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <524db5d1-1411-a839-6461-7c33403c1843@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Rjzx9jzslTig+0qiHf1v3UMqdFl7XryTJN8T0nFYYkIu3PN0s+r uzO85PaBp72Eryvr5vFsfB3MNqJk2B35sQ5N3Yt3qzSSDb3cgA/zJq956W75W09EWq4D0JA GG7ryGGGoFSLRF046dHLufXrCH/MYPuyySqAIeMFPTyWbGWdDzxGpPRGyrrdErubPBD5N+u 1NYEeKbLycUCnd/NMAooQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:P6ocrb+pfX0=:Ag/uo/OKEekXCIkakN69ip bF+Cs3aZCGOSvTiMajk4GvkYVqD9356or2o5JVyrguYcpA0x4PUbm5F+D7YejvqSHixr2bntY f6owIlsoabzOTvmEyDrMwNSaI7g1mY1+0aQ56z0syIp/pcRtK1QoeZUOvmWDFzv+3yyO6+uah 4AgliiQwEG2WTdwh30/DPlSyVLYssSKHxZuclK4Sq0BbydtR6yUTHp6ycRHpGHDuMzT9bWKOE 8tCXn8rv0XCl4YoyKUi45DonW62yWgBbuhrTwc5eBxBJv09C2PY1+KJFmJb1f/h98PGbKvh54 LzexpCTlpJ+U9rA1VEbbBUKQPa8n2YhvUYsj2poj7il4K5M57EOKZUW601cCYgvxSb+DaBg5s y6zlAyUPkZmvqXXi2n9Co2ojRGVXHuxBeJr9u+CWa1saK6nVTROhak61pATrcTKXIA0xRJoVC V1PVqv+wnJOKIdTVhaIZN5EqBoI7AG+ghSO0k6kfYMQqkd6TWUDcfM+75nXNvR5A8QIOpJFDZ +5pBV31u+iag7T68801v/iIDUVT09qreHmUC5rOLQShwX0L6hV5eTCQS+QFBPX/rFWhXTm8yo kxhYIy8jtPL0PWjWs5ugVJ5IXQgmFuEDE7lokNNYNIgsJ/ZF45O0/RdsjW+9owZo8dsN8qmRn N6liRKEsOClZr191HjufZdTA9U3qokVCGG/ZJDS3dkgWVOLqHsuN/DopihqRHKHRSWD5hms4u T+NVItYRMX8Tn0k4tstG+lbqYFeqBphKJwYBGZXZn4JLYZg+lt10c+u5rBA5Ails9d54k52iz k8v2boqeBRsb3Ug5g+QzPL0lpo4VcLD40cP3SIT4PPSNSDQqIw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 6 Aug 2017 20:52:26 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: debugfs_remove_recursive(NULL) is safe and this check is probably not required Thus adjust this source code place. Signed-off-by: Markus Elfring --- drivers/block/mtip32xx/mtip32xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index 18e634efed95..db37ff872d56 100644 --- a/drivers/block/mtip32xx/mtip32xx.c +++ b/drivers/block/mtip32xx/mtip32xx.c @@ -2572,7 +2572,7 @@ static int mtip_hw_debugfs_init(struct driver_data *dd) static void mtip_hw_debugfs_exit(struct driver_data *dd) { - if (dd->dfs_node) + if (dd) debugfs_remove_recursive(dd->dfs_node); } -- 2.13.4