From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE46C64E7D for ; Fri, 27 Nov 2020 12:45:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE94D22245 for ; Fri, 27 Nov 2020 12:45:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729641AbgK0Mps (ORCPT ); Fri, 27 Nov 2020 07:45:48 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:54913 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726477AbgK0Mpr (ORCPT ); Fri, 27 Nov 2020 07:45:47 -0500 Received: from [192.168.1.155] ([95.114.158.11]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MPp0l-1kWAmh23Dn-00Mw0R; Fri, 27 Nov 2020 13:45:20 +0100 Subject: Re: [PATCH] drivers: gpio: use of_match_ptr() and ACPI_PTR() macros To: Andy Shevchenko , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= Cc: "Enrico Weigelt, metux IT consult" , Jonathan Cameron , Linus Walleij , linux-tegra@vger.kernel.org, Thierry Reding , Alban Bedel , Manivannan Sadhasivam , Lee Jones , Florian Fainelli , Kevin Hilman , zhang.lyra@gmail.com, =?UTF-8?Q?Marek_Beh=c3=ban?= , Bartosz Golaszewski , bcm-kernel-feedback-list , dl-linux-imx , orsonzhai@gmail.com, Eugeniy Paltsev , linux-pwm@vger.kernel.org, Grygorii Strashko , Philipp Zabel , Sascha Hauer , Vladimir Zapolskiy , "open list:GPIO SUBSYSTEM" , Fabio Estevam , Santosh Shilimkar , Matthias Brugger , Linux OMAP Mailing List , Hoan Tran , Scott Branden , Andrew Jeffery , Linux Kernel Mailing List , Serge Semin , Sascha Hauer , baolin.wang7@gmail.com, Shawn Guo References: <20201117154340.18216-1-info@metux.net> <20201118095342.sviuxvfsbmmn22mo@pengutronix.de> From: "Enrico Weigelt, metux IT consult" Message-ID: <40d468a6-f8ba-7535-55dd-e91ba8299958@metux.net> Date: Fri, 27 Nov 2020 13:45:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:yMIP6nH7cKntCrJuLgf/M3+4XwFIPkg7UfYtSb9J0SkpG6sGOv7 /IR7PEjcUkbXZfn95xvF9kPZZUOb9RUnvrwEmPu6rP+AgFH9G1KbtEQbrGI6dOjDEAwqV/E EczzEgEJ3pvoStGVhjYfBSBY8R6QOUQt5Ao1T/pFBNKAztiWswegrgTUhY7Sz/LsMkjc4PG AXU7u5vqunrqkbLcYUoQg== X-UI-Out-Filterresults: notjunk:1;V03:K0:m5fjPJhCYJQ=:4vrnvGfA8e+95x4fem3OkF DfLkWIz4U0aBa8HLZrIOXcD4NWRi5pMo8Oa4rh/JJ6ngXDJTm/+FAY8quNYB/ANwdfDZQe48s k2CqQzxtZtilcnmHKe3lkzxpcwcFbAmCgCYFK3D/auj506nTbYO4c624QAzeKlxqJ9aCHd+Wt hI3o1ZxJl9DrzDwcoXjkznsF6FbhuSIoOss3ewNaFyBSbu3g2nqwNlNyj2HOFbPxM+r/J2tuu bZJU0A6yKpvQn5LrOthHb8IMcDYU+ctkst0nQXTHzlI8rZMMh1Y6r4K/vLbyb1aJ7BZlF8YaF Qx59hp3Vk6LqR7JSnkqsESRE70Qu6MnElAe5u2/7HTI9LGVM6UaRVUiDMjxUT4psNxVyefUaX /w7EbD7LArRl27YIShkQumClWDiabxBy/5FbFvypZGCtrLVGaftrxq8KTeQFL Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.11.20 11:01, Andy Shevchenko wrote: >>> So a system without CONFIG_OF might still make use of .of_match_table? >> >> Yep! > > If you are curious: > https://elixir.bootlin.com/linux/latest/source/drivers/acpi/bus.c#L615 Phuh, this changes everything ... sorry, didn't know that. If ACPI now can contain OF pieces, we should ask the question whether of_match_ptr() should be used at all. Would it be a compromise introducing a new macro (eg. "OF_MATCH_PTR()") which passes through the pointer if either OF or ACPI is enabled. Maybe we could introduce a new config item (eg "OF_MATCH_TABLE") for that, which is enabled by both OF and ACPI. And maybe add an option for of-compatible checking in ACPI. How do you folks think about that ? --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287