Re: [PATCH v1 1/2] dt-bindings: soundwire: qcom: add qcom,swr-master-ee-val property

[Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>]

On 6/9/2026 1:47 PM, Srinivas Kandagatla wrote:
> 
> 
> On 6/8/26 6:53 PM, Mohammad Rafi Shaik wrote:
>> Add documentation for the qcom,swr-master-ee-val Device Tree property
>> used by Qualcomm SoundWire masters to describe the execution-environment
>> value for interrupt routing.
>>
>> This property allows platform DTs to specify the EE value used to direct
> 
> this sounds wrong, this should never be platform specific, this is SoC
> specific.
> 

Agreed, this is SoC-specific and should not be described as 
platform-specific. I will update the description accordingly.

>> SoundWire master interrupts to the appropriate CPU target.
> 
> Why should this come from DT, driver should be able to make a choice
> based on SoC compatible string.
> 

Currently, the driver uses a version-specific compatible string rather 
than a SoC-specific one, so it cannot reliably infer this information. 
That is why the configuration is being provided through DT.

This is a hardware requirement specific to the Shikra SoC. The DT entry 
was added to retrieve the EE value required for this configuration.

Thanks & Regards,
Rafi.

> 
> 
> --srini
> 
> 
>>
>> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
>> ---
>>   .../devicetree/bindings/soundwire/qcom,soundwire.yaml       | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
>> index 9447a2f37..5b06cc1a5 100644
>> --- a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
>> +++ b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
>> @@ -215,6 +215,12 @@ properties:
>>             maximum: 4
>>           - const: 0xff
>>   
>> +  qcom,swr-master-ee-val:
>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>> +    description:
>> +      Execution-environment value used to route SoundWire master
>> +      interrupts to CPU0 or CPU1.
>> +
>>     label:
>>       maxItems: 1
>>   
>