From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 039E6385505 for ; Fri, 3 Apr 2026 10:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775210978; cv=none; b=GQhVdWRd8KnpNgctL2u5wdrJADrra7XLGu9dcrCeGHyZhojwBikVwqwnOorGsAhbWQlmrtE5RoOAbJMP7uwvK5eQqTjq3TJuKv5PF4EwPbraQOjBqE/pEPQ1m/yRSfuFY6U8L5Kt+3mVM64vI2vTuVUuKD1naZraQE9OOscLl4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775210978; c=relaxed/simple; bh=TINvKdSrQ/NGl2be3nDTbiLQxZXwyhQucUzBFBqHyEU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V0L44C5I5n/iHYavJ//0DRvwZ7sdqYVXXCgZAq2VKWdzZj7OsjDAtjY2ItGAxZgK/gQFhsvS4wbvdc3WNqrrRLHLLQ/BD56qJXvIguEDObIiQcWqLS8c5zEAYqKRrucpvvGmdlPHrY7jCo9kDglx4nMLPt21hxdlckaPjyTosbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tsEgU0l0; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tsEgU0l0" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5a2c0710afdso205574e87.1 for ; Fri, 03 Apr 2026 03:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775210973; x=1775815773; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=/3jZs1YU/5kS4rEiiUTRNMXO5M8WRI2oxv3zjAIg5U4=; b=tsEgU0l0kF1/msz4dw2bxWLbKMzYXq1+HWVudjh0DErkZ9jgjVDcVykWi03Oukpath wX7xprz0wCEK7rrH3lNlq2yrxbhfd8CsmKaE3OcMK9lEZPSLyueGpdRT/TxRna4KRIJV KxfGzU2PukP1Op2KKP0iAq5w/pZM3GnV5rD/81+1+0BVAzQH832G5cT1RC+004ZzdXTp DuLxEipQQCdgVMll7OJZvBsd+LKuU79N5kHp7VHEHv1fpH0cllvTK+dOhUBxXDfq3I7r PbDe0HC388F0NDrKODP9MN5mRn0Osgyno2DAZ4RJo/VDPIL4Lno44NbzuRbaBJbOaVSL 1DxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775210973; x=1775815773; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/3jZs1YU/5kS4rEiiUTRNMXO5M8WRI2oxv3zjAIg5U4=; b=f4QkgFRueep/7+h8Of6w4ve07UEWjo/NwZeUR+kW/qCctpFNc/CgQtr40eml9pVxIa 2ZwJ9W4qCYfuhMuvT2SQsdUHMycy8TlV0bngG0rhgx9B+0JxIenieniHayCrMeelDPeO cIviswlywCfOtsexGSw160rx6W5yu5a2U02MRJl8e6bBV5ECTR3ieIEGffypXgdW6xFC CefrTvbSSTJSCsiD+R0bf27Syi2WTxtYjAE0xoO5ibuo2fWtDQJbmuQas0qytMZF9BbD +eDov2icBdIGV9Pz1HuelqE+RtTW4r+/SOc8Ph7oz/Tc3FqxYvkQJ5sadGSBdGRP0X+k BVxg== X-Forwarded-Encrypted: i=1; AJvYcCX5Fnnowo+oqqdi1oSZYPgLCXNtK1cWQ6TJn9C+MMgdXAR4rUDQbLLKGaKQDj8q2QyKomPUUHgwg/EAKuI=@vger.kernel.org X-Gm-Message-State: AOJu0YxY3tCwrDlkJua8ztH+ExxqUgVvAOup2h2mLffvR/fgCb/LJKD1 ngIt1GQxL9DRHSJviwlUOSvtUFeA101I3SZxoCCfQGcAoCVKGTWppVH1HWItICoaD7M= X-Gm-Gg: AeBDies62nV/IkE35ICBgEUpFsLu3FDol/uBP7OEO/iroDdI6LbsnX8XAwS7h+owsu6 CPyrhdirJOVkACB5YSy/A3eq6kxvVD/AW5w7hkkpzvhDmfOa1DPG9mUum5aUCdmCFEfOGUEWrj/ WqwW3iIBrfBoSrhs0/TCWq13AuU3APwazqnzODwbPFHvZAfa2U1v8p2n6JV389PlfXQHfKTMzUz 6g8Zjm6WH/p2YRI/EaiUJw8bq4iMgdtMQmgSnPfLx9yj71GlZcuV/BuTD2/Q9OQqEiU+YcSChwZ as1YVx0L7y8bNkaFTIxHwjd7Qh5j1LFuZNw3T1NET3sG6IbTAN8fEqlG4X1o4f/ofI3JyKwJYKs 3T9gW9wUXztY4NyhK2X2KBqo38f+xXoJWhhGzLUMAJOdqnRRpsZ+d2KZ0uHt7MvhEkUzH/3K/Gz lnlF41hfhpArgjZC7PbM7lrjat+dXjOVcch6dkyUM+UvexrZI3TuW9Y1/UO+VN+NaGlsQ5NxpjS ZTLHw== X-Received: by 2002:a05:6512:23a2:b0:5a1:38c4:424e with SMTP id 2adb3069b0e04-5a33758e02emr390883e87.7.1775210972916; Fri, 03 Apr 2026 03:09:32 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2c6cc6033sm1374630e87.48.2026.04.03.03.09.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2026 03:09:32 -0700 (PDT) Message-ID: <40e9f0f5-8b22-4535-a1e0-6c5073ef94d6@linaro.org> Date: Fri, 3 Apr 2026 13:09:31 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/3] Add CAMSS support for SM6350 To: Luca Weiss Cc: Bryan O'Donoghue , Konrad Dybcio , Bryan O'Donoghue , Conor Dooley , Robert Foss , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Bjorn Andersson References: <20260216-sm6350-camss-v4-0-b9df35f87edb@fairphone.com> <2a108976-374a-46e1-968d-7befa4369a74@linaro.org> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Luca. On 4/3/26 11:09, Luca Weiss wrote: > Hi Vladimir, > > On Tue Mar 31, 2026 at 12:49 AM CEST, Vladimir Zapolskiy wrote: >> Hi Luca, >> >> On 2/16/26 10:54, Luca Weiss wrote: >>> Add bindings, driver and dts to support the Camera Subsystem on the >>> SM6350 SoC. >>> >>> These patches were tested on a Fairphone 4 smartphone with WIP sensor >>> drivers (Sony IMX576 and IMX582), the camera pipeline works properly as >>> far as I can tell. >>> >>> Though when stopping the camera stream, the following clock warning >>> appears in dmesg. But it does not interfere with any functionality, >>> starting and stopping the stream works and debugcc is showing 426.4 MHz >>> while the clock is on, and 'off' while it's off. >>> >>> Any suggestion how to fix this, is appreciated. >> >> I've looked at CAMCC recently, and I do notice that SM6350 CAMCC does not >> set '.use_rpm = true' flag for whatever reason. >> >> If you find a free minute, can you test the change below?.. > > Unfortunately that change does not resolve the "gcc_camera_axi_clk > status stuck at 'on'" warning. > > fairphone-fp4:~$ cat /sys/bus/platform/drivers/sm6350-camcc/ad00000.clock-controller/power/runtime_status > active > > fairphone-fp4:~$ cat /sys/bus/platform/drivers/sm6350-camcc/ad00000.clock-controller/power/runtime_status > suspended > So it seems to be a technically deeper issue, once given insights by Imran likely to be very relevant: https://lore.kernel.org/linux-arm-msm/caa870e2-3795-40bc-9f0e-c93e313c8c6e@oss.qualcomm.com/ >> >> ----8<---- >> diff --git a/drivers/clk/qcom/camcc-sm6350.c b/drivers/clk/qcom/camcc-sm6350.c >> index 7df12c1311c6..ba880e4edcaf 100644 >> --- a/drivers/clk/qcom/camcc-sm6350.c >> +++ b/drivers/clk/qcom/camcc-sm6350.c >> @@ -1880,6 +1880,7 @@ static const struct qcom_cc_desc camcc_sm6350_desc = { >> .num_clks = ARRAY_SIZE(camcc_sm6350_clocks), >> .gdscs = camcc_sm6350_gdscs, >> .num_gdscs = ARRAY_SIZE(camcc_sm6350_gdscs), >> + .use_rpm = true, >> }; >> >> static const struct of_device_id camcc_sm6350_match_table[] = { >> ----8<---- >> >> This change could be considered to be included in any case, I believe. > > I guess this change is now the way to enable pm_runtime, I had this > series 3 years ago in February 2023: > https://lore.kernel.org/linux-arm-msm/20230213-sm6350-camcc-runtime_pm-v3-0-d35e0d833cc4@fairphone.com/ > > But I never followed up due to me not understanding pm_runtime well and > no direct need for it. > > But I guess reviving that with use_rpm = true, add power-domains & > required-opps to dt-bindings and sm6350.dtsi should be a good idea? > It should be, if SM6350 CAMCC is known to belong to an on-SoC power domain, then devm_pm_runtime_enable() will be called on .probe to embed the controller driver into the runtime PM framework, see commit c0b6627369bc. Power domain management of devices is handled inside the runtime PM. -- Best wishes, Vladimir