From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46BEC2D0DB for ; Tue, 21 Jan 2020 08:39:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA16F22522 for ; Tue, 21 Jan 2020 08:39:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="ogeQ32MO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728456AbgAUIjR (ORCPT ); Tue, 21 Jan 2020 03:39:17 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:34035 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728093AbgAUIjQ (ORCPT ); Tue, 21 Jan 2020 03:39:16 -0500 Received: by mail-lf1-f65.google.com with SMTP id l18so1571180lfc.1 for ; Tue, 21 Jan 2020 00:39:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hsNWoes18WxCFqI2xo+zG2UAVBdbnLW1RdahXtCWkN4=; b=ogeQ32MOdjzdgAmxRr2eY6wFvxsdi2q0zPB1rFdofpYEO51IIsVHTP/MpXts48N+Hu 4iZtIN1cDXQuFYvBGceJ5W03NNZraJNYMDKMSvJOsV+lneWXcfyzASCoSAqZQihD2yEM QdR/SJOIEFHL8SXJ581I6hl5NpDqF6nH7lxfCZQmjvsmwfc9zvkQiN3Xw/YMv82SD2f2 Ev5dOkK0Dl59TsTdsxmED6+cxcIYkHOvcHdM5IM1NU2kwzezkUMm6G8LimxsPNcxSP/d 5hJm2EW0ST6IRLKF9J/typuxf8l7gKRBMVHY/PbUh5iEVxcNkVDOrrSBubvTbYNahV9K /Sxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hsNWoes18WxCFqI2xo+zG2UAVBdbnLW1RdahXtCWkN4=; b=jzvfrhdKSGXAqpcLfppI9/Gh7YMJkO6zl/haQ8NwYltNDjsPFfQol776aYfdM4cvD6 qEUGdYWZuqKSGntS2EbGEQmvaEVIuEQTQGBhDOjs4TRtMs+whAg23BIleeJCma+aeBRG ZuPL28Ldvp6YzvTzbi7SghROOJZH7gfzWWVOStIMcHsWOFm9A2toIBRL8YiVSnQ70rdB r2u5uTDsR9AzZQY4TpzxQvz3FKJ/WaLa/BPwX8ueEjUW/0PdfWn9/WCQwr43spFV22Xa qiALF7Edxzrp9avg7P73HPKCG27STVPcPuGR7LCo8WqHfD67UdVRsI4EpgIbxosDghCA WrIQ== X-Gm-Message-State: APjAAAWenl8o8hG7tTj4jYtjjA+AYUbJhaQLNEBCjzupCcuH3aMEJnFl X3WYoMHHA3M8lyHaYVmT2Prd5D4jNjz+bA== X-Google-Smtp-Source: APXvYqwKhPhYL0ooaJpzntwbDv2rsPpjcDAD4+2ocnxH+WdV/2FygoMaU5dMv0QJe5KSTwUYfqw3Ow== X-Received: by 2002:ac2:43c6:: with SMTP id u6mr2027596lfl.191.1579595953303; Tue, 21 Jan 2020 00:39:13 -0800 (PST) Received: from ?IPv6:2a00:1fa0:4257:4d38:8de3:4197:be8e:7729? ([2a00:1fa0:4257:4d38:8de3:4197:be8e:7729]) by smtp.gmail.com with ESMTPSA id b1sm21197686ljp.72.2020.01.21.00.39.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2020 00:39:12 -0800 (PST) Subject: Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0 To: Chen Zhou , davem@davemloft.net, mhabets@solarflare.com, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200121013553.15252-1-chenzhou10@huawei.com> From: Sergei Shtylyov Message-ID: <40eb3815-f677-c2fd-3e67-4b39bb332f48@cogentembedded.com> Date: Tue, 21 Jan 2020 11:39:05 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200121013553.15252-1-chenzhou10@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 21.01.2020 4:35, Chen Zhou wrote: > Fixes coccicheck warning: > > ./drivers/net/ethernet/amd/declance.c:611:14-15: > WARNING comparing pointer to 0 > > Compare pointer-typed values to NULL rather than 0. I don't see NULL in the patch -- you used ! instead. > Signed-off-by: Chen Zhou > --- > drivers/net/ethernet/amd/declance.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c > index 6592a2d..7282ce5 100644 > --- a/drivers/net/ethernet/amd/declance.c > +++ b/drivers/net/ethernet/amd/declance.c > @@ -608,7 +608,7 @@ static int lance_rx(struct net_device *dev) > len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4; > skb = netdev_alloc_skb(dev, len + 2); > > - if (skb == 0) { > + if (!skb) { > dev->stats.rx_dropped++; > *rds_ptr(rd, mblength, lp->type) = 0; > *rds_ptr(rd, rmd1, lp->type) = MBR, Sergei