From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6280927587E; Wed, 25 Jun 2025 08:30:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750840249; cv=none; b=bhMZUgBL7k4ECtZduQNIzeRVhiWUBBJgBdVbg4HgKlVcxp0rGvzxanZLJf0sQvTs30qs3rpVMIQWaRYszhzDwY8lhJFTKqgUdr0QOMSu63qBCsLS/zhMx9Q5d+hXPiBGN0lJwDPZGx+aNXnW8FMQG2/s4Euw4La67ndbj/Yh/BQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750840249; c=relaxed/simple; bh=GoLMTJ5NvhpYjJ7hIqjrAw3zcslSPMdRspKOkp5l6d8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gt4VVXAqYQsgn9KKCDBDULO0WaZyrUucN56AHdXahbkquyJDmh1vmWzNXvGadQXGX0JR1PB2IoLUPoGfVRbDASVGXkWO/Y9EZCX0tNfl0ripkdX9aMuBybKojrH21duE9qBRGsbPywTYjCmAg1Zy2wfaULtTEb8xYWLjkwLh5BU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=G+acDOmu; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="G+acDOmu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1750840245; bh=GoLMTJ5NvhpYjJ7hIqjrAw3zcslSPMdRspKOkp5l6d8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=G+acDOmu1pxZ24nxZJNj+sUs6llxBi8KdD/86tnqBI8for3Sjrio00+50/56aEAbH EL5Z6lROPfzgq8sayOgsaJJcjE1PIbi7M7kjxfatHPdhdStTXIit/aWlub/jQXI5/e /mWxbU90o2DkznZ2OcNdmC8gB8s2w4L1m8mb5gP1QZUFTQcFfKsx0/n8tqnp94Mg2u 8130KW+GT8DrTHkmHm9v+QipXb9aqLAUFrkadDcQB0OkMpSsf3LN6S64n+xzLuphnc ydkIJ69GyiYUkn/AvhSB8caNAurghLHDI99hWaKhogjHE7oSse4jpLnGo9kqGg/9yE ZooY3qML1Y2rw== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id E609917E017D; Wed, 25 Jun 2025 10:30:44 +0200 (CEST) Message-ID: <40f07604-f4eb-4a7d-88b4-ed29e9242d6e@collabora.com> Date: Wed, 25 Jun 2025 10:30:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] dt-bindings: mfd: Add binding for MediaTek MT6363 series SPMI PMIC To: Rob Herring Cc: lee@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com References: <20250623120038.108891-1-angelogioacchino.delregno@collabora.com> <20250623120038.108891-2-angelogioacchino.delregno@collabora.com> <20250625005130.GA2106374-robh@kernel.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20250625005130.GA2106374-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 25/06/25 02:51, Rob Herring ha scritto: > On Mon, Jun 23, 2025 at 02:00:37PM +0200, AngeloGioacchino Del Regno wrote: >> Add a binding for the MediaTek MT6363/6373 (and similar) multi >> function PMICs connected over SPMI. >> >> These PMICs are found on board designs using newer MediaTek SoCs, >> such as the Dimensity 9400 Smartphone chip, or the Chromebook >> MT8196 chip. >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >> .../bindings/mfd/mediatek,mt6363.yaml | 98 +++++++++++++++++++ >> 1 file changed, 98 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt6363.yaml >> >> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6363.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6363.yaml >> new file mode 100644 >> index 000000000000..2ce57e659d12 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6363.yaml >> @@ -0,0 +1,98 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/mfd/mediatek,mt6363.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: MediaTek MT6363 series SPMI PMICs multi-function device >> + >> +maintainers: >> + - AngeloGioacchino Del Regno >> + >> +description: | >> + Some MediaTek Power Management ICs (PMICs) found in board designs with >> + the Helio, Dimensity and/or Kompanio series of SoCs are interfaced to >> + the chip via the System Power Management Interface (SPMI) bus. >> + >> + These PMICs are multi-function devices with various sub modules. >> + For example, those may include one, or more of the following: >> + - Auxiliary ADC Controller >> + - Clock Controller >> + - eFuses >> + - GPIO Controller >> + - Interrupt Controller >> + - Keys >> + - LEDs Controller >> + - Regulators >> + - RTC >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - mediatek,mt6363 >> + - mediatek,mt6373 >> + >> + reg: >> + maxItems: 1 >> + >> + '#address-cells': >> + const: 0 >> + >> + '#size-cells': >> + const: 0 >> + >> + interrupts: >> + maxItems: 1 >> + >> + interrupt-controller: true >> + >> + "#interrupt-cells": >> + const: 3 >> + >> + adc: >> + type: object >> + $ref: /schemas/iio/adc/mediatek,mt6359-auxadc.yaml# >> + unevaluatedProperties: false >> + >> + regulators: >> + type: object >> + oneOf: >> + - $ref: /schemas/regulator/mediatek,mt6363-regulator.yaml# >> + - $ref: /schemas/regulator/mediatek,mt6373-regulator.yaml# > > This causes the schemas to be applied 4 times (2 each). Better if you > do: > > properties: > compatible: > contains: > enum: [ the compatibles in those schemas ] > > Noted, thanks! >> + additionalProperties: true >> + >> + keys: >> + type: object >> + $ref: /schemas/input/mediatek,pmic-keys.yaml >> + unevaluatedProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - '#address-cells' >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + spmi { >> + #address-cells = <2>; >> + #size-cells = <0>; >> + >> + pmic@4 { >> + compatible = "mediatek,mt6363"; >> + reg = <0x4 SPMI_USID>; >> + interrupts = <4 64 IRQ_TYPE_LEVEL_HIGH>; >> + interrupt-controller; >> + #address-cells = <0>; >> + #interrupt-cells = <3>; >> + >> + regulators { >> + compatible = "mediatek,mt6363-regulator"; >> + }; > > Make the example complete. with adc and keys nodes. > You mean just adding a adc { compatible = xyz; }; keys { compatible = xyz; }; right? I will add the full example in the next version :-) Thank you! Angelo >> + }; >> + }; >> -- >> 2.49.0 >>