From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 420A03932C9 for ; Wed, 29 Jul 2026 05:13:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785302006; cv=none; b=cM+N1A61hOEFgnwPDJuwJcNmEfA8+sY0uvdKD9smbKhmbvqaqRufg5XZRy8qck76UXVKv8rT3bd2IZD0W08sl0/d84wjTVQLzEnL0lQlZdesB16LhT0kEPzyKoDifnsDun0eMzERJmD1/tk+eye2qyT9w+fq5CgGNoikSCEC7c8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785302006; c=relaxed/simple; bh=BBNFf30a6zOOwX6DRI6zswW8zA+Xhv0sn6eln5S4dUU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i44yTIywv4Ig24ooPxcw4L2ZCcYecDKvFIgzWEdUyuOkGGENEddhMcNO6GTIkwJyRlWFBdc80WNbH7+VsOJpDJYyNCY2wBLK7uOLKjU0QEVvBNyK8iOpN8C3wgQTAc6vkMMvDzAOvUsKUV0k5lKrD7i+KC4nEYFX/bJlNSGgatE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aQR6Kloe; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dlSRMTdZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aQR6Kloe"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dlSRMTdZ" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66T4cj5K978425 for ; Wed, 29 Jul 2026 05:13:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sVe2ifwgqiouK046xgZmh2KLG6lQsh0oVWKD2qpchlQ=; b=aQR6KloeMgPuMcG0 Bg+NJsQMtwMXCM0WFDx4j7OCtbQM5qJDeAaYAIR+aP9entl529Dd2cBRNXzctxxk /XvRq/sR1s/VjaTA4U5flFVn0HrY6idKPd1jybdq4fxCwitMlBvdHEUvOSxDYptn lwk5DUq1GRcD7DB69SGf2KMa8I+O6mqhjQeh8gEaY0fm4qg7J5O0vNKVFI/jXyoT l8hBS/iN5/ReM4Ge7KgRVToC2/UFfvjDHfsGyftR1/X3AmNMqBenLqIscwNeNeyE QnmJ+Cxz4guf172hYyzFMx6vfiNzKT5mMkXRmDmJoGksvXjtas9IfSvu9G+rZdoe M8jw3Q== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fq0q0a8x8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 05:13:22 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84865f326efso667845b3a.0 for ; Tue, 28 Jul 2026 22:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785302001; x=1785906801; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sVe2ifwgqiouK046xgZmh2KLG6lQsh0oVWKD2qpchlQ=; b=dlSRMTdZvf/qUj1ClcGJg4l5RXCgt8HyQNQjlaFXBjq783HRtA2xSMI0PIc2/P2emC CxNC1kA1rWi3yfQmUXKjdd8RLipqRUO578A/S0y8AfIaCrGxMZAZWtH70y2NaMW+UUqx 7/0T2d4xfRWAOe/MAVvMz+aKrOLr+yI7E7bVKSpH6pLaMrD8sbCGVjxcE5YIci4qmYM4 8cNiZfgSX+KtTPXIwnHwT38O8z4klwfHWcO9wHlSP39gnuEZ5/AyHAyhsuCAHTDcMC1t 6I9podUw3QiT66iKIEwfX591aioBIShjziEmcryBrDBpZr2H2dDPFbY6Y91kCtkce2os HWAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785302001; x=1785906801; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sVe2ifwgqiouK046xgZmh2KLG6lQsh0oVWKD2qpchlQ=; b=ryP3Du5nvjPccL9X0jSK1Hgff1O6OwBmNBmpiPiMB1znAxVj06YVvTQ9b/qYZhzZ0u djZBUSN1pnLYiXOgd3AB6jxLakyAs+iSckTkcdTl1ExYXhcfImc0n+OdtPK93m6vB5Q6 L3Jvwq3i4Ojyx1bMUxCbfXdwmwEdoypqkGEXp+NcT/5pIam5AfAVtcpbxEhX+/s/KyY4 Grp+FAvjZ9GKpx1cOfGd6Hy4nKVVwASY9XfF9il9dXNRJQ2iWzN+LKN7O6PJGRZAWNOc VkEKNJDOrE5DxGFs/pJj+fvfw11Cg7RR7Y4/JT0lTDhBXucmjwQPKeGsKFmHbg+U6J3x zuig== X-Forwarded-Encrypted: i=1; AHgh+RrOorGIh+XlzmhJnkAz+LyrkaSL+1IxTfRLc9LUZwX6m/ukYK21O7yRRGQkke9W5Jw9JrYAaglFqlih/EQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2lueppKVLEtjx39kSbZF9qxgRRVKNRQfbJDJ1s+enLiH6NRKu dKFDsxTmZFh+klVy9mW6bIpP3cuBpTQwXqBsQWSazUCfOrNYlJubHkQKR9rIbi9O0bFINaRWKq+ H7D1R/YKbYCfp+SkfijLE7FcGFK/FF160KB6XRIU11SN2dMJr95WbxW9ezyfOBj5p8nI= X-Gm-Gg: AR+sD10+3omJDJVMHkCTnkcLJ8ohFHhKUIIP7DYZOnSEeK10h8j5pi2/swKkqMji97Z yKDD68KPQniFjrchqiycnMlxLbpqiQowgaTb1RvQByOPyFJzwNfTrtbgiUJ0yyGfreqo5q6XuIU 5qWFZPgIgMkfWVUTD+Bus+yna5T8eB2ijxZVnpeV7R6y+SdyVR+P2dvxxRW6gDC8litqcxuJ1oV a1uEvo1BSSeb1Z3dU2jjpCH4U35V655SWJJI8uC7Erh9WokS8lvwAEInNh12kHQUDOfVYnLqYy2 GjR8LmgXyjtmLKHkRmtbdVo9APuO/nxpPIpysQGQAQ5vwIlm/sIsLCInyEPaI0ELKAPjUvHkmSQ GTFkwU2vjbaVgxjjL7pYHG2ImgxXJc2VLSeBxBaRX/eHPCjTsfPcQaNSoMCJb0JyGm9h6 X-Received: by 2002:a05:6a00:ad1:b0:847:8449:2bb6 with SMTP id d2e1a72fcca58-84e931ecd79mr5215887b3a.4.1785302001050; Tue, 28 Jul 2026 22:13:21 -0700 (PDT) X-Received: by 2002:a05:6a00:ad1:b0:847:8449:2bb6 with SMTP id d2e1a72fcca58-84e931ecd79mr5215863b3a.4.1785302000625; Tue, 28 Jul 2026 22:13:20 -0700 (PDT) Received: from [10.217.219.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84ea037446csm751099b3a.50.2026.07.28.22.13.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jul 2026 22:13:20 -0700 (PDT) Message-ID: <40f21498-a982-4dd8-a7a4-36da8e647a77@oss.qualcomm.com> Date: Wed, 29 Jul 2026 10:43:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/4] arm64: dts: qcom: Enable USB controllers on Shikra CQS platform To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov References: <20260723-usb-shikra-dt-v4-v5-0-5b69d9eb0888@oss.qualcomm.com> <20260723-usb-shikra-dt-v4-v5-2-5b69d9eb0888@oss.qualcomm.com> <1dbdd44d-070b-4abc-a79f-3cde09de7d74@oss.qualcomm.com> Content-Language: en-US From: Krishna Kurapati In-Reply-To: <1dbdd44d-070b-4abc-a79f-3cde09de7d74@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=ZOPnX37b c=1 sm=1 tr=0 ts=6a698bf2 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=VKVeDSocINzl8ZdAJoIA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: mubXU5ksq62z04fFR0FOfuVrfyXP2Lzq X-Proofpoint-ORIG-GUID: mubXU5ksq62z04fFR0FOfuVrfyXP2Lzq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDAzOSBTYWx0ZWRfXzjnX9uqsVgoM HpxUpn5OCgHrGWKssmoewj05yF2T5h822HMvY4Y28ZHlJUpIQD1zkwJ6wNkisTPdDW77KprX+NK lb8rQ5+F+d8LIUefvW7eUTFKZAuGM3UyUvH+7mcpTz4vk8hLYbvar83RMdtG2/N9p4fcaigoGow d6Zrfp6C32aHx7hTLr6RcFgBvPY68bCmOqInSXh8/qGN/UcRtb193CXFqfZRfG0ZD2dEK/D4s58 NAOWHHHDq7cN2xPhax18+EtZUUNJtZ2ki3BSJowrDwM64HwQ/tei93GjAEQRajIAtLhWzkGp3Lk w1Ecpa+cadClG4F4EHwILAuz4YIozd7gjzcGtK0SbAt0JhelCunQIP91IzmATw7ir2sTQr30/T9 YK5W0iWRbN5V2+OTCFe80JUn2WyrXaHmF+5U06X3YEZTx8ti99mFVj+Kxn7BOD3EJ7WYVStzYLf 9E4SO7sVyemkDtKtzJA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDAzOSBTYWx0ZWRfX1ZRaPrzgDceP eZ55TDZ9T1/QkCQqfwcsrw/DG/BpX3iD7D0OIBbo4HfxBEijvMwOWRl5rAoshJ7g+nbuPi2m8xZ /hMUAYlN4wOxzA3jPoNPJDHrj5mSmYI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_02,2026-07-28_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 clxscore=1015 suspectscore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290039 On 7/27/2026 8:09 PM, Konrad Dybcio wrote: > On 7/23/26 12:33 PM, Krishna Kurapati wrote: >> On Shikra CQS platform, usb-role-switch is handled by PM4125 on primary >> Type-C port and Cypress PD controller CYPD6129 on second Type-C port. >> >> Since those changes are not yet present, enabling both USB controllers >> in device mode. >> >> Signed-off-by: Krishna Kurapati >> --- >> arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 35 +++++++++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts >> index b3f19a64d7ae..006e24a62f5c 100644 >> --- a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts >> +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts >> @@ -38,3 +38,38 @@ &sdhc_1 { >> >> status = "okay"; >> }; >> + >> +&usb_1 { >> + dr_mode = "peripheral"; >> + >> + status = "okay"; >> +}; > > $ rg shikra-evk.dtsi arch > arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts > 9:#include "shikra-evk.dtsi" > > arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts > 9:#include "shikra-evk.dtsi" > > arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts > 9:#include "shikra-evk.dtsi" > > I think I asked either in private or in public, don't remember at this > point, just enable these controller once. They are all the same board > with the chip and PMICs swapped. Override just the supplies in the final > DTS files. > Hi Konrad, Shall I enable all platforms in one patch or in separate patches. Reason why I am asking is if I enable controller and phys on cqs platform in patch -2, then cqm and iqs will have controller enabled, but not phys causing inconsistency in those platforms if only the patch-2 would be applied. Regards, Krishna,