mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nick Kossifidis" <mickflemm@gmail.com>
To: "Jiri Slaby" <jirislaby@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Luis R. Rodriguez" <mcgrof@gmail.com>
Subject: Re: [PATCH 2/5] Ath5k: kill tasklets on shutdown
Date: Wed, 16 Jul 2008 19:12:21 +0300	[thread overview]
Message-ID: <40f31dec0807160912t54316c26nedfff2d756f16b5a@mail.gmail.com> (raw)
In-Reply-To: <1216136661-10930-2-git-send-email-jirislaby@gmail.com>

2008/7/15 Jiri Slaby <jirislaby@gmail.com>:
> Don't forget to kill tasklets on stop to not panic if they
> fire after freeing some structures.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> Cc: Nick Kossifidis <mickflemm@gmail.com>
> Cc: Luis R. Rodriguez <mcgrof@gmail.com>
> ---
>  drivers/net/wireless/ath5k/base.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
> index e9ec284..4d9ff97 100644
> --- a/drivers/net/wireless/ath5k/base.c
> +++ b/drivers/net/wireless/ath5k/base.c
> @@ -2343,6 +2343,9 @@ ath5k_stop_hw(struct ath5k_softc *sc)
>        mutex_unlock(&sc->lock);
>
>        del_timer_sync(&sc->calib_tim);
> +       tasklet_kill(&sc->rxtq);
> +       tasklet_kill(&sc->txtq);
> +       tasklet_kill(&sc->restq);
>
>        return ret;
>  }
> --
> 1.5.6.2
>
>

Acked-by: Nick Kossifidis <mickflemm@gmail.com>

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick

  reply	other threads:[~2008-07-16 16:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-15 15:44 [PATCH 1/5] Ath5k: fix memory corruption Jiri Slaby
2008-07-15 15:44 ` [PATCH 2/5] Ath5k: kill tasklets on shutdown Jiri Slaby
2008-07-16 16:12   ` Nick Kossifidis [this message]
2008-07-15 15:44 ` [PATCH 3/5] Ath5k: flush work Jiri Slaby
2008-07-16 16:13   ` Nick Kossifidis
2008-07-15 15:44 ` [PATCH 5/5] Ath5k: suspend/resume fixes Jiri Slaby
2008-07-16 16:15   ` Nick Kossifidis
2008-07-16 16:31     ` Jesse Barnes
2008-07-16 17:35       ` Pavel Roskin
2008-07-16 18:41         ` Jesse Barnes
2008-07-16 19:27           ` Nick Kossifidis
2008-07-16 19:41             ` Jesse Barnes
2008-07-15 15:44 ` [PATCH 4/5] Ath5k: fix dma operation Jiri Slaby
2008-07-16 16:13   ` Nick Kossifidis
2008-07-16 16:12 ` [PATCH 1/5] Ath5k: fix memory corruption Nick Kossifidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40f31dec0807160912t54316c26nedfff2d756f16b5a@mail.gmail.com \
    --to=mickflemm@gmail.com \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®