From: "Benoit Boissinot" <bboissin@gmail.com>
To: "Soumyadip Das Mahapatra" <kernelhacker@visualserver.org>
Cc: "Akinobu Mita" <akinobu.mita@gmail.com>,
"Harvey Harrison" <harvey.harrison@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] bitreversal program
Date: Tue, 20 May 2008 17:47:44 +0200 [thread overview]
Message-ID: <40f323d00805200847t77b2d875j451d0eb9758cf9ff@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0805201716160.25111@visualserver.org>
On Tue, May 20, 2008 at 5:25 PM, Soumyadip Das Mahapatra
<kernelhacker@visualserver.org> wrote:
> Thanks for giving a reply Akinobu :-)
> I forgot that bitrev8() is static in header file. Sorry for that.
>
> Below is my new patch considering this. Cant it be applicable?
> Please review it.
>
> I know that my bitrev8() takes more instructions than that
> of yours. But we have to think about faster access of cpu cache over that
> of memory cache(which your bit_rev_table uses).
I didn't review your patch, sorry.
But I'm pretty sure that your patch won't be considered unless you
provide benchmarks
with numbers for different CPU/architecture.
Ideally you should provide a script to test the correctness and the
performance of your
change that anyone could run on his computer.
regards,
Benoit
next prev parent reply other threads:[~2008-05-20 15:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 17:04 Soumyadip Das Mahapatra
2008-05-19 20:42 ` Harvey Harrison
2008-05-20 6:53 ` John Hubbard
2008-05-20 11:01 ` Soumyadip Das Mahapatra
2008-05-20 12:13 ` Akinobu Mita
2008-05-20 15:25 ` Soumyadip Das Mahapatra
2008-05-20 15:47 ` Benoit Boissinot [this message]
2008-05-20 15:57 ` Soumyadip Das Mahapatra
2008-05-20 16:39 ` Benoit Boissinot
2008-05-21 8:54 ` Soumyadip Das Mahapatra
2008-05-21 9:11 ` Benoit Boissinot
2008-05-21 11:11 ` Rene Herman
2008-05-21 16:52 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40f323d00805200847t77b2d875j451d0eb9758cf9ff@mail.gmail.com \
--to=bboissin@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=harvey.harrison@gmail.com \
--cc=kernelhacker@visualserver.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®