From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEA833672AE for ; Thu, 21 May 2026 04:06:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779336406; cv=none; b=j+5k+HEAeaC2T3lYCT1oTrCAjQgZoMhY/yuWPvITHbWRo6NwvKu3CKcr/MirWiGcO1+Jm5dFbuMzz/IcW8zgfL3S2V4tVwgwUtbQoruX8sjUczEjGb9La/LbiWI3+YCnAJovOnMsgHMh5DmXegJSLiy2YQneHH33NCHtJuIz/OU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779336406; c=relaxed/simple; bh=Gh8ajVND+41v1/vo95zmAawm27Gq9MJj3ORvRqW1j4o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uz9llKlf3SILnIk4LG8GnCt1XWBkafZ8K2CfHA4BRVmZ/puVaB5Ch2GLczW0h0gDqQXMqI1iqHE05En4xa3OKL3W7n56GjW8DtpHOu1DyDa0V+3EMSjMn+IugKG3KwPieN3whCf7+HW0fM30Tc0Q0NkWI5ErRaXAoj1+aNE0hmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nsFG77XR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Yb6kEje+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nsFG77XR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Yb6kEje+" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64KKlaVM2157882 for ; Thu, 21 May 2026 04:06:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mXPHU0FSRkb8TWkVq85RVfc/tLbj+oz0zmwBY3S5Ci0=; b=nsFG77XRomQZ5EVO 3eaminfuvOUUAo1/jTAdjwaY9cyGse1+haGYj5D1vncUdyyniiYUiTZqfPORktG4 u7PMwA2MrBsDQxyoTGO8jkWI2nBLBN3pAYg8cP7ejmW7uFDT8mMiOXGDBo4FHa8Y DWsI3yxG96s6IMO24my4r1IC+eU3cLS5VGYEABWGLjZyLtpjIRPYWWD334G80bI6 oOpABhIxCU/7b4otY41p8DGmhJK8+s6U85jaIfmTle8UZ9U1Ap4MsJHqmIcIbxKg dOMAvZrsWFv1bY27EmSC1+r9MPR7y2bMI0cLT6R3oAZCotXfsZTdKZEnsy+Q99mU YkbzFA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9ma418u5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 04:06:44 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2bc977e6aedso52477765ad.2 for ; Wed, 20 May 2026 21:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779336403; x=1779941203; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mXPHU0FSRkb8TWkVq85RVfc/tLbj+oz0zmwBY3S5Ci0=; b=Yb6kEje+E1CcpAFmIY5ZdZoF9PqckdSDg9B7Zth4sarSXqRpdNcwZCOyiY5e8UNYig QL8mwqVDWYQ5JzbpWHkDCtNOL6KQ4PzzQ7twFiGosMZUS+29kL7LYTrEhAKPcwxOsskE z3wLjnCwQ3RwDahibxSehQxua7fNcN7klupjUVk2NL/zIDH4zhTLq5SWS2LgljV2tyZ4 Xkv9qQEVWugmCEJYmBmml2wBL18H6iaRg0+72O273OH2/qs4Ka+uNOo4rTxzAh4bb1J4 KWL/coF1PV7i/1NYgbGm21S7aoeL+/N+gIr1OwzXEl5a6vwJ6Zdx7NWVEda0L+t22ICB hd2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779336403; x=1779941203; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mXPHU0FSRkb8TWkVq85RVfc/tLbj+oz0zmwBY3S5Ci0=; b=UPDQERMotsh3h7VF1u/z8WdF0ie3QY7XUkhZmTzdb2GUwy46QObN7f3TuqX9y6yJeo s9FWjHR6iVxzN4WF+/o1FUTR28TBF5isncsGwBW0FpVx2VvqjNeqy6fXVTcyxKaxi46p Mm2j4XyxUjhgW4G2lWFL6LOzlRIE4RfPn3Sg2ZcQNTudFkE4JptxhhOKj5jTVxueBarB uhUZEOY+NNqi1TlsJngl2vgJH4xphZAKZQXeNKOAVf5WnLYzu2Q5ypK2xuU+9Oy984ve ZA9+/GqkATDHIG5YCZA3l6irIm76l8NylQLPz+3lqnZgMJv05TSHkUZ0XrbqZ3PL47Kv WQeQ== X-Forwarded-Encrypted: i=1; AFNElJ9wNECyL669kNsSXOLPMvvCrior2omGnyHmZLcrLG/LGFOzhh+FFgP/eGbDySKWPg22Sq4YvrSGXhCAzFQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzjY9sYBCkF9lIq6w5LxF4BNG2YponGEv4jhnE7mlUl/5lZzvq3 XmRM2ooCofNDiQa2Y1I3N4v0qe3wTJ5LTS0SxcrAUJt6VQAmx6ikPyymuFSYg4/N69X1oEun3fA rcLmva8queDs0Uje+7JmrC9v8AslErL1DAwxu5qL1sq5Bfj2e+lZV1tpqT7kmcLXr55U= X-Gm-Gg: Acq92OFUZoUe1LAilAJucm0cAEGLAo4jA/eKx35m+i43YsGkcleqZeEYa6+oTqMnuam lmBJar48j5mEKVHEDaniqVKb5qWle8YW3d7U4J8QWM6RkztWBphzWJIJ1MGUXOxAyl3U7gEXhDq 4oAaFyCrDYEiYWtTlc1Jn8Bcf2DqsE8uJlp0vpk9xYvMgjvFKpgWsGIEEsI6mHzbaqzjkLbMcr1 o6FjrgPksQnPfJd+5lGwnhs8NkPtiz+Cv6dbHpNMPpzIr3jmq05BqoHkPqIXUx826OdFM0gxI0n gYffgFkMswiHT6ogqdpB2xdEuKBw9+32Y+UIhoRYmXn5TSweTKWU0WyCSRJHQ48K0CGYcqCB9dN OZDUTpst8CTHhiSOk25CWVHqNemdzeTb5NLQcTFzsN9nsnEbjSDA= X-Received: by 2002:a17:903:a90:b0:2bd:ef15:9fce with SMTP id d9443c01a7336-2bea3345f6bmr11166945ad.20.1779336403381; Wed, 20 May 2026 21:06:43 -0700 (PDT) X-Received: by 2002:a17:903:a90:b0:2bd:ef15:9fce with SMTP id d9443c01a7336-2bea3345f6bmr11166445ad.20.1779336402878; Wed, 20 May 2026 21:06:42 -0700 (PDT) Received: from [10.206.108.31] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d125159sm224568425ad.76.2026.05.20.21.06.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 21:06:42 -0700 (PDT) Message-ID: <40f5320d-4b58-4e99-b7b1-d52d09c04127@oss.qualcomm.com> Date: Thu, 21 May 2026 09:36:38 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 4/4] misc: fastrpc: Add polling mode support for fastRPC driver To: Dmitry Baryshkov Cc: srini@kernel.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de References: <20260520065047.3415790-1-ekansh.gupta@oss.qualcomm.com> <20260520065047.3415790-5-ekansh.gupta@oss.qualcomm.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=K9kS2SWI c=1 sm=1 tr=0 ts=6a0e84d4 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=G4waM6_Fef8mLlXZwtoA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: kQyxN12I8LXLxKWziuGXnZQo0u4nqCLw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDAzNiBTYWx0ZWRfX6IC2WOC6xH3M mxGtHCsMnzMeBOWfHcYB/awPdiyKnD+DHA3esQd/Pm/dV4TRZ5z5Q8sUGj/eHrWgAqu/2PvZw+B nxJ+zKvobIHojdVmhjiMuT/UJIBbW6vhMJg2MUHktKImIEf9MBmgcQw+CYdNGhiRn4RAhnsbmNR 20oqxYJAswy7MMi6q10MmBeF4ppBXb2IdTrPbwXLk6xW8cv3Wmp4V9e2S1u5ndBc+1guelB56Zt GT984A5mouVq42fSgXibplf2ETh0mHlNEvtMs1H8hK2YV/SdedLvpecWhAG+OdeamXa6znZKD32 cCdzzb81bExNPL1zELi5BiGeQMllLOnDkCc97pBCqCnG6pIs3BoDgoNdqox/nBsMk9Qwc8ZuSf4 tl1qZE66kq2HAu8HTXbIroyFswZ9lhLTpc2jq8B4097K1Eqcua+fu5Z8/MAbYH5hfdXuWck5Za3 lnOA8umpvAXK4FYTIeg== X-Proofpoint-ORIG-GUID: kQyxN12I8LXLxKWziuGXnZQo0u4nqCLw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210036 On 20-05-2026 19:06, Dmitry Baryshkov wrote: > On Wed, May 20, 2026 at 12:20:47PM +0530, Ekansh Gupta wrote: >> For any remote call to DSP, after sending an invocation message, >> fastRPC driver waits for glink response and during this time the >> CPU can go into low power modes. This adds latency to overall fastrpc >> call as CPU wakeup and scheduling latencies are included. Add polling >> mode support with which fastRPC driver will poll continuously on a >> memory after sending a message to remote subsystem which will eliminate >> CPU wakeup and scheduling latencies and reduce fastRPC overhead. In case >> poll timeout happens, the call will fallback to normal RPC mode. Poll >> mode can be enabled by user by using FASTRPC_IOCTL_SET_OPTION ioctl >> request with FASTRPC_POLL_MODE request id. >> >> Signed-off-by: Ekansh Gupta >> --- >> drivers/misc/fastrpc.c | 167 ++++++++++++++++++++++++++++++++++-- >> include/uapi/misc/fastrpc.h | 29 +++++++ >> 2 files changed, 189 insertions(+), 7 deletions(-) >> >> @@ -1813,6 +1907,35 @@ static int fastrpc_get_info_from_kernel(struct fastrpc_ioctl_capability *cap, >> return 0; >> } >> >> +static int fastrpc_set_option(struct fastrpc_user *fl, char __user *argp) >> +{ >> + struct fastrpc_ioctl_set_option opt = {0}; >> + int i; >> + >> + if (!fl->cctx->poll_mode_supported) >> + return -EOPNOTSUPP; > > This is being handled too early. What if the user passes any other > option? okay, right. I was handling this with only poll mode as an option, I'll move this after request_id check.> >> + >> + if (copy_from_user(&opt, argp, sizeof(opt))) >> + return -EFAULT; >> + >> + for (i = 0; i < ARRAY_SIZE(opt.reserved); i++) { >> + if (opt.reserved[i] != 0) >> + return -EINVAL; >> + } >> + >> + if (opt.request_id != FASTRPC_POLL_MODE) >> + return -EINVAL; >> + >> + if (opt.value == FASTRPC_POLL_MODE_ENABLE) >> + fl->poll_mode = true; >> + else if (opt.value == FASTRPC_POLL_MODE_DISABLE) >> + fl->poll_mode = false; >> + else >> + return -EINVAL; >> + >> + return 0; >> +} >> + >