From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B61BC77B61 for ; Thu, 13 Apr 2023 10:12:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230377AbjDMKMs (ORCPT ); Thu, 13 Apr 2023 06:12:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230286AbjDMKMV (ORCPT ); Thu, 13 Apr 2023 06:12:21 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CB649EC4 for ; Thu, 13 Apr 2023 03:11:47 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id he11-20020a05600c540b00b003ef6d684102so6014999wmb.3 for ; Thu, 13 Apr 2023 03:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1681380705; x=1683972705; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Rh1gldBq6zKF54NhdToFqztzBsv3VTQhW4I1lS7ak3s=; b=cd/3lqYYREcX6JZjYJCzZcFEiAlsmLK9yPaLNG2ggAfQWA03NDHYlNe6RFe5ctjv9j qkE5Cf1F+oJYzQo3r73M21KKBaPIzK3KyQFLDTKYYiBkxV5Q356zFVhXMe5hyo1ilEoX qyGs1bAiedY+adpUXbxa1aaOjAzy4huTTBHKeWvcHoFd2EWjO4UiZMMDFIfFLr5scngV d38urRIbk2oz8ofRbz43x2+gQIRnGxFCRxeiPsgvEjT/ikUExlhCMUQ+YQW52jtDV8TR owvkvvgib9FfCWgDC/jd3QaVLUOmQKeQd7MXLeZQdehb2kkpHs4EYCf22Z4waE/Y2o4J FEzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681380705; x=1683972705; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rh1gldBq6zKF54NhdToFqztzBsv3VTQhW4I1lS7ak3s=; b=C1yb6JjjAXTmlzZg2Xqc9uL8vAmllsfdQSiOq96Sh4blX58SDml5aL3CuNEuEt4ol0 3XkjPZ2VoUn4QxPppXKpMe1DES3sFydexQ0bmLUkML0MNhgxgYat+gT5SQO6bgdd2Bsa 00tL9cawfa2R3RHApR450vzY9GH69iJXx1J1D+B6UPPp1nQfqIjhEJbZeibJ0FZU2wUz RwlyXzZVTWPFUL3RFLVD2L2Ut7M+pMNepIYOy3+H0VRyJBM9AflVeNIfbs36NH8B4gef zEtzMoTvN35gTcffy0xovAcuHkxOHoHivyFfSfdhZg8TCq6lJkTrDa6jWtaig0LRdq8C hoOg== X-Gm-Message-State: AAQBX9e63SWoC+IMzyCUnV2Bsw/mtSnenN1knHrEwSIpsQbaw9GWCUxb BFy9/+gUuGTIhWct1nTbewMQIw== X-Google-Smtp-Source: AKy350ZFAT71PMZf5H+HAkQEk6xT99x0FuglrvXuwh0ry9ycBGd2Dz0LsyxMOMG0AoEOw6ril9Fmig== X-Received: by 2002:a7b:ce88:0:b0:3f0:7ddf:d8e4 with SMTP id q8-20020a7bce88000000b003f07ddfd8e4mr1279283wmj.17.1681380705280; Thu, 13 Apr 2023 03:11:45 -0700 (PDT) Received: from [10.1.3.59] (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id 8-20020a05600c228800b003edef091b17sm1381662wmf.37.2023.04.13.03.11.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Apr 2023 03:11:44 -0700 (PDT) Message-ID: <40f79e51-db8b-7105-5cc1-4465ca818416@baylibre.com> Date: Thu, 13 Apr 2023 12:11:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 3/7] leds: leds-mt6323: Specify registers and specs in platform data Content-Language: en-US To: AngeloGioacchino Del Regno , pavel@ucw.cz Cc: lee@kernel.org, sean.wang@mediatek.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20230412153310.241046-1-angelogioacchino.delregno@collabora.com> <20230412153310.241046-4-angelogioacchino.delregno@collabora.com> From: Alexandre Mergnat In-Reply-To: <20230412153310.241046-4-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/04/2023 17:33, AngeloGioacchino Del Regno wrote: > In order to enhance the flexibility of this driver and let it support > more than just one MediaTek LEDs IP for more than just one PMIC, > add platform data structure specifying the register offsets and > data that commonly varies between different IPs. > > This commit brings no functional changes. > > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/leds/leds-mt6323.c | 145 ++++++++++++++++++++++++++++--------- > 1 file changed, 112 insertions(+), 33 deletions(-) > > diff --git a/drivers/leds/leds-mt6323.c b/drivers/leds/leds-mt6323.c > index 17ee88043f52..a5b2d06e9d63 100644 > --- a/drivers/leds/leds-mt6323.c > +++ b/drivers/leds/leds-mt6323.c > @@ -37,18 +37,16 @@ > * Register for MT6323_ISINK_CON0 to setup the Comment should be changed. > * duty cycle of the blink. > */ > -#define MT6323_ISINK_CON0(i) (MT6323_ISINK0_CON0 + 0x8 * (i)) > +#define MT6323_ISINK_CON(r, i) (r + 0x8 * (i)) > #define MT6323_ISINK_DIM_DUTY_MASK (0x1f << 8) > #define MT6323_ISINK_DIM_DUTY(i) (((i) << 8) & \ > MT6323_ISINK_DIM_DUTY_MASK) > After that, it should be ok. Reviewed-by: Alexandre Mergnat Regards, Alexandre