From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934044AbdKQOcS (ORCPT ); Fri, 17 Nov 2017 09:32:18 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:42947 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933430AbdKQObx (ORCPT ); Fri, 17 Nov 2017 09:31:53 -0500 X-Google-Smtp-Source: AGs4zMb8cqvunSd8ecBthiZt1S+IPqgQ1YfjuCImEX+dGfhG/PHmnFJUPjxmyIC9Lk5/tXkFKurtSg== Subject: Re: [PATCH] watchdog: pcwd_usb: remove unneeded DRIVER_LICENSE #define To: Greg Kroah-Hartman , Wim Van Sebroeck Cc: linux-kernel@vger.kernel.org, Philippe Ombredanne , linux-watchdog@vger.kernel.org References: <20171117142203.GG17880@kroah.com> From: Guenter Roeck Message-ID: <40fb6822-6797-cca7-763a-6c76b2bc4b66@roeck-us.net> Date: Fri, 17 Nov 2017 06:31:50 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171117142203.GG17880@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/17/2017 06:22 AM, Greg Kroah-Hartman wrote: > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source > code license to work properly, as there is no need to unwind the > unneeded dereference, especially when it is defined just a few lines > above from where it is used. > > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Reported-by: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman Reviewed-by: Guenter Roeck > --- > drivers/watchdog/pcwd_usb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/watchdog/pcwd_usb.c b/drivers/watchdog/pcwd_usb.c > index b9e376c8e2e3..07a97708cb3a 100644 > --- a/drivers/watchdog/pcwd_usb.c > +++ b/drivers/watchdog/pcwd_usb.c > @@ -49,12 +49,11 @@ > #define DRIVER_VERSION "1.02" > #define DRIVER_AUTHOR "Wim Van Sebroeck " > #define DRIVER_DESC "Berkshire USB-PC Watchdog driver" > -#define DRIVER_LICENSE "GPL" > #define DRIVER_NAME "pcwd_usb" > > MODULE_AUTHOR(DRIVER_AUTHOR); > MODULE_DESCRIPTION(DRIVER_DESC); > -MODULE_LICENSE(DRIVER_LICENSE); > +MODULE_LICENSE("GPL"); > > #define WATCHDOG_HEARTBEAT 0 /* default heartbeat = > delay-time from dip-switches */ >