From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D296370AFB for ; Tue, 23 Jun 2026 09:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782207234; cv=none; b=FKJ6c2B+W5JbWyzJRNIpA9Crq1JQ3qj7HMA2sXut8tbRBCzAgCGnhjt41B1uCMAVB3Pzyox92V2sryVw9ebrjUlcpdnqsYipVWvABH7b42NAIwktjHLRLRb4MXW8Vmjmk/pxSonJkjdc4iVUGoAuF+CgAK75n9fYSfezf+Lkwjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782207234; c=relaxed/simple; bh=vh979CfbMMeEW8g0pA8K6/HiWHi0HKSWGmIzWUpa+vw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GCAeRcOWEEuFTFi7x82Z1KVxTck6erY5F1otCNo+T8ThqbUDuKQXUuxG9G95xxU9qgm+X+I40t4gpuIA8y08gVO7I+8fKFAjTUY7nhjHowyX4G+32AjzE8Innc+lm9CqyJ/WInNqRiWS7iVG3kq8NKZyfoJAyEf9KCQgsBr5Txs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U4eyK4qr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NCxI25Rm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U4eyK4qr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NCxI25Rm" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N6cWsQ3338322 for ; Tue, 23 Jun 2026 09:33:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vh979CfbMMeEW8g0pA8K6/HiWHi0HKSWGmIzWUpa+vw=; b=U4eyK4qrPLsqIMKW EOU3WCnOsqn1VgMNPpr/wmMdwTYqzhbfXeE3E65iW5xeU4ARcJ3zSNGPHFvjUtkJ hyKoht64AD/agvnNEOLC5R+IIPhhVW8J5tp0zEQZzT1R5OlkGekFUnzqQj70TmZ1 l6NZJ0tN1wBThM+d1rOrCHuR0SVXAviak8QwYRKfA/xGIebNkZmDJ8CTleOoiN8u lqVFQkqTWsUp42HDX/cohNgI6WPSDqoAepRKkBJxC1WatuYsTuvvQKHy8IHUNnPg 44oG1xWYa8Dj0KdeBDFTyZnx5izAVJKQgH1XwolhEWDj15/Ndt8kC8FaFsjBCMh8 HK1n5Q== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eygkjhke7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 09:33:51 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2c680ead9edso4474265ad.0 for ; Tue, 23 Jun 2026 02:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782207230; x=1782812030; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vh979CfbMMeEW8g0pA8K6/HiWHi0HKSWGmIzWUpa+vw=; b=NCxI25RmiWVkf55WkhFi27CxbJMxNqad/PJiWyTuCyUCrsVc271vmvZwuuAsxaKo3Q 443xHyeaXJdk8w9Kl6lzfYkGwok7OHReYkUk4SbG/fe5v27pV0A7ZI0n6appiTZG+gvj fwnDPcTBnJfCOOC336IkaKF41UM4huQagFMgyNxeXiOxVgG8OAWUnyA12KJ2Eyr6Sl1Y nur2ndouKJiJfLmNxcP9ujO5X39zmP5RNuquLOf8HJdy+M0mmbOh/R5+1Jfhtu51mLY3 0rOrUwQhgWj35EkXA1MRjS/6i6nNQwsLMEM5+8nxSy17szFPai3VRXqxPJvmX3bsSaxM lIow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782207230; x=1782812030; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vh979CfbMMeEW8g0pA8K6/HiWHi0HKSWGmIzWUpa+vw=; b=iUB1zCgy3Rn/bBHoj82Ge/4pVAQPUtm/x2QYwFXyBzMyhkGVwceGFCKcVd9D25Qaad KB0VDOdYikR2SJdgpW9Oeyy2c5j49ivucTN+nLCZsKGc0uJXAJo0oIxFE0iFafUX9h46 5MbIOt+H3UO5NXyeAkj/XKIX5ssgleB1CNdoYYHoGiRrFNxblM7R2d813YUd+Fy+qAbx A0DVNNziATUi5cd/g60LDVgOwuIFM+2xpy4yvYX5MPB1ZZDSEdwJWz6x7eRnst56f2FE TeryXoh9d6aW7bWnFjeYsv5G1JESOt9xXN65bx8cPltbJJicpF5wZ5LM+3qLIXrVDTy9 cGIA== X-Forwarded-Encrypted: i=1; AHgh+RpHEl/TAMCYxPM9LsYLGDNO4UM2sRO17TS2WCN3krUOdYWD8hWnXFv38nsLWUj6qgl6Ex0Xw/iTCqzPb1E=@vger.kernel.org X-Gm-Message-State: AOJu0Yzfj9BcGlEUazJcIt1EvxKZ02SCGOXYb+6CYK7vHatuYXkfCYmL QFutJM3RAzbWYOX/CcIiKl9s3BnmY06YBzQ/DuCcLr/iVQR3FrBdWDuFgMCcb99s24bsgsKYAer xECiwRLuqk3KeAI1JYULjQSdHIySVsJHG1LHHc445FqucGl2VUCbNejtbjoCoAM39nu0= X-Gm-Gg: AfdE7ckjAflNwjHcjtdV3QaDqPQ2kV/ZV1M9DdUIm8LuNfT7STy3H6v01kzyImt5lU+ MUBcryG3Ng7SUznlxM8qbrLIctj7CUlJdCZ38K18VxyunWy5AZ/4qvGx3bSa3OouPr8IGbPH7B/ CG0XRVjW2vj4w7lNgILdQc/vZEU9qarUGhOfERhftVyVs/+Wu7b0MunP9AX+uJrDJYh7C3syzMB XtKSalDT/AB29PfvUz9purPfbv+OxSI2jNJ/Du/mB5DE8nyeNlyrc4D5O7nsfHFCqa3Y0C3huDs D5SWOlB8yJPq+3cOmVg53R9fAw+WLhOsAFzubBz7DSxHtFWJk/HS0Tm01xUXhnNo94YqEkoyrCg 58CgVQBsBhjAnYZkOh5zp/052+oCy6Vit08Bi3HU8N8prTuqINcboaKZRj3oXmCFTOF+HTkOeH1 1Iww== X-Received: by 2002:a17:90a:77c4:b0:37d:82c6:2e4f with SMTP id 98e67ed59e1d1-37d82c63153mr3536184a91.0.1782207230443; Tue, 23 Jun 2026 02:33:50 -0700 (PDT) X-Received: by 2002:a17:90a:77c4:b0:37d:82c6:2e4f with SMTP id 98e67ed59e1d1-37d82c63153mr3536166a91.0.1782207229975; Tue, 23 Jun 2026 02:33:49 -0700 (PDT) Received: from [10.133.33.161] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d4f008779sm9180164a91.6.2026.06.23.02.33.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 02:33:49 -0700 (PDT) Message-ID: <40fb6f83-939a-4b3f-8b93-77d7e07b72f6@oss.qualcomm.com> Date: Tue, 23 Jun 2026 17:33:44 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/13] Bluetooth: btusb: Initialize @priv_size at declaration in btusb_probe() To: Dmitry Baryshkov Cc: Marcel Holtmann , Luiz Augusto von Dentz , Rocky Liao , Bartosz Golaszewski , Ben Young Tae Kim , Balakrishna Godavarthi , Matthias Kaehlcke , Zijun Hu , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Luiz Augusto von Dentz , linux-arm-msm@vger.kernel.org References: <20260622-bt_bugfix-v1-0-11f936d84e72@oss.qualcomm.com> <20260622-bt_bugfix-v1-1-11f936d84e72@oss.qualcomm.com> Content-Language: en-US From: Zijun Hu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA3NyBTYWx0ZWRfX0TaexRZu3ohN hdGnNGv7AneXBSIwzcJAIGUvqpfwi+GRFoSqWqoyMRQ/L2enI/wicMpzZygKL+YTAQIx1NmowQS fTHLfTrOoo/QN77lOW1QemlCGegDgZo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA3NyBTYWx0ZWRfX3GTHMHSHm4xH glxHgWFJq+WF0frkzc0ygWbfv2sOYzz2f9Djt+bbbdlHDCQoJcMPketmr9k//SQitZfWcy6q2DC xat8z5Aw4o8aUTfItTjYyafYp/teBSBjUE/qG4ekr/xFg6Fs8/fE4lZiNTrupO+nqhjuqi0cI+q cMDyEgOpnQnjGHFqeHPiLfNG3G+Bp6CovD9xeIWhv0OhDTZ+uhmRvu62MZDAkS7k6qo9c1CKzgh 2wtZ1b4Z/nQx8S7FqQNDgcF0FcL+LM1/v+Afbh+7VcfTE/P63gmwZeEgj/cH69SaW1l4EOOdZay q3AcckJrO/sTfZa0cnlmxYAgiPFe0sMWp/F17iS22hK8Upzh7BT3NJNrCCp1syhtxot/6hX2dt8 0ClvXd3w7ZG7de7XTEUtCvOyRDmWNg== X-Proofpoint-GUID: 12Tg7YOLvoU9xMILUt_IfUTq1s_I3DTl X-Authority-Analysis: v=2.4 cv=SoKgLvO0 c=1 sm=1 tr=0 ts=6a3a52ff cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VaXnfVv-xPxUd7dZoh0A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: 12Tg7YOLvoU9xMILUt_IfUTq1s_I3DTl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230077 On 6/22/2026 11:30 PM, Dmitry Baryshkov wrote: > On Mon, Jun 22, 2026 at 07:52:14AM -0700, Zijun Hu wrote: >> Initialize @priv_size at declaration to reduce a redundant assignment. > This is obvious from the commit. Please tell us, why? It is simpler: one statement completes both declaration and assignment. More flexible: initializing at declaration makes the variable immediately usable from that point, so any new priv_size += can be freely inserted without caring about where the separate priv_size = 0 sits. Will improve the commit message in v2.