From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3C16C7EE24 for ; Wed, 26 Apr 2023 11:43:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240465AbjDZLnk (ORCPT ); Wed, 26 Apr 2023 07:43:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240571AbjDZLng (ORCPT ); Wed, 26 Apr 2023 07:43:36 -0400 Received: from frasgout12.his.huawei.com (frasgout12.his.huawei.com [14.137.139.154]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38CE74C04; Wed, 26 Apr 2023 04:43:34 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.18.147.229]) by frasgout12.his.huawei.com (SkyGuard) with ESMTP id 4Q5xYv0M32z9v7Yn; Wed, 26 Apr 2023 19:32:51 +0800 (CST) Received: from roberto-ThinkStation-P620 (unknown [10.204.63.22]) by APP2 (Coremail) with SMTP id GxC2BwAn7lQ6Dklko7NWAg--.7207S2; Wed, 26 Apr 2023 12:43:07 +0100 (CET) Message-ID: <40fbededd8dbe3b70fffb179574f344e9b0aed17.camel@huaweicloud.com> Subject: Re: [RFC][PATCH 3/6] verification: Introduce verify_umd_signature() and verify_umd_message_sig() From: Roberto Sassu To: Jarkko Sakkinen , dhowells@redhat.com, dwmw2@infradead.org, herbert@gondor.apana.org.au, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, mykolal@fb.com, shuah@kernel.org Cc: linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Roberto Sassu Date: Wed, 26 Apr 2023 13:42:45 +0200 In-Reply-To: References: <20230425173557.724688-1-roberto.sassu@huaweicloud.com> <20230425173557.724688-4-roberto.sassu@huaweicloud.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-CM-TRANSID: GxC2BwAn7lQ6Dklko7NWAg--.7207S2 X-Coremail-Antispam: 1UD129KBjvJXoW7GFyruF4rXw4xKFWxZF43KFg_yoW8Jryxpa n5tF4fKr1Dtr1jyayxKry3ZFW8tw4Yyr1DWw1DC3y5Za4rWFyY9r1Iga13uFZ8ur1FkFZI vanIqa45Z3WDA3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkjb4IE77IF4wAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxV AFwI0_Gr0_Gr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lFIxGxcIEc7CjxVA2Y2ka0xkIwI1l42xK82IYc2Ij 64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x 8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a6rW5MIIYrxkI7VAKI48JMIIF0xvE 2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42 xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07UAkuxUUUUU= X-CM-SenderInfo: purev21wro2thvvxqx5xdzvxpfor3voofrz/1tbiAQATBF1jj4yCiAAAsh X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2023-04-26 at 03:28 +0300, Jarkko Sakkinen wrote: > On Tue Apr 25, 2023 at 8:35 PM EEST, Roberto Sassu wrote: > > From: Roberto Sassu > > > > Introduce verify_umd_signature() and verify_umd_message_sig(), to verify > > UMD-parsed signatures from detached data. It aims to be used by kernel > > subsystems wishing to verify the authenticity of system data, with > > system-defined keyrings as trust anchor. > > UMD is not generic knowledge. It is a term coined up in this patch set > so please open code it to each patch. Yes, Linus also commented on this: https://lwn.net/ml/linux-kernel/CAHk-=wihqhksXHkcjuTrYmC-vajeRcNh3s6eeoJNxS7wp77dFQ@mail.gmail.com/ I will check if the full name is mentioned at least once. So far, it seems that using umd for function names should be ok. > One discussion points should be what these handlers should be called. > Right now the patch set is misleads the reader to think as this was > some kind of "official" term and set to stone. I proposed some naming here (dependency of this patch set): https://lore.kernel.org/bpf/20230317145240.363908-6-roberto.sassu@huaweicloud.com/ Please let me know if it sounds reasonable to you. Thanks Roberto