Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

[Michael Schmitz <schmitzmic@gmail.com>]

Hi Finn,


Am 16.01.2017 um 12:50 schrieb Finn Thain:
> This series removes some unused code and related comments,
> addresses the warnings generated by 'make W=1' and 'make C=1'
> and fixes a theoretical bug in the bus reset method in atari_scsi.
> 
> There's also a patch to add a missing error check during target
> selection. The only target I tested was a QUANTUM DAYTONA514S disk
> as that's all I have access to right now. Some testing with other
> targets would be prudent.
> 
> Michael, Ondrej, can I get you to review/test please?

No regressions during testing on my Falcon both using default settings,
i.e. can_queue=1 or internal queueing (can_queue=4, cmd_per_lun=2), and
the legacy IDE driver.

I've seen a bus reset executed when reloading the module (bus jammed for
some reason apparently), so that code path has been tested as well.

No change in the weird behaviour of my SCSI-SATA adapter, but perhaps
that wasn't unexpected.

Targets: Disks Seagate ST34520W and IBM DORS-32160W, CD-ROM Plextor PX-40TS.

Tested-by: Michael Schmitz <schmitzmic@gmail.com>

> 
> 
> Finn Thain (6):
>   ncr5380: Shorten host info string by removing unused option macros
>   ncr5380: Clean up dead code and redundant macro usage
>   ncr5380: Reduce #include files
>   ncr5380: Resolve various static checker warnings
>   ncr5380: Improve target selection robustness
>   atari_scsi: Reset DMA during bus reset only under ST-DMA lock
> 
>  drivers/scsi/NCR5380.c    |  64 ++++++++++-------------------
>  drivers/scsi/NCR5380.h    |  17 +-------
>  drivers/scsi/atari_scsi.c |  36 ++--------------
>  drivers/scsi/g_NCR5380.c  |  45 +++++++++++++++++++-
>  drivers/scsi/g_NCR5380.h  |  56 -------------------------
>  drivers/scsi/mac_scsi.c   |   8 ++--
>  drivers/scsi/sun3_scsi.c  |  83 +++++++++++++++++++++++++++++++++++--
>  drivers/scsi/sun3_scsi.h  | 102 ----------------------------------------------
>  8 files changed, 152 insertions(+), 259 deletions(-)
>  delete mode 100644 drivers/scsi/g_NCR5380.h
>  delete mode 100644 drivers/scsi/sun3_scsi.h
>