From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelvem-ot02.ext.ti.com (lelvem-ot02.ext.ti.com [198.47.23.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 053F827E1D7; Mon, 14 Apr 2025 14:43:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.235 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744641811; cv=none; b=CxpxzpX73ef6J9OqZhF5Hjgmt9DtAMDwND/mWY5u4pDyeQM6xJ8z9CMxx8ckbqtyOwFF7ZtyFiVN+11PMJSGTVoh4pokneY8He7dFBva7TonaT/yt6am9HOaAsyAysy65hLPN1ruk2lr/qXZervzOClDG5K4MP/T21l9sswfFzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744641811; c=relaxed/simple; bh=8ZpuCzo9q4nC5XCcYPWf329v5uOHg8EsUG8V5EQZMzs=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T3d1X+da7fxVEfuJogD+J9ZPr4ONcXKpY05hSHJk89UZHcREK1qZXEliiyHszZYO2Z91CYysx9XhZSmux1dL1wi9AhZVDNpvOJx98jbvq6qxClCul0gXS5DZI3YFz/LrGQZR2S7skkgc27vT2PKf4kj94AKK0smzsYPgvbRmgtk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=vH9oVWJ2; arc=none smtp.client-ip=198.47.23.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="vH9oVWJ2" Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelvem-ot02.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 53EEhM5S2715884 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Apr 2025 09:43:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1744641802; bh=Yv0jQ+VDdZHaxd5uxpw41+0vDJIDkJhqKIpTgHF8Kg4=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=vH9oVWJ2uIyvBSU9VlhDOoxmlYDwgXuyyr0/WbkRZLFjfHZ6gyIxuS/8sfOKY0d1E 7s4yZEEYzfT3zdXEc9TkLzJnHTubagy0rDw2NqlbwuATOBbhLypN8FvrfIDRmFFRNN zYVbi2NEEezCnGmu7AHrtUBvHSc4RsufvJo5Bf3Q= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 53EEhMVi091782 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Apr 2025 09:43:22 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 14 Apr 2025 09:43:21 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 14 Apr 2025 09:43:21 -0500 Received: from localhost (uda0492258.dhcp.ti.com [10.24.72.113]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 53EEhKZR010492; Mon, 14 Apr 2025 09:43:21 -0500 Date: Mon, 14 Apr 2025 20:13:19 +0530 From: Siddharth Vadapalli To: Nishanth Menon CC: Siddharth Vadapalli , , , , , , , , , , Subject: Re: [PATCH 0/2] J722S: DT Node cleanup for serdes0 and serdes1 Message-ID: <4106b4b8-6ca7-400f-8862-a45214284326@ti.com> References: <20250412052712.927626-1-s-vadapalli@ti.com> <20250414120930.m7x7zfmyby22urpo@ultimate> <79ef7f50-22d5-4c40-ae28-02bf297ca79c@ti.com> <20250414143916.zhskssezbffmvnsz@dragonfly> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250414143916.zhskssezbffmvnsz@dragonfly> X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea On Mon, Apr 14, 2025 at 09:39:16AM -0500, Nishanth Menon wrote: > On 18:30-20250414, Siddharth Vadapalli wrote: > > On Mon, Apr 14, 2025 at 07:09:30AM -0500, Nishanth Menon wrote: > > > > Hello Nishanth, > > > > > On 10:57-20250412, Siddharth Vadapalli wrote: > > > > Hello, > > > > > > > > This series is based on the following series: > > > > https://patchwork.kernel.org/project/linux-arm-kernel/cover/20250408103606.3679505-1-s-vadapalli@ti.com/ > > > > Based on the discussion in the above series which disabled 'serdes_wiz0' > > > > and 'serdes_wiz1' nodes in the SoC file and enabled them in the board > > > > file, Udit pointed out that it wasn't necessary to disable 'serdes0' and > > > > 'serdes1' in the SoC file anymore, since that is not a working > > > > configuration - serdes_wizX enabled and serdesX disabled doesn't work. > > > > > > > > Hence, this series aims to cleanup the serdesX nodes after the changes > > > > made by the above series. > > > > > > > > Regards, > > > > Siddharth. > > > > > > > > Siddharth Vadapalli (2): > > > > arm64: dts: ti: k3-j722s-main: don't disable serdes0 and serdes1 > > > > arm64: dts: ti: k3-j722s-evm: drop redundant status within > > > > serdes0/serdes1 > > > > > > > > arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 2 -- > > > > arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 4 ---- > > > > 2 files changed, 6 deletions(-) > > > > > > > > -- > > > > 2.34.1 > > > > > > > > > > > > > I do not understand the logic here. serdes cannot operate without wiz > > > nodes, correct? why would we leave serdes on by default? > > > > Yes, serdesX requires serdes_wizX, but at the same time, serdesX is the > > child node of serdes_wizX. Therefore, without enabling serdes_wizX, we > > cannot enable serdesX. > > > > Prior to this series, but with the dependent series at: > > https://patchwork.kernel.org/project/linux-arm-kernel/cover/20250408103606.3679505-1-s-vadapalli@ti.com/ > > applied, the nodes look like: > > > > serdes_wizX { > > ... > > status = "disabled"; > > > > serdesX { > > ... > > status = "disabled"; > > }; > > }; > > > > The dependent series fixes 'serdes_wizX' by disabling it in the SoC file > > k3-j722s-main.dtsi. But after the fix, we have a 'status = "disabled";' > > within the serdesX node which isn't required since: > > a) serdes_wizX enabled but serdesX disabled is non-functional and > > unusable > > b) serdes_wizX disabled in DT implies that serdesX is also disabled > > > Can we handle all of this in one series instead of two series? The idea behind splitting it was that the dependent series is a "Fix": - Fix to follow the convention of disabling nodes in SoC file and enable them in the board file. while the current series is a "cleanup": - No fixes are introduced by this series and therefore it doesn't require a backport. I can squash the two series and post them as a v2 if that helps. Regards, Siddharth.