From: Stephen Boyd <sboyd@kernel.org>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
linux-clk@vger.kernel.org
Cc: mturquette@baylibre.com, tsbogend@alpha.franken.de,
yangshiji66@outlook.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] clk: ralink: mtmips: fix clocks probe order in oldest ralink SoCs
Date: Thu, 14 Nov 2024 12:50:03 -0800 [thread overview]
Message-ID: <410a98684ff9f782a53035e512d9a52d.sboyd@kernel.org> (raw)
In-Reply-To: <20240910044024.120009-3-sergio.paracuellos@gmail.com>
Quoting Sergio Paracuellos (2024-09-09 21:40:23)
> Base clocks are the first in being probed and are real dependencies of the
> rest of fixed, factor and peripheral clocks. For old ralink SoCs RT2880,
> RT305x and RT3883 'xtal' must be defined first since in any other case,
> when fixed clocks are probed they are delayed until 'xtal' is probed so the
> following warning appears:
>
> WARNING: CPU: 0 PID: 0 at drivers/clk/ralink/clk-mtmips.c:499 rt3883_bus_recalc_rate+0x98/0x138
> Modules linked in:
> CPU: 0 PID: 0 Comm: swapper Not tainted 6.6.43 #0
> Stack : 805e58d0 00000000 00000004 8004f950 00000000 00000004 00000000 00000000
> 80669c54 80830000 80700000 805ae570 80670068 00000001 80669bf8 00000000
> 00000000 00000000 805ae570 80669b38 00000020 804db7dc 00000000 00000000
> 203a6d6d 80669b78 80669e48 70617773 00000000 805ae570 00000000 00000009
> 00000000 00000001 00000004 00000001 00000000 00000000 83fe43b0 00000000
> ...
> Call Trace:
> [<800065d0>] show_stack+0x64/0xf4
> [<804bca14>] dump_stack_lvl+0x38/0x60
> [<800218ac>] __warn+0x94/0xe4
> [<8002195c>] warn_slowpath_fmt+0x60/0x94
> [<80259ff8>] rt3883_bus_recalc_rate+0x98/0x138
> [<80254530>] __clk_register+0x568/0x688
> [<80254838>] of_clk_hw_register+0x18/0x2c
> [<8070b910>] rt2880_clk_of_clk_init_driver+0x18c/0x594
> [<8070b628>] of_clk_init+0x1c0/0x23c
> [<806fc448>] plat_time_init+0x58/0x18c
> [<806fdaf0>] time_init+0x10/0x6c
> [<806f9bc4>] start_kernel+0x458/0x67c
>
> ---[ end trace 0000000000000000 ]---
Applied to clk-next
next prev parent reply other threads:[~2024-11-14 20:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 4:40 [PATCH 0/3] clk: ralink: mtmips: some fixes and sdhc clock support Sergio Paracuellos
2024-09-10 4:40 ` [PATCH 1/3] clk: ralink: mtmips: fix clock plan for Ralink SoC RT3883 Sergio Paracuellos
2024-11-14 20:49 ` Stephen Boyd
2024-09-10 4:40 ` [PATCH 2/3] clk: ralink: mtmips: fix clocks probe order in oldest ralink SoCs Sergio Paracuellos
2024-11-14 20:50 ` Stephen Boyd [this message]
2024-09-10 4:40 ` [PATCH 3/3] clk: ralink: mtmips: add mmc related clocks for SoCs MT7620, MT7628 and MT7688 Sergio Paracuellos
2024-11-14 20:50 ` Stephen Boyd
2024-10-17 6:41 ` [PATCH 0/3] clk: ralink: mtmips: some fixes and sdhc clock support Sergio Paracuellos
2024-11-04 6:48 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=410a98684ff9f782a53035e512d9a52d.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=yangshiji66@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®