mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Vishnu Saini <vishsain@qti.qualcomm.com>,
	prahlad.valluru@oss.qualcomm.com,
	Prahlad Valluru <vvalluru@qti.qualcomm.com>
Subject: Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport
Date: Fri, 19 Dec 2025 13:10:19 +0100	[thread overview]
Message-ID: <4112ba0b-6feb-4e30-a57e-50ef9e3d6b5e@oss.qualcomm.com> (raw)
In-Reply-To: <aUU05P+xP1XdwihO@hu-vishsain-blr.qualcomm.com>

On 12/19/25 12:20 PM, Vishnu Saini wrote:
> On Thu, Nov 20, 2025 at 01:11:00PM +0100, Konrad Dybcio wrote:
>> On 11/20/25 11:58 AM, Vishnu Saini wrote:
>>> Monaco-evk has LT8713sx which act as DP to 3 DP output
>>> converter. Edp PHY from monaco soc is connected to lt8713sx
>>> as input and output of lt8713sx is connected to 3 mini DP ports.
>>> Two of these ports are available in mainboard and one port
>>> is available on Mezz board. lt8713sx is connected to soc over
>>> i2c0 and with reset gpio connected to pin6 or ioexpander5.
>>>
>>> Enable the edp nodes from monaco and enable lontium lt8713sx
>>> bridge node.
>>>
>>> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
>>> ---

[...]

>>> +	qup_i2c0_default: qup-i2c0-state {
>>> +		pins = "gpio17", "gpio18";
>>> +		function = "qup0_se0";
>>> +		drive-strength = <2>;
>>> +		bias-pull-up;
>>
>> Similarly, you can move these settings to monaco.dtsi and keep them as
>> defaults since 99.99% of I2C users will share them
> Is it ok if i update this in a different series, similar other nodes like qup_i2c1_default
> added in monaco-evk.dts?

No, I don't want you to introduce something "wrong" only because you
don't want to run git commit --amend

I see you've now sent a v2 just 7 minutes after asking this question.
Should I interpret that as you expecting me to drop everything and rush
to respond to your queries immediately, or do you not care about my
feedback anyway?

Konrad

  reply	other threads:[~2025-12-19 12:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 10:58 [PATCH 0/2] Enable lt8713sx bridge with displayport for monaco-evk Vishnu Saini
2025-11-20 10:58 ` [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport Vishnu Saini
2025-11-20 12:11   ` Konrad Dybcio
2025-12-19 11:20     ` Vishnu Saini
2025-12-19 12:10       ` Konrad Dybcio [this message]
2025-12-19 12:59         ` Vishnu Saini
2025-12-19 13:33           ` Konrad Dybcio
2025-11-20 14:26   ` Bjorn Andersson
2025-12-19 11:24     ` Vishnu Saini
2025-11-24 10:46   ` kernel test robot
2025-11-20 10:58 ` [PATCH 2/2] arm64: defconfig: Enable Lontium LT8713sx driver Vishnu Saini
2025-11-20 12:12   ` Konrad Dybcio
2025-11-20 13:47   ` Krzysztof Kozlowski
2025-12-19 11:10     ` Vishnu Saini
2025-11-20 14:14 ` [PATCH 0/2] Enable lt8713sx bridge with displayport for monaco-evk Rob Herring
2026-03-17  6:03 Vishnu Saini
2026-03-17  6:03 ` [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport Vishnu Saini
2026-03-17  9:22   ` Konrad Dybcio
2026-03-17 13:53     ` Vishnu Saini
2026-03-17 13:58       ` Konrad Dybcio
2026-03-17 11:42   ` Krzysztof Kozlowski
2026-03-17 14:10     ` Vishnu Saini
2026-03-17 14:40       ` Krzysztof Kozlowski
2026-03-17 14:40       ` Dmitry Baryshkov
2026-03-17 15:25         ` Vishnu Saini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4112ba0b-6feb-4e30-a57e-50ef9e3d6b5e@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prahlad.valluru@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=vishnu.saini@oss.qualcomm.com \
    --cc=vishsain@qti.qualcomm.com \
    --cc=vvalluru@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®