From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BCDF3B6BF7 for ; Wed, 1 Jul 2026 07:16:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782890209; cv=none; b=Z4r7o2e8JQTLPicWUjUXCSVS0DaVw8RBrIZB9FUB33mWZ4ZTyoHQFhV3zblACifOrKN2tzftxRT1p55BXQqSaw9Ve8CTQT+3/6yz3Kx3FAg1lcAL8Geu47ikyu1PMJfb5+tyuT06QPhQ3u/B2lXvQmI3aESALYqwKlH9B3eQHyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782890209; c=relaxed/simple; bh=/4LKNeeme3NOffjPb+nNorikshAcZgsjaJkeEGGabWc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fRglFlFiDRaEoDmY6BUJYY0J8KBgCFrHAdGOSQARU0Ribx31CSJ18kO2mxI1o2xQJC6HKfgV8fj53Hb03czwyYQZltgSxNNd9sfSUDE0PJFYxWVU1T/VWGrcgcLoi7/37X6cxkR/xqhjjmZm5o3PZKbE1is5HIGwL2pcvn11rXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jMSYWtB0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GRM3Nvrm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jMSYWtB0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GRM3Nvrm" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6615lOC5102896 for ; Wed, 1 Jul 2026 07:16:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= X2ckU9DLLAn5LdB48ZpPiIGBrsJhbpkMqNXUETVARFk=; b=jMSYWtB0xETMBELT d64Ood69eVceW3Vdxt15j4LqwyEWsYWoqWGnw8R8F3TaAsahMnkJpT0NQUQ0AEus 1JCqvf0I1ceGHvNYvCLZ8mrj1efo61wSNHxLloP6QB1fhM7vE55E7FCAEWZBFcEd tDmI1ZWCU0iqq+9OxAKA9jXigt6WYrT3SjqPhDriM5WQUYsuAkqH6Tgo+60QKiTY sGK0oTdchz71fs1Z86+9eXNvGy1maMuHcu1RQbiH9WeE4j203/excc66O68+3gWM xlj5uaye/sN1G6ksa00MQzR+Vh3zSFGbx5Wy7wqwOctaVl2hD6CDVicZIOv/5ja3 +powzQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jvwappy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Jul 2026 07:16:40 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-37ca4367860so1211060a91.1 for ; Wed, 01 Jul 2026 00:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782890200; x=1783495000; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X2ckU9DLLAn5LdB48ZpPiIGBrsJhbpkMqNXUETVARFk=; b=GRM3NvrmNBPhybpR0HpetIRaWOJV67lYAiVcqIKaoDflJQkNwgstbH6EE7qcGxCAqs DTw0NVbTainZzcrYla/4hIxYqXAZlYBK/+Us8ipU1k+5U4Ajcs3zW9M09odFCyhiSMJB XpuAz/lD2HtN8SN/sBV1XTICi4x1L9E58KW+ypc0Eyfi334Hesjjt7Bx+5BsjTTBsPCQ ojRMqCgLDflr3XAdZAvAWhpMTyY+QC1MrdFL4eTm+YSPUHda/Slg/4L1dt+yF8OAFf+o 4WRAOVqnm4bQtCMyeJDZ7k9J8jClzsmMrW+gW0G8cny3eIOYQM9GycPpsR+Un9u8bUI1 0mqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782890200; x=1783495000; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X2ckU9DLLAn5LdB48ZpPiIGBrsJhbpkMqNXUETVARFk=; b=WOun8KXY2JXX5adZGljVhcKiu03N15e2uoGOXnAhkzl0YC2FW1MPIoXY/X6fyRvOI5 iIGsj+NSOykxKgVefzFqApEg94QhUv8wSjdrtGENeUqzpwIgmXBFwaQ3yft33XQdCHJa +ZZWnSrmQF5M4auEONNt5GB9SQA6ZvlTo2GV+ZMAunsxF65o2gqBXGH2S4PvO2YDVV1u BMMGL2s4xmUp55rLyBhXZOgBYVKLO7WAkKERjKFuoOYHgcy8umN8pEKI0GdvzHKRp+H7 DzeAhL47pjYoaxgtRH1ANesm1KeTQCHLuq51ZBevBHd+Bw6/58tzZL290KYv6g1j+ewL dW5A== X-Forwarded-Encrypted: i=1; AHgh+RrYWDedg+nfcSYFvDqy3urC2L6mfAAJNVkHVvPCJr9YRopvufP7EYbHBuBUhuY24ByvBzfV/LV2EAM8Lz4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyy8+mJNDKivOqV5dinap+H4e9EZJi8y+ZaKU2QW4wfxrygS8sa sVpafNsWYezbLZEJxBiSMzFkcRWMggSgtZ7996yjtrN0Jk5wGv8QbKv/LEQcK0gIKviCCpBFBAB qeVytrT73wGQjNM8zz01awM2ViCb8EiZF8DPLP/ge1lCRH/z7nK0MKiU0AYaQ16WS+PRO7Ix0ae oX5w== X-Gm-Gg: AfdE7cnPredXX7Cxg3IG+rZEM7Cd2xcMkiklPTP4Cfm8kImd1egN2yUdyclkih1dwpg 0uXbW/fHRo7c0cVy63qWPrM2VS9sYmXROuSU/0wmuMkryEkNva1RblKKL0e7Bj2jldfC2XOG4kT kyG30Cp1oDzq2oBLJV/LW5FPRqVUcCB5UP5gvE1bC6PNMS87gN5M3A+x9LJITwAS5RpZgTxoDTb dtGmMa8gAipU47OHSdLGeK68FIEu2i0Ru6lb933L3FVJR1F9gk2uY5J0Ut3j6liDRLoPzivPPJE 50euo5h1z+jmBVhzNgac3hmA700fmm06VHsMymuNVkD+3Y/J+28jPpHT6GZuu7bUC47ImleC9d/ NzUFkoUZy/kVzVcK5G8IImoxuud6sOSW8zQXZUI7A35oaJzgcjVTc0d2DCChKqvpYx1oXRSIy3K I= X-Received: by 2002:a17:90b:1d49:b0:36b:b903:994 with SMTP id 98e67ed59e1d1-380674340d2mr4032534a91.4.1782890199818; Wed, 01 Jul 2026 00:16:39 -0700 (PDT) X-Received: by 2002:a17:90b:1d49:b0:36b:b903:994 with SMTP id 98e67ed59e1d1-380674340d2mr4032489a91.4.1782890199337; Wed, 01 Jul 2026 00:16:39 -0700 (PDT) Received: from [10.133.33.76] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c9bbcd9f5acsm2795438a12.10.2026.07.01.00.16.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 00:16:38 -0700 (PDT) Message-ID: <4117c406-0d75-4eb1-842e-1d346b7fbf99@oss.qualcomm.com> Date: Wed, 1 Jul 2026 15:16:31 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/5] dt-bindings: arm: coresight-tnoc: Add standalone qcom,coresight-agtnoc compatible To: Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Abel Vesa , Alexander Shishkin , Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <20260701-fix-tracenoc-probe-issue-v4-0-aefab449a470@oss.qualcomm.com> <20260701-fix-tracenoc-probe-issue-v4-1-aefab449a470@oss.qualcomm.com> <20260701-stirring-piculet-of-vastness-a361e5@quoll> Content-Language: en-US From: Jie Gan In-Reply-To: <20260701-stirring-piculet-of-vastness-a361e5@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: iFmDFPVcipTy-wgx7kYOjEZiQ-l2fCMM X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDA3MyBTYWx0ZWRfX+DvA5kFxM40Z i23wG/TKZJG8KcBwTHH/7FbFapeiKVPVmM27F13RdBi5gXJAOv+PnwiPruqUXNQDL27f8Xh+RwO L9rf+TlnbdJx386uhuaBFm6hYsb/haE= X-Authority-Analysis: v=2.4 cv=JKgLdcKb c=1 sm=1 tr=0 ts=6a44bed8 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=GqxzKewt3drvE_C864MA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: iFmDFPVcipTy-wgx7kYOjEZiQ-l2fCMM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDA3MyBTYWx0ZWRfXxTej9Ki9GIhT F75bHqoz9c8qzEa7WCgQ/+UW7Amf7HiG0Y8v52YnFH96K++K2ePieryOnr+BN/SVQOgoHyUrl/k r7herC5JU6OgKrxbXT9S/fzGNnp4UxghGz3QZoIBrZ1sqn9VJJtIBx8t2vwkZu1N3gHM3GDIueQ x8KWj4AoQW9XCKcSKcYIUe/4NrBCgUqaas5U9j1ulpYJK5Pw+/gC+V58BMBUw/KiH5GVbe/WUZm zZCizmDXo2O/n0BZaxJp7JIeMT+lr0xkBS+lOP2UMogRay35rwfzoRHN8BDqHKN1WQ/sbuooYFf bbVXJ9rrfGyfLU0T42sfoH7uqd0T0+P4pkXZobkMEn03EbTKPOLBv5vZKSPK3fymvVRP+lmCMhK 4IUhn6kfwtGd1TQPii0n4ezDKN7UIHdYTdZgS/vKc21cgCaNRbWnmdRG6xBppdMK6hVTzXZetU5 XIUKyyAwXYg/3sAxBFA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-01_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607010073 On 7/1/2026 2:57 PM, Krzysztof Kozlowski wrote: > On Wed, Jul 01, 2026 at 09:53:41AM +0800, Jie Gan wrote: >> The TNOC compatible previously only allowed the two-string AMBA form >> "qcom,coresight-tnoc", "arm,primecell", which forces the device onto the >> AMBA bus. >> >> Convert the compatible to a oneOf and add a standalone >> "qcom,coresight-agtnoc" compatible alongside the existing AMBA form. The >> standalone string carries no "arm,primecell" entry, so the device is >> created on the platform bus instead of the AMBA bus. > > That's a Linux driver specific reason, so not a valid one. > > Describe the hardware instead. > > Also, you do not get other compatible for the same device. The device is intended to be discovered and probed via the AMBA bus. However, due to a hardware issue, AMBA probing does not work correctly. While adding the arm,primecell-periphid property would allow the existing AMBA driver to bind, but I think that's a temp WA. As Suzuki/Leo pointed out, we should not add the property to pretend the device as an AMBA device. Instead, I introduced a dedicated compatible string so the device can be handled by the existing platform driver without relying on the missing AMBA primecell identification. The purpose of the new compatible is to clearly distinguish this platform-specific case from the standard AMBA-based implementation. Or shall I re-use the existing compatible "qcom,coresight-tnoc" as platform standalone compatible? We already have a similar pattern for the interconnect TraceNoC device, which uses the platform-specific compatible string qcom,coresight-itnoc. Thanks, Jie > > Best regards, > Krzysztof >