From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751911AbbFHBaD (ORCPT ); Sun, 7 Jun 2015 21:30:03 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:42654 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbbFHB3x (ORCPT ); Sun, 7 Jun 2015 21:29:53 -0400 X-AuditID: cbfee690-f796f6d000005054-7e-5574f00e8979 Date: Mon, 08 Jun 2015 01:29:50 +0000 (GMT) From: MyungJoo Ham Subject: Re: Re: [PATCH] extcon: max77843: Clear IRQ bits state before request IRQ To: =?utf-8?Q?=EC=B5=9C=EC=B0=AC=EC=9A=B0?= Cc: =?utf-8?Q?=EA=B9=80=EC=9E=AC=EC=9B=90?= , "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20150608012855123@myungjoo.ham Msgkey: 20150608012855123@myungjoo.ham X-EPLocale: ko_KR.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20150608012855123@myungjoo.ham X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <411808660.660571433726990534.JavaMail.weblogic@epmlwas07c> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWyRsSkRJfvQ0mowf7NehaXd81hc2D0+LxJ LoAxissmJTUnsyy1SN8ugSvjx4dlLAXTxCoOL57N2MB4QrSLkZNDSEBdYtGSk2wgtoSAicTi pXtZIWwxiQv31gPFuYBqljJKvJu8hB2maPndqVCJOYwSv7sOMoMkWARUJFpmLwDq5uBgE9CT mPk5GSQsLBAkcfvhdLBeEQFXiZVrF7GA9DILXGGUaNv/lw3iCiWJNftesYDYvAKCEidnPmEB mSMhoCpx5k0wRFhN4vP2T1CHiktcmHsJ6h5eiRntT1kgbDmJaV/XMEPY0hLnZ21ghHlm8ffH UHF+iWO3dzBB2AISU88chKrRkpiyvR1qDp/EmoVvWWDqd51azgyz6/6WuVC9EhJbW56AA4tZ QFFiSvdDdpCTmQU0Jdbv0kf1CYjtLvHt1xx2kNclBGZySDTP+MQ4gVFpFpK6WUhGzUIYhaxk ASPLKkbR1ILkguKk9CITveLE3OLSvHS95PzcTYzAtHD637MJOxjvHbA+xCjAwajEw3tgUUmo EGtiWXFl7iFGU2AkTWSWEk3OByafvJJ4Q2MzIwtTE1NjI3NLMyVx3tdSP4OFBNITS1KzU1ML Uovii0pzUosPMTJxcEo1MAr3Ps7xPyPqJ1ZVJ5KzXcX2w1PdeUHRD+cevDE7ZJKHmNXR2ZuT PI6uE7HYckvi7yWl1W7lHCovVul3HLu9vMFkDvtUvW1vvr2odL++U/HRpBZp7RjtLVbKh6o+ TNnr8v2KRC7Xm72rFiU/N6o8+UzWtGin36GH82xvCxVq9uX3XYtX38Xgr6rEUpyRaKjFXFSc CADn1oq3BgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCKsWRmVeSWpSXmKPExsVy+t/tfl2+DyWhBhNXq1tc3jWHzYHR4/Mm uQDGqDSbjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCh SgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDcyM9IwM9UyM9Q+NYK0MDAyNToJqEtIwf H5axFEwTqzi8eDZjA+MJ0S5GTg4hAXWJRUtOsoHYEgImEsvvToWyxSQu3FsPZHMB1cxhlPjd dZAZJMEioCLRMnsBaxcjBwebgJ7EzM/JIGFhgSCJ2w+ns4PYIgKuEivXLmIB6WUWuMIo0bb/ LxvEMiWJNftesYDYvAKCEidnPmEBmSMhoCpx5k0wRFhN4vP2T1A3iEtcmHuJHcLmlZjR/pQF wpaTmPZ1DTOELS1xftYGRpibF39/DBXnlzh2ewcThC0gMfXMQagaLYkp29uh5vBJrFn4lgWm ftep5cwwu+5vmQvVKyGxteUJK4jNLKAoMaX7ITvIycwCmhLrd+mj+gTEdpf49msO+wRG2VlI UrOQdM9C6EZWsoCRZRWjaGpBckFxUnqFoV5xYm5xaV66XnJ+7iZGcAp6tnAH45fz1ocYBTgY lXh4DywqCRViTSwrrsw9xCjBwawkwnv3PlCINyWxsiq1KD++qDQntfgQoykwyiYyS4km5wPT Y15JvKGxsYmZiamliYWBqbmSOO//c7khQgLpiSWp2ampBalFMH1MHJxSDYxNXM1bvunUZDn/ vOtjv+Nvkob9pn+qzw9/eGg+tbU37DDn18jfM/b9Ohco+uNH1uPan5s878560uGf4brtEtdt Ka3PSabS+zrf/OJmZubWjBH9upM5+JyI54Y+2X3FLz4xVOqty/i46M+yU94RGz5btQQZH13+ zLxu4qvIjNWHU/4xegfUlMorsRRnJBpqMRcVJwIABI1aUFcDAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t581UHkM018687 > > On 06/05/2015 01:54 PM, MyungJoo Ham wrote: > >> > >> IRQ signal before driver probe is needless because driver sends > >> current state after platform booting done. > >> So, this patch clears MUIC IRQ bits before request IRQ. > >> > >> Signed-off-by: Jaewon Kim > >> --- > >> drivers/extcon/extcon-max77843.c | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > > > > Q1. Is this because the pending bits are USELESS? > > or because the pendeing bits incurs INCORRECT behaviors? > > The max77843 datasheet includes following sentence: > - "All bits are cleared after a read" about INT1/INT2/INT3 register. > There are no problem about interrupt handling. > > > > > Q2. Does clearing (by reading) INT1 do everything you need? > > What about INT2 and INT3? > > The MAXIM MAX77843 MUIC support the one more interrupts (e.g., ADC1K, VBVolt, ChgTyp ...). > The each interrupt is included in the one register among INT1/2/3. > > This patch clear the all interrupts of MAX77843 before requesting the interrupts. > > > > > Q3. I presume that "driver sends current state after..." is > > coming from the invokation of "queue_delayed_work()" at the end > > of the probe function. It appears that you are only serving > > the pending status of "cable detection" with it while INT1 > > seems to have more functionalities. Does that delayed work > > do everything that are pending, really? > > When completed kernel booting, the delayed work of extcon-max77843.c driver > use the MAX77843_MUIC_STATUSx register to detect the type of connected > external connectors. So, there are no problme about clearing all bits of INT1/2/3 interrupt register. > > If user-space platform don't finish the initialization of all user-process daemons > and extcon driver send the uevent during only kernel booting, the uevent is not handled > on user-space daemons. > > Thanks, > Chanwoo Choi Ok. Looks Good. Thanks for the explanation. Acked-by: MyungJoo Ham {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I