Re: BUG: KASAN: global-out-of-bounds in strscpy+0x807/0x970

[Tyler Hicks <tyhicks@canonical.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1408 bytes --]

On 10/10/2017 10:32 PM, Simon Brewer wrote:
> Hint start looking at this thread. https://lkml.org/lkml/2017/7/18/874
> 
> Summary: strscpy and KASAN are currently incompatible.  strscpy does a
> 64 bit speculative fetch on a char pointer (for efficiency reasons). 
> KASAN spots this and flags an error.

Thanks, Simon. I had already reviewed the loop in
seccomp_names_from_actions_logged() and couldn't spot an issue so my
next step was to take a look at strscpy() itself. Your reply was well
timed. :)

@Kees, this is a false positive. I picked strscpy() because of its sane
return codes for easy error handling but its word-at-a-time complexity
is overkill for this sysctl. Are you alright with this KASAN false
positive or would you like me to change over to strlcpy()?

Tyler

> 
> On 11 October 2017 at 12:46, Jakub Kicinski <kubakici@wp.pl
> <mailto:kubakici@wp.pl>> wrote:
> 
>     On Tue, 10 Oct 2017 21:44:01 -0400, Tyler Hicks wrote:
>     > On 10/10/2017 09:28 PM, Jakub Kicinski wrote:
>     > > I'm hitting this on sysctl -a with net-next (4.14-rc4).
>     >
>     > Hey Jakub - thanks for the bug report!
>     >
>     > >
>     > > I saw that seccomp_actions_logged_handler was introduced
>     > > not-so-long-ago by Tyler, is there a fix for this?
>     >
>     > No, this is the first I've heard of it. I'll have a look.
> 
>     Thanks! :)
> 
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]