From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B9E035FF72 for ; Wed, 14 Jan 2026 07:29:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768375748; cv=none; b=raceUwW5Myli4Vich9zFRvDAFfoWJVSMNfGtSGdwFxIUb+oHfnpw8d67GwCuN0I5Ghs5mDf/0ebj0VS0+Uoh55Irtd8T7UB4W5knykpg1VcwBFd4P+U+xYqJNHg/yNH3kP67aofoydE4MuLF7fDOdaJqvaR/49m/FBorIULm0SI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768375748; c=relaxed/simple; bh=svwloPuWqcxO7bfrg7PFjEgIq+L6BI8w797MN6L7KgQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Idc9qF6Ld1LgZhMknppDW4+dyxfYNENzdRqwKpAnvzlc3N4yTa2eCNaqjUR7uOOnUYUNQQQssJB/sY75twZv2y5sWh8CDMo/sdocZxX3j5McVy+Ydza2ZHGFT/k5PD3wrEFf1KTglCUSTowt96AVSAuWSv1W4dEb9l63RRkQD7Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Tp8n5oNv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Mk2GipCb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Tp8n5oNv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Mk2GipCb" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E664Tn2766052 for ; Wed, 14 Jan 2026 07:29:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nhGxIZ9kW1OKAnMPXyr3he7wuhlzcR3uKNd2soiX6x0=; b=Tp8n5oNvR/Vtq7h0 s0i5rW07+zZadJjA4M6DJhtHLgSxobKOhMHtUsN7Vr68Gp9nOY2ZgRuwCnkoutiR yPy9sM/sD2aTd6kry87EMhcx+TWEH+aMIr04oltlqr108KBf/Z0QBl/I+GPnt6K4 VZi5CapUOJyrkynBYsqQMdvj2eXqRBjRor3+ALMRnVHlIBr0uK7hv++dUMsjzoU+ QmaDGjQFzAXnphzMtty22l8jvj5WyNc8iyUMFjj2KS4t49Aoxa3qC5d5D/tjx+KL ApEzTnYT1wHM4bL+8AySWohl5z3tB3rQpXXXVVSfC3weJMiefojVnKoNkmkRHILu TKfBCA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnt63tkdw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 07:29:02 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29f1f69eec6so88342925ad.1 for ; Tue, 13 Jan 2026 23:29:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768375742; x=1768980542; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nhGxIZ9kW1OKAnMPXyr3he7wuhlzcR3uKNd2soiX6x0=; b=Mk2GipCbniWgTcfvdqEdWdEUe0qewqrt32vv7ehOjMoFNaaAO57VDvFpAXmmuLHk8E rNkStuI/wFV0PSQM3fvxwhkOdUIBNVhhk4MN9lm2CywziqwEcWlE73oCMYLTbEAW7vRK a1OH8PyYysfk8nQb1SYnQf3ESuUP5FKByh03AL0Vlg+jWBuaVcdbimfiowwwRi8bnsSh TJqkpeeDZmprUoxlOibNhGK4ynNByiINiZQcPLxPRy9+m14P7HItE/zorGra1O5jNfvv mz9vk7Nk4TKLsSvW/8P6MqAUaUsFHN0HsbjH6r6gDk8JTrD7sjIYeZerXHaSaypW3wSI cKHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768375742; x=1768980542; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nhGxIZ9kW1OKAnMPXyr3he7wuhlzcR3uKNd2soiX6x0=; b=ZL+mJrxAdT2sWeC7rfS8Ua2WnQEfl6iyQ4mNbK0M+aT/8uaUTlOM8x8krZMxzvWfcg GzGFOQXL2yDx2xKHub8T3rkfMQj8/gNtJGk7BN0LMFFagokiq/qDuogTrUM3K9lDhxC7 wSCCguPXwrvsWzJvF4HTpPDYarGbXsm+5mtRGfyWWh5Qjb/ZufAjy+tPs9oaYI9yeAPR V3JOcIFnYZH+USMZ9QYtYTKSrNzr4voJ1AyNWF+Sa4VHA+uQnShyzfMxbvMkuM6VBalh vcJJWw89OQHq28cbnDJzI530zwDqFc7PjJlyLRSjcGCH29/nc88n52mLFJHeR4e3FgPg va+A== X-Forwarded-Encrypted: i=1; AJvYcCWXw5twjuYWoXSsgUOS4c88YwCyEf3LrRrjXnHH1M27XPiWCxI6Oi2JFD5euM5Lc4GUJbFQEOaS0lmHNBM=@vger.kernel.org X-Gm-Message-State: AOJu0YwMg3NgM8LClIrzGTOdXnFQWfLXWfH8DtafTbGUpzCNALfG8mVV vFFYPZHSXIeTK2y1p2e01l3Lxkr54zj1k3JCARasqrv8aHl+Il0bwyQZyv+eXJmCZLzLFtLJwGt ohk4f0GcfKAhgkN+G9kFMJAhTrO4gwvzJrz+sWfpOg/ifk4z/Cmph1kZxYb24n00lDq4= X-Gm-Gg: AY/fxX4yQNVYkUgfXU1AXTQsrVCvXzJhuz+oiDyqy68wu0vWnU56sYxZzkLsyAfdTX5 xTMIpHhmdqctGl0Wq9USvlztfXKbPRkzfmmHjudUN2SwZBy3yJcrOpv4/jep6S+1oephadMKQH6 aq578qFEFQNKTy9wyWzDnCv03242FW7ezqDABaKDQNCKIkwPr/ekNiC2YYWt7XWiv8uE7FUovDI wNyLQZhImsGl6CGVFGV12O7GdlZ+JTTBKM2eEeTsYHcIb6gJ82Cf8ybXNXxqck+mSuej3ypsnth p0SeMmpofbDxl0z8p0R2CIGjoXc6tDVUvdAS/a5TaqGmZI8uPQ69uSRUSXpBv6PUZLWUj6XtsRw 0HsRWALFlvYkl7uNo8NlzPz/crwYvIMCl1pUG+LjZqjIk X-Received: by 2002:a17:903:40cb:b0:298:4ee3:c21a with SMTP id d9443c01a7336-2a599d826b0mr20847105ad.2.1768375741538; Tue, 13 Jan 2026 23:29:01 -0800 (PST) X-Received: by 2002:a17:903:40cb:b0:298:4ee3:c21a with SMTP id d9443c01a7336-2a599d826b0mr20846895ad.2.1768375741018; Tue, 13 Jan 2026 23:29:01 -0800 (PST) Received: from [10.206.109.90] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a2f7sm223039555ad.16.2026.01.13.23.28.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 23:29:00 -0800 (PST) Message-ID: <4124d961-b262-c75e-5e34-01be1edf7959@oss.qualcomm.com> Date: Wed, 14 Jan 2026 12:58:54 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 08/11] media: iris: don't specify max_channels in the source code Content-Language: en-US To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, Bryan O'Donoghue References: <20260113-iris-ubwc-v2-0-4346a6ef07a9@oss.qualcomm.com> <20260113-iris-ubwc-v2-8-4346a6ef07a9@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260113-iris-ubwc-v2-8-4346a6ef07a9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDA1NyBTYWx0ZWRfX9Z14jCDc8z77 5pXvskRnGskhfzpH8RORIah05NPiru+kkC3IdQn8q1D+V7mgqj8PAvf+DVAz4aKCvNRh1rfZ5g2 0Cq8yVC8bSKyJOYIZcm/Um+pmg/T4NZbFAtWJDmBn4WH4LMleRlNRq5aU+JgPlKxiMhpCfqhT1A ZOCm9KPJ4G/MvRWzPxbpZUW+CxF7Q491N40u3NYtFjWz5M82a9l6aKMwC6XCA0/KKgeRf4uESCT q9uOJKcOyOo6rw+k7j5Nyy5Saw/1lH3WkvX8bHROd+W+ZZrzfNGScERrOR8AdFIz/1HGKJ9eeKU ae7D4fV6vwsn+c3qmOKMkydi2CA9mfKqoJoTj4auiQeUKMOGTf+Szi0lpxFHqE3W26SIAgGihbg TiEmHwXIs3zYj9Ldx5U/NgELvJMs20sUEQ4DYBUZ8qUJ3QpJKOgHxvfP6KQdya47lCZ/SuUutYG BAKJXqe/JMl3iw50hqA== X-Proofpoint-ORIG-GUID: WdlO3eCBU40FFwsE_Kx7b6nK_KBxHGHE X-Proofpoint-GUID: WdlO3eCBU40FFwsE_Kx7b6nK_KBxHGHE X-Authority-Analysis: v=2.4 cv=EujfbCcA c=1 sm=1 tr=0 ts=696745be cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=S5pdipytwMNRnYpo3tEA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_02,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140057 On 1/13/2026 10:27 PM, Dmitry Baryshkov wrote: > The UBWC max_channels spreading is specified in the Iris driver, but it > also can be calculated from the platform UBWC config. Use the platform > UBWC configuration instead of specifying it directly in the source. > > Reviewed-by: Konrad Dybcio > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c | 2 +- > drivers/media/platform/qcom/iris/iris_platform_common.h | 1 - > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 1 - > 3 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > index 9945c939cd29..91dbea4c6664 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > @@ -139,7 +139,7 @@ void iris_hfi_gen2_packet_sys_init(struct iris_core *core, struct iris_hfi_heade > &payload, > sizeof(u32)); > > - payload = core->iris_platform_data->ubwc_config->max_channels; > + payload = ubwc->macrotile_mode ? 8 : 4; > iris_hfi_gen2_create_packet(hdr, > HFI_PROP_UBWC_MAX_CHANNELS, > HFI_HOST_FLAGS_NONE, > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index f99fcbb8fced..4abaf4615cea 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -72,7 +72,6 @@ struct tz_cp_config { > }; > > struct ubwc_config_data { > - u32 max_channels; > }; > > struct platform_inst_caps { > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > index c967db452dec..e78cda7e307d 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > @@ -632,7 +632,6 @@ static const struct platform_clk_data sm8550_clk_table[] = { > }; > > static struct ubwc_config_data ubwc_config_sm8550 = { > - .max_channels = 8, > }; > > static struct tz_cp_config tz_cp_config_sm8550 = { > Reviewed-by: Dikshita Agarwal Thanks, Dikshita