From: Chetan.Loke@Emulex.Com
To: <akataria@vmware.com>
Cc: <brking@linux.vnet.ibm.com>, <James.Bottomley@suse.de>,
<eike-kernel@sf-tec.de>, <matthew@wil.cx>, <rdreier@cisco.com>,
<bvanassche@acm.org>, <robert.w.love@intel.com>,
<randy.dunlap@oracle.com>, <michaelc@cs.wisc.edu>,
<linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
<pv-drivers@vmware.com>
Subject: RE: [PATCH] SCSI driver for VMware's virtual HBA - V3.
Date: Wed, 9 Sep 2009 15:48:38 -0700 [thread overview]
Message-ID: <412A05BA40734D4887DBC67661F433080FF72C2B@EXMAIL.ad.emulex.com> (raw)
In-Reply-To: <1252458467.24914.66.camel@ank32.eng.vmware.com>
> -----Original Message-----
> From: Alok Kataria [mailto:akataria@vmware.com]
> Sent: Tuesday, September 08, 2009 9:08 PM
> To: Loke,Chetan
> Cc: brking@linux.vnet.ibm.com; James.Bottomley@suse.de; eike-kernel@sf-
> tec.de; matthew@wil.cx; rdreier@cisco.com; bvanassche@acm.org;
> robert.w.love@intel.com; randy.dunlap@oracle.com; michaelc@cs.wisc.edu;
> linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; akpm@linux-
> foundation.org; pv-drivers@vmware.com
> Subject: RE: [PATCH] SCSI driver for VMware's virtual HBA - V3.
>
> Hi Chetan,
>
> > Alok,
> >
> > (This is just a optimization.You don't need it in order to get your
> > code merged upstream.You can always patch it later on)In fact hw_lock
> > should be split into two locks -
> >
> > req_path_lock(aka tx_lock) and
> > cmpl_path_lock(aka rx_lock).
> >
> > You can then have a full-duplex channel.
> >
> > Revised-code -
> > ::pvscsi_acquire_context->spin_lock_irqsave(tx_lock)
> > ::pvscsi_isr->spin_lock_irqsave(rx_lock)
> > ::some_future_napi_style_pvrx_poll_func->spin_lock_irqsave(rx_lock)
> >
> > ::for aborts synchronize on the rx_lock so that you know what's
> > completed and what's not.
> >
>
> I agree about the optimization. Though IMO this will be more attractive
> once we have a device which supports multiple queue pairs.
lpfc driver has native multi-ring support. It won't create hundred's of ring-pairs but the stuff that's present is good enough to start with(at least for this generation).
> Anyways, let me keep this on my plate, I will check how much of an
> benefit this gets us and will decide if this should be done, but as you
> suggested this is for later.
>
I keep forgetting that this is a pv-driver.So, to reap the benefits of the multi-ring arch, the plumbing should be present in your hypervisor/kernel and NOT in the guest-world.
> Thanks for taking a look.
No worries.
>
> --Alok
Chetan
next prev parent reply other threads:[~2009-09-09 22:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 19:37 Alok Kataria
2009-09-03 21:18 ` Rolf Eike Beer
2009-09-03 21:52 ` Brian King
2009-09-03 22:21 ` Chetan.Loke
2009-09-09 1:07 ` Alok Kataria
2009-09-09 22:48 ` Chetan.Loke [this message]
2009-09-09 1:07 ` Alok Kataria
2009-09-04 9:28 ` Gerd Hoffmann
2009-09-04 16:51 ` Alok Kataria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412A05BA40734D4887DBC67661F433080FF72C2B@EXMAIL.ad.emulex.com \
--to=chetan.loke@emulex.com \
--cc=James.Bottomley@suse.de \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=brking@linux.vnet.ibm.com \
--cc=bvanassche@acm.org \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=michaelc@cs.wisc.edu \
--cc=pv-drivers@vmware.com \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=robert.w.love@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®