From: Marek Vasut <marex@denx.de>
To: Mingwei Zheng <zmw12306@gmail.com>
Cc: antonio.borneo@foss.st.com, linus.walleij@linaro.org,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
make24@iscas.ac.cn, peng.fan@nxp.com,
fabien.dessenne@foss.st.com, linux-gpio@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Jiasheng Jiang <jiashengjiangcool@gmail.com>
Subject: Re: [PATCH v6] pinctrl: stm32: Add check for clk_enable()
Date: Mon, 23 Dec 2024 20:33:07 +0100 [thread overview]
Message-ID: <412e65b5-dd91-4982-8b1a-423997da9a28@denx.de> (raw)
In-Reply-To: <20241223020629.3471182-1-zmw12306@gmail.com>
On 12/23/24 3:06 AM, Mingwei Zheng wrote:
[...]
Shouldn't the clock be enabled before calling
stm32_gpiolib_register_bank() ? I think the
clk_bulk_prepare_enable(pctl->nbanks, pctl->clks); should be around here.
> @@ -1646,15 +1628,18 @@ int stm32_pctl_probe(struct platform_device *pdev)
> if (ret) {
> fwnode_handle_put(child);
>
> - for (i = 0; i < pctl->nbanks; i++)
> - clk_disable_unprepare(pctl->banks[i].clk);
> -
> return ret;
> }
>
> pctl->nbanks++;
> }
>
> + ret = clk_bulk_prepare_enable(pctl->nbanks, pctl->clks);
> + if (ret) {
> + dev_err(dev, "failed to prepare_enable clk (%d)\n", ret);
> + return ret;
> + }
> +
> dev_info(dev, "Pinctrl STM32 initialized\n");
>
> return 0;
Aside from that one question, this looks good, thanks !
prev parent reply other threads:[~2024-12-23 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 2:06 Mingwei Zheng
2024-12-23 19:33 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412e65b5-dd91-4982-8b1a-423997da9a28@denx.de \
--to=marex@denx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=antonio.borneo@foss.st.com \
--cc=fabien.dessenne@foss.st.com \
--cc=jiashengjiangcool@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=make24@iscas.ac.cn \
--cc=mcoquelin.stm32@gmail.com \
--cc=peng.fan@nxp.com \
--cc=zmw12306@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®