From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753830AbdLFAzL (ORCPT ); Tue, 5 Dec 2017 19:55:11 -0500 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:52152 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753339AbdLFAzI (ORCPT ); Tue, 5 Dec 2017 19:55:08 -0500 From: "Rafael J. Wysocki" To: Borislav Petkov , Colin King Cc: Len Brown , Tony Luck , Tyler Baicar , Will Deacon , linux-acpi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI / APEI: remove redundant variables len and node_len Date: Wed, 06 Dec 2017 01:54:32 +0100 Message-ID: <4133483.q48axFpL8f@aspire.rjw.lan> In-Reply-To: <20171128105110.hrfe6nh7hzmo5p4f@pd.tnic> References: <20171015212454.16012-1-colin.king@canonical.com> <20171128105110.hrfe6nh7hzmo5p4f@pd.tnic> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, November 28, 2017 11:51:10 AM CET Borislav Petkov wrote: > On Sun, Oct 15, 2017 at 10:24:54PM +0100, Colin King wrote: > > From: Colin Ian King > > > > Variables len and node_len are redundant and can be removed. Cleans > > up clang warning: node_len = GHES_ESTATUS_NODE_LEN(len); > > > > Signed-off-by: Colin Ian King > > --- > > drivers/acpi/apei/ghes.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > > index 3c3a37b8503b..f2e1049232c0 100644 > > --- a/drivers/acpi/apei/ghes.c > > +++ b/drivers/acpi/apei/ghes.c > > @@ -923,7 +923,6 @@ static void ghes_print_queued_estatus(void) > > struct ghes_estatus_node *estatus_node; > > struct acpi_hest_generic *generic; > > struct acpi_hest_generic_status *estatus; > > - u32 len, node_len; > > > > llnode = llist_del_all(&ghes_estatus_llist); > > /* > > @@ -935,8 +934,6 @@ static void ghes_print_queued_estatus(void) > > estatus_node = llist_entry(llnode, struct ghes_estatus_node, > > llnode); > > estatus = GHES_ESTATUS_FROM_NODE(estatus_node); > > - len = cper_estatus_len(estatus); > > - node_len = GHES_ESTATUS_NODE_LEN(len); > > generic = estatus_node->generic; > > ghes_print_estatus(NULL, generic, estatus); > > llnode = llnode->next; > > Reviewed-by: Borislav Petkov Patch applied, thanks!