From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D4ABC432C3 for ; Tue, 19 Nov 2019 12:56:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30516208CC for ; Tue, 19 Nov 2019 12:56:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727919AbfKSM4F (ORCPT ); Tue, 19 Nov 2019 07:56:05 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:48626 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbfKSM4F (ORCPT ); Tue, 19 Nov 2019 07:56:05 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id B8E32290BBA Message-ID: <4135d35cd581b31d08b547852ac43e959957abf5.camel@collabora.com> Subject: Re: [PATCH v11 02/11] media: staging: rkisp1: add document for rkisp1 meta buffer format From: Ezequiel Garcia To: Jacob Chen , Helen Koike Cc: Hans Verkuil , "open list:ARM/Rockchip SoC..." , mark.rutland@arm.com, devicetree@vger.kernel.org, Eddie Cai , kernel@collabora.com, Heiko Stuebner , Jacob Chen , gregkh@linuxfoundation.org, Jeffy Chen , =?UTF-8?Q?=E9=92=9F=E4=BB=A5=E5=B4=87?= , linux-kernel@vger.kernel.org, Tomasz Figa , robh+dt@kernel.org, Hans Verkuil , Laurent Pinchart , Sakari Ailus , Shunqian Zheng , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Linux Media Mailing List Date: Tue, 19 Nov 2019 09:55:51 -0300 In-Reply-To: References: <20191114051242.14651-1-helen.koike@collabora.com> <20191114051242.14651-3-helen.koike@collabora.com> <09d4f683-d03d-46c9-e9d2-b8cceb72446e@xs4all.nl> <9cb116f6-64f4-1510-b128-8657d6d4889b@collabora.com> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jacob, Thanks for the insight. On Tue, 2019-11-19 at 18:16 +0800, Jacob Chen wrote: > Hi Helen , > > Helen Koike 于2019年11月14日周四 下午6:59写道： > > > > > > On 11/14/19 6:21 AM, Hans Verkuil wrote: > > > On 11/14/19 6:12 AM, Helen Koike wrote: > > > > From: Jacob Chen > > > > > > > > This commit add document for rkisp1 meta buffer format > > > > > > > > Signed-off-by: Jacob Chen > > > > [refactored for upstream] > > > > Signed-off-by: Helen Koike > > > > > > checkpatch gives me: > > > > > > WARNING: Missing Signed-off-by: line by nominal patch author 'Jacob Chen ' > > > > > > Looking at this series I see duplicate Signed-off-by entries for Jacob Chen and a total > > > of three different email addresses: > > > > > > jacob2.chen@rock-chips.com > > > jacob-chen@rock-chips.com > > > cc@rock-chips.com > > > > And I see a name in the Maintainers file as Jacob Chen . > > I was wondering if I could replace the email by jacob-chen@iotwrt.com, or if I should > > keep the original ones. > > > > Helen > > > > "jacob2.chen@rock-chips.com"/"jacob-chen@rock-chips.com" is me and > "cc@rock-chips.com" is another one. > ' jacob-chen@rock-chips.com' is invalid now, so you could replace the > email by 'jacob-chen@iotwrt.com'. > Authorship and SOB can't be changed freely, the original must be retained, because this gives proper credit to the company that sponsored the work. I.e. if your mail used to be jacob2.chen at rock-chips.com, then I think we can use that. And if cc at rock-chips.com is a different engineer, also named Jacob Chen, perhaps we can mention that somewhere to reduce the confusion. Thanks, Ezequiel