mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ronak Doshi <doshir@vmware.com>
To: Jacob Keller <jacob.e.keller@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Pv-drivers <Pv-drivers@vmware.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Guolin Yang <gyang@vmware.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 net 2/2] vmxnet3: use correct intrConf reference when using extended queues
Date: Tue, 29 Nov 2022 00:35:27 +0000	[thread overview]
Message-ID: <4137D072-6887-47A5-9652-0F0A5FFBE329@vmware.com> (raw)
In-Reply-To: <8ba44ad1-675f-92c2-0e13-6bf9c4f8e598@intel.com>


On 11/28/22, 3:49 PM, "Jacob Keller" <jacob.e.keller@intel.com> wrote:
>     !! External Email
>
>     On 11/28/2022 11:32 AM, Ronak Doshi wrote:
>    > 'Commit 39f9895a00f4 ("vmxnet3: add support for 32 Tx/Rx queues")'
>    > added support for 32Tx/Rx queues. As a part of this patch, intrConf
>    > structure was extended to incorporate increased queues.
>    >
>
>     Nit: no need to quote around the commit reference here.
>
>     I don't personally think its worth a re-roll to fix that, but good to be
>     aware of in future submission.
>
>     The patch itself makes sense.
>
>     Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

Thanks, Jacob, for the review.


  reply	other threads:[~2022-11-29  0:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 19:32 [PATCH v1 net 0/2] vmxnet3: couple of fixes Ronak Doshi
2022-11-28 19:32 ` [PATCH v1 net 1/2] vmxnet3: correctly report encapsulated LRO packet Ronak Doshi
2022-11-30  5:30   ` Jakub Kicinski
2022-11-28 19:32 ` [PATCH v1 net 2/2] vmxnet3: use correct intrConf reference when using extended queues Ronak Doshi
2022-11-28 23:49   ` Jacob Keller
2022-11-29  0:35     ` Ronak Doshi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-11-28 19:31 [PATCH v1 net 0/2] vmxnet3: couple of fixes Ronak Doshi
2022-11-28 19:31 ` [PATCH v1 net 2/2] vmxnet3: use correct intrConf reference when using extended queues Ronak Doshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4137D072-6887-47A5-9652-0F0A5FFBE329@vmware.com \
    --to=doshir@vmware.com \
    --cc=Pv-drivers@vmware.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gyang@vmware.com \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®