From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D60C77B70 for ; Tue, 11 Apr 2023 17:50:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229832AbjDKRuo (ORCPT ); Tue, 11 Apr 2023 13:50:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229892AbjDKRul (ORCPT ); Tue, 11 Apr 2023 13:50:41 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37997618C for ; Tue, 11 Apr 2023 10:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681235389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ef8XnWFgsT04MkS5RM8aidy/rRVFyqx0755dVLzx4LY=; b=JSS2wtNwBjpDW4/eTbDo7W8AroW9229ab2hLCFK9BVIER3WlhAW+1I1w38esdrQsrXlt2A E8KYYEqyAvW3q46NiORGAIb3mB3LokKjXY1GLI3ZFC6lbVlu3IHP4lsMTpbeoGtDCnlENO lQh8a5GewIeD0ubtKUNaVPiM8c0qiCY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-582-C_cXOpSdMASPjUK6X9l8Jw-1; Tue, 11 Apr 2023 13:49:44 -0400 X-MC-Unique: C_cXOpSdMASPjUK6X9l8Jw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 668D985A588; Tue, 11 Apr 2023 17:49:43 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 57602728FB; Tue, 11 Apr 2023 17:49:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230411160902.4134381-1-dhowells@redhat.com> <20230411160902.4134381-8-dhowells@redhat.com> To: Eric Dumazet Cc: dhowells@redhat.com, netdev@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next v6 07/18] tcp: Support MSG_SPLICE_PAGES MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4138302.1681235380.1@warthog.procyon.org.uk> Date: Tue, 11 Apr 2023 18:49:40 +0100 Message-ID: <4138303.1681235380@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Dumazet wrote: > > - zc = sk->sk_route_caps & NETIF_F_SG; > > + if (sk->sk_route_caps & NETIF_F_SG) > > + zc = 1; > > zc is set to 0, 1, MSG_ZEROCOPY , MSG_SPLICE_PAGES > > I find this a bit confusing. Maybe use a private enum ? Meh. That should be "zc = MSG_ZEROCOPY;". Will fix. David