From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6444239FCE for ; Wed, 7 Jan 2026 11:05:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767783931; cv=none; b=FLOhFux526NP530YGG1DI7gpr3LaKP5Tomsq7s1FB5LtRaCw4yxhUec6zKkKfSJZWDtlsrWUWP7SF7rCsmFjDBkg4aSBwQmr3+CiOX4XXRlROXP0G3kV1EmUdaij8yRiLQ0S4heLYdMRmm/AxG4GKIh3l+Hm91rSlT8rENAUo5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767783931; c=relaxed/simple; bh=Dfgbo6phlRYs3sHOaCfT7tdl/yidpZ1QKIUrWxYX6yk=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=dWo06679aqeB46exsEaZFFhV7NUglqZlfntoy4LMbTJJU0lw6lYyQC51fKXCdUgHq5TNOiuHEh+okenkF1hm4WJungOyZxD8sQO1zV8Xzgfq6/cWewXLVG3tbyz2ZVMhrJBeSIY63+uernhuv/yOQ2KYx2PVja94b3FNR2P+GfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hs5o7M5N; arc=none smtp.client-ip=209.85.221.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hs5o7M5N" Received: by mail-vk1-f177.google.com with SMTP id 71dfb90a1353d-559934e34bcso608468e0c.1 for ; Wed, 07 Jan 2026 03:05:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767783929; x=1768388729; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=VKTt4+AFKpYKvPFTTRtpqXGnVYTIMubv2jP5/7+T4+I=; b=hs5o7M5Nh17lsyRRJsoUlfm0ghFFe8DW06vaOWDFM4SgLSYZrLXxkYKGD2us9tHNbn am3FLC1a5EoTlM1TaF3K8sETAsd5QSL4s2dRf6He71t2iQW6Kz44W38WNOPx7+MpmRAr MfepmufBu/JnKlFqx3nkEF68KLHH31g4zfmR8oxbJqSqukA/gktAMF+oihtyJoW5It4j mH0kBGPzn/VRKd8z0Tiq7JzhbaruYnV6eSgB3mP+4NNWqC5YaRK94asGrcrDKcwcXc0C dRhOzcOACjchzmqZ1+Ow6Csq0oEQDEyCXemobjYQYFDYk9GZerEa+kk8LqoAl5G8db01 MDsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767783929; x=1768388729; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VKTt4+AFKpYKvPFTTRtpqXGnVYTIMubv2jP5/7+T4+I=; b=YGdeYGBaC/Pde5VLV6PnReqkVixABYEierPOIbfxN9Z73rkZPr4WkW9RPtuSiloq+f /fPk/VFj9zMuLQmYnB9BTpBUONdVoRBjdc/U08/5bmfuHpAO/t0B2zVVbirwlQVKxIkP CTD/4OfrVYDh/Yk4mtJ3nMmyBbVzSfstgdjuel6LygC6LRatIh4vOVYDwZfbKExxQLMV pdFrQtibDpzmG7VM8ZdWn/rL2dNvdVNrmsYN7Am1DWG9E7mqfSgR+6NHD6ohLJ6Fed7r qVJWm/X7oExs1z5okh805ovZKIxoIBi3hw/13C5QW7ujWNfO8UsyfUgp9SkzjdaUW/tc weSw== X-Forwarded-Encrypted: i=1; AJvYcCUrpX8vgPArSxF/v1H++3MShrZ7Z2HmYRnv8LDW5+3KhSAubIsY4bDCUpW/zIdXWr8V+l8t3NWZHj3hADQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1lIyBU+w5mJyKbur/pLAdXrdx02tyroROCuwv7bedvVmF+xb2 F/lzHSf5XSLgFlc7i2gDc9jNR+0GBa/RdWdL+RjS66Srpzlwj1+CbCTE X-Gm-Gg: AY/fxX7NwdAYNdGZM0w0Fef3Ib0a25JmDmszKbLq1clH5vjIsKMWxzL6NUlt9yxhWLq Jy/MVYcK28J/Eu/MBZYeH1CVRzm17HpUtdWhzuhstWhBB7b1vPCOgQuQt7DAkyZk48JZnxSrS6L 35QyTn2Ifju/+aVOpN+16eLyhhY1RouZdB5SQv7vy6aEOnBh2WBiT29fP7zMq9ENevuqvLhiXEA mAGCqyNxwWLEY8TeCYVlh0W7ndQ15zlQFXyiwUl96IfbynFrgaUmPb28wOLGcRLyD9L97Ph9cuF A4Ekr1tHmJ7MJAeoLl3EpD77XlRo44SyoiraA3aa3YLaUeLYtHzlKcUOMLZoLf1tCLGVZjZRWZs yXcNpNu/k128uWN8/2Tx2sxBRA4nPtF8qzoXB84nRAafQZUrwY43OgRiKrO27Cn25UKq/LqII0C KdDXOo0Or2oUZvkJX/5iSEBRRiEk7FAvXT9w== X-Google-Smtp-Source: AGHT+IGggPiftYVp3LtYBKjyF/Fdi5lbyANw2LP48BA89EBM/zaOrh+B00Aa4eeklC9Wq1oLgmSFxg== X-Received: by 2002:a05:6122:31a5:b0:559:70bc:ca54 with SMTP id 71dfb90a1353d-56347fd1becmr510576e0c.14.1767783929046; Wed, 07 Jan 2026 03:05:29 -0800 (PST) Received: from ehlo.thunderbird.net ([177.22.194.82]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-944124a34acsm2382059241.10.2026.01.07.03.05.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 03:05:28 -0800 (PST) Date: Wed, 07 Jan 2026 08:05:21 -0300 From: Arnaldo Melo To: Nicolas Schier , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Michael Petlan , Jakub Brnak , Veronika Molnarova CC: Philipp Hahn , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Schier Subject: Re: [PATCH v2] perf build: Raise minimum shellcheck version to 0.7.2 User-Agent: Thunderbird for Android In-Reply-To: <20260107-perf-raise-minimum-shellcheck-version-v2-1-019ef32d7711@avm.de> References: <20260107-perf-raise-minimum-shellcheck-version-v2-1-019ef32d7711@avm.de> Message-ID: <413A6A45-CA6B-46F8-BE19-5AD2D1559DD6@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On January 7, 2026 5:13:26 AM GMT-03:00, Nicolas Schier wrote: >Raise the minimum shellcheck version for perf builds to 0=2E7=2E2, so tha= t >systems with shellcheck versions below 0=2E7=2E2 will automatically skip = the >shell script checking, even if NO_SHELLCHECK is unset=2E > >Since commit 241f21be7d0f ("perf test perftool_testsuite: Use absolute >paths"), shellcheck versions before 0=2E7=2E2 break the perf build with >several SC1090 [2] warnings due to its too strict dynamic source >handling [1], e=2Eg=2E: > > In tests/shell/base_probe/test_line_semantics=2Esh line 20: > =2E "$DIR_PATH/=2E=2E/common/init=2Esh" > ^---------------------------^ SC1090: Can't follow non-constant sourc= e=2E Use a directive to specify location=2E > >Fixes: 241f21be7d0f ("perf test perftool_testsuite: Use absolute paths") >Link: https://github=2Ecom/koalaman/shellcheck/issues/1998 # [1] >Link: https://www=2Eshellcheck=2Enet/wiki/SC1090 >Acked-by: Namhyung Kim >Signed-off-by: Nicolas Schier >--- >Changes in v2: > * Add one of the shellcheck messages to commit message (Namhyung Kim) > * Link to v1: https://lore=2Ekernel=2Eorg/r/20260106-perf-raise-minimum= -shellcheck-version-v1-1-b46739a78888@avm=2Ede >--- > tools/perf/Makefile=2Eperf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/perf/Makefile=2Eperf b/tools/perf/Makefile=2Eperf >index b3f481a626afa314632876449a11eb79b2978824=2E=2Ee2d668fb7f439befd6d1d= 9cbf66765f8b815e3c6 100644 >--- a/tools/perf/Makefile=2Eperf >+++ b/tools/perf/Makefile=2Eperf >@@ -255,7 +255,7 @@ endif > # minimal shellcheck version as v0=2E6=2E0=2E I'm looking just add this patch, from the smartphone, but shouldn't the ab= ove comment need to be updated as well? - Arnaldo > ifneq ($(SHELLCHECK),) > ifeq ($(shell expr $(shell $(SHELLCHECK) --version | grep version: | \ >- sed -e 's/=2E\+ \([0-9]\+\)=2E\([0-9]\+\)=2E\([0-9]\+\)/\1\2\3/g= ') \< 060), 1) >+ sed -e 's/=2E\+ \([0-9]\+\)=2E\([0-9]\+\)=2E\([0-9]\+\)/\1\2\3/g= ') \< 072), 1) > SHELLCHECK :=3D > else > SHELLCHECK :=3D $(SHELLCHECK) -s bash -a -S warning > >--- >base-commit: 9ace4753a5202b02191d54e9fdf7f9e3d02b85eb >change-id: 20260106-perf-raise-minimum-shellcheck-version-5d684fe90a39 > >Best regards, - Arnaldo