mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Mikko Rapeli" <mikko.rapeli@linaro.org>,
	"linux-mmc @ vger . kernel . org" <linux-mmc@vger.kernel.org>
Cc: "Ulf Hansson" <ulf.hansson@linaro.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	linux-kernel@vger.kernel.org,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Victor Shih" <victor.shih@genesyslogic.com.tw>,
	"Ben Chuang" <ben.chuang@genesyslogic.com.tw>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Yixun Lan" <dlan@gentoo.org>,
	"Binbin Zhou" <zhoubinbin@loongson.cn>
Subject: Re: [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2
Date: Fri, 12 Sep 2025 16:50:38 +0200	[thread overview]
Message-ID: <413a49f5-91f3-4334-9128-29297293f953@app.fastmail.com> (raw)
In-Reply-To: <20250912142253.2843018-4-mikko.rapeli@linaro.org>

On Fri, Sep 12, 2025, at 16:22, Mikko Rapeli wrote:
> It fails to link due to undeclared dependency
> to regmap which is not enabled for COMPILE_TEST:
>
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/mmc/host/loongson2-mmc.ko] undefined!

Nice catch! I assume my normal randconfig builds never
run into this because there is always something selecting
REGMAP_MMIO.

>  config MMC_LOONGSON2
>  	tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
> -	depends on LOONGARCH || COMPILE_TEST
> +	depends on LOONGARCH
>  	depends on HAS_DMA

I would instead add 'select REGMAP_MMIO' here, which is what
we do for other drivers using this.

     Arnd

  reply	other threads:[~2025-09-12 14:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-12 14:30 [PATCH v3 4/4] ARM: rockchip: remove REGULATOR conditional to PM Mikko Rapeli
2025-09-12 14:27 ` [PATCH v3 1/4] pmdomain: rockchip: enable ROCKCHIP_PM_DOMAINS with ARCH_ROCKCHIP Mikko Rapeli
2025-09-12 14:22   ` [PATCH v3 0/4] enable ROCKCHIP_PM_DOMAINS Mikko Rapeli
2025-09-12 14:22     ` [PATCH v3 1/4] pmdomain: rockchip: enable ROCKCHIP_PM_DOMAINS with ARCH_ROCKCHIP Mikko Rapeli
2025-09-12 14:53       ` Arnd Bergmann
2025-09-12 15:00       ` Heiko Stübner
2025-09-12 14:22     ` [PATCH v3 2/4] mmc: add COMPILE_TEST to multiple drivers Mikko Rapeli
2025-09-12 14:53       ` Arnd Bergmann
2025-09-12 14:22     ` [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2 Mikko Rapeli
2025-09-12 14:50       ` Arnd Bergmann [this message]
2025-09-15  7:01         ` Mikko Rapeli
2025-09-13  4:58       ` Binbin Zhou
2025-09-12 14:22     ` [PATCH v3 4/4] ARM: rockchip: remove REGULATOR conditional to PM Mikko Rapeli
2025-09-12 14:36     ` [PATCH v3 0/4] enable ROCKCHIP_PM_DOMAINS Mikko Rapeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=413a49f5-91f3-4334-9128-29297293f953@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=adrian.hunter@intel.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=ben.chuang@genesyslogic.com.tw \
    --cc=dlan@gentoo.org \
    --cc=geert+renesas@glider.be \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mikko.rapeli@linaro.org \
    --cc=ulf.hansson@linaro.org \
    --cc=victor.shih@genesyslogic.com.tw \
    --cc=zhoubinbin@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®