From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=158.69.130.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795032413; b=rP+ShJnCxRrt7QmMMZtVCf4yNqsn82/lOf6eeWBhcq4fm8wt1C3ot5/AwshbOxnodleu Wjc/NAa5mDINDm60LXy+hLhgtRD7FYJoiCln9+8euKuczpoSnHs1rEbQQS4iyF9+rgaTC Nszis74STlhcxIP89V1uorirYDMeY0w0P64jvAZ9YUZkyoHqzCFsd8OgtWfBZwWImyrSP 1D3B+Ca21OGROw7GfSVGT0zWKpRCxjj3m5RwXc8sz7pldVfUCFU27uzYgrAmsu4XxDeki oWPqK8WBHBYLb9q1ncswU2EuUa994/3mt4dIR6LvyHMXkvnH8aMvQsRCssxvoVgrV0g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795032413; h=DMARC-Filter:DKIM-Signature:Received:From:To:Cc:Subject:Date: Message-Id:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=dH+Qy0VqTTtvIXebKmx2Zo7LzHbz/iWPH6FpOkNy6PM=; b=QqUeUEN2MMHt3Ti1l3noW56co/BKh+wtf6mHFYlEiKpbS6m9jcGqks6LT/l5VC9a3tgI 4cP8HLguFNke1NtzXxRPbKe5nW44/+O0fhWiHqg+cyEcfdFc++uubS4diZgM+/JZ/cGDC oHW314BLk1IEzyPFJ9gHxCBbWdcvngvD/sSNjRyBt0PGI8EAWW37A0JIycZsvrwaJZuj9 MZfWH9O/Xdxl0cUijpwgz4tiimFRgWKlbM8Nlpu2oIHK5A3v5bLFaAD37Y/K35YoUJ+6V 69Y+8BfHkb9LDx1Md/4j5Z4Z5GAtMAZ2qT/a9qDWXDZCNXAVpAIEprvFHX1mddsgFeQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=K0bVyGeE; arc=none smtp.remote-ip=158.69.130.18 Received: from smtpout.efficios.com (smtpout.efficios.com [158.69.130.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05CA660A3801; Wed, 18 Nov 2026 20:06:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 05CA660A3801 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=K0bVyGeE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=smtpout1; t=1795032405; bh=dH+Qy0VqTTtvIXebKmx2Zo7LzHbz/iWPH6FpOkNy6PM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K0bVyGeEIYJlr/Cr2S7i/adSW1q3CXQVs8/SGCMolNpAhUjvaDre3dDHKo1cU53WX DWvIQ20jXYhTpN51KCQNRy1XamuF1i5Ibh16/xLgkNoWzoGFPwhgvhDipm+6b1CAwT jof1rEEZctPubdwFlqacn0a7Cbhy85WJsjwOZ4wUKBQL0IsyaM2G/I0TzV6MSwnaqp NHnNDxbvjuJqBvr7/9oZrgNg8tI+1areaIAvYIEIoFz7d7IofrfFmznbhgHS6Uey2w AO8w5OrjT6K4ayTX6/l9UJoRUyUV3pxCzrvYgXtwwID1fyyDCmAcvgpnHHLBpFlCob nJSQRlt/2NuaQ== Received: from thinkos.internal.efficios.com (mtl.efficios.com [216.120.195.104]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4jVCKx2tcCzRJb; Wed, 18 Nov 2026 15:06:45 -0500 (EST) From: Mathieu Desnoyers To: juri.lelli@redhat.com, peterz@infradead.org, mingo@redhat.com, vincent.guittot@linaro.org Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , tglx@kernel.org, will@kernel.org, boqun@kernel.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com, luca.abeni@santannapisa.it, mathieu.poirier@linaro.org, longman@redhat.com, ridong.chen@linux.dev, tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com, shuah@kernel.org, bigeasy@linutronix.de, clrkwllms@kernel.org, parri.andrea@gmail.com, m.szyprowski@samsung.com, kayracizmeci@gmail.com, weihengqiuu@gmail.com, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rt-devel@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH 10/16] sched/deadline: Release the bandwidth of a task that leaves the class asleep Date: Wed, 18 Nov 2026 15:06:35 -0500 Message-Id: <413baa5f50669ae464f504dbafeb504dd9b6ef6c.1795031605.git.mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A task that leaves SCHED_DEADLINE while it is not queued can keep its bandwidth in total_bw until the next rebuild of the root domains. Repeated, this fills total_bw up to the admission limit. Then sched_setattr(SCHED_DEADLINE) and CPU offlining fail with EBUSY. A task that leaves the class keeps its bandwidth until its 0-lag time. Releasing it earlier would allow temporary overloads. For a queued task, switched_from_dl() calls task_non_contending(). It releases the bandwidth if the 0-lag time is past. Otherwise it arms the inactive timer, which releases it then. For a task that is not queued, switched_from_dl() relies on the timer armed when the task blocked. But the timer is not always pending when the task leaves the class: - The task blocked after its 0-lag time. The timer was not armed. - The timer fired while the task was still in the class. It only removed running_bw. - The task was woken up on another CPU and is not enqueued there yet. The wakeup cancelled the timer. - The task came back to the class asleep. switched_to_dl() cancelled the timer. Then nothing releases total_bw. Fix this in switched_from_dl(). For a task that is not queued and has no timer pending, call task_non_contending(), as for a queued task. It arms the timer if the 0-lag time is ahead. Otherwise it releases the bandwidth now and clears the parameters, as inactive_task_timer() does. Clearing the parameters keeps later paths from releasing the bandwidth again: - A timer handler that already started finds a dl_bw of 0. - The deboost of a later priority inheritance boost finds no parameters. An owner that the task boosts as a waiter can find the parameters cleared too. "sched/deadline: Do not replenish a boost from cleared parameters" handles this, so a backport needs it first. Without it, the owner's CPU can lock up as soon as the waiter leaves the class. Juri Lelli's first fix, since dropped from tip, released the bandwidth here without clearing dl_bw. The bandwidth of a boosted task was then released twice. Juri Lelli suggested the call to task_non_contending() in review. The Sashiko AI review of this series found the two cases with the 0-lag time ahead. deadline_switch_test, added later in this series, tests the release in asleep_round_trip. Fixes: 209a0cbda7a0 ("sched/deadline: Improve the tracking of active utilization") Reported-by: Tejun Heo Closes: https://lore.kernel.org/all/2b5fb3f22bca6aa383be8f4781923392@kernel.org/ Signed-off-by: Mathieu Desnoyers Reviewed-by: Juri Lelli Cc: stable@vger.kernel.org Link: https://lore.kernel.org/all/20261103-b4-sched-dl-bw-fixes-v1-2-dd761fe005b4@redhat.com/ --- kernel/sched/deadline.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index d6d2657dcddd..f0e03f97fd82 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -3595,6 +3595,14 @@ static void switched_from_dl(struct rq *rq, struct task_struct *p) if (p->dl.dl_non_contending) sub_running_bw(&p->dl, &rq->dl); sub_rq_bw(&p->dl, &rq->dl); + /* + * Without an armed timer, nothing releases total_bw. Do as for + * a queued task: arm the timer if the 0-lag time is ahead, or + * release the bandwidth and clear the parameters now. Call + * task_non_contending() after sub_rq_bw(), which needs dl_bw. + */ + if (!p->dl.dl_non_contending) + task_non_contending(&p->dl, false); } /* -- 2.47.3