From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5464A3ED11B for ; Thu, 23 Jul 2026 10:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784804105; cv=none; b=UvPalgKJFlSx9c6QvuieuWGsrkaJ/Nt7YqRRvYrNBvgV7cptQfoatmB4+xv1BPWfbPNLDQ0ndwbuZFuisIKvrBFSGhNKrujqpC3euzaCS24g8LiuCzE084UmcMjJwHG9yoE/QWl8As2j2+8vi4UiWwv8pxjNihU9zkJMilnsUzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784804105; c=relaxed/simple; bh=Pi70S02miiNHDRc/Q7mSW64ZqfbjcQ4++9v31z9RVI0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pxgUTztOUW4GC6+IaoD5Te6yNtkm406SCDh0X3QWcCXdlenETg++aA6sMHPoOlkuvIHpv/8itu7cKASUvW/c5EGAEwTxXybBGZNskBuzsXosSxoq+vtFHMhE69wvFFDv+pIt+u1mfY18kB9ZuIJsaZWJK5+rlW+mpfaxbaC7v5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lNG1gAHM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DwD3H1pr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lNG1gAHM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DwD3H1pr" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66N9Dka33567632 for ; Thu, 23 Jul 2026 10:55:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bqfqaFsHDwVvg1n0mFLME+pVcZeQc0JW7wTTIKnGDmM=; b=lNG1gAHMBTlj/pEq 9f0ohq7uQ7BhlhJgH3Nj9pD80u4AKEs6Gp/lnqQdCXCmTrdYLkBjsrLYLvDdQ1nw niYzZSbcNRbkSTA6kiwIy8/2bZ0RyuLKodC5nn17fbZHrWCP3giZTmvuDyML5eDd LZ0/TlhAlWWXGzZV1gMsJHsNXxW00QFsWcOCPEk+BgGeSQEwxl5f2IIv/gdFnjqv L8gZRhkUBX+4aS8mU079LTTQ0H7rkpQ70jSoQHdQlAQl2p6orrRZ5Tn13ZBDV7Jd z9O1LDJDuhNGWL3rOWIm8NZRg9X3yRhcL+YWqOAnZG44yUtXx9PCSOypfCn+kZUA +xLTNg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fkg520c3v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 10:55:03 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93102454272so18423585a.1 for ; Thu, 23 Jul 2026 03:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784804102; x=1785408902; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bqfqaFsHDwVvg1n0mFLME+pVcZeQc0JW7wTTIKnGDmM=; b=DwD3H1prPznFLhz0RM3Ff7e9qMvt9pj+ZR2O3IH7hH1GNFiArHZpTz5qB/oLNGTLSv 88YImaHEvhvOXYcWs/OTo8UnFYjjrv6sRRv030sp1nG8qWmdR8Z5HCYoQhf4R9SeN4ip Nk85U9YiqkMHLuCTjXWmxJojkHCOWdhoPxpCpYGT46GvFmnbcLkuZP3NIdsFvG4fd5Ei QVhCfwIGTGene+k3U/OrgrmI2VaL9IrL/iRgiuGoiwGR90h43EY9VqUxRQ0Zh3Zps/z8 UOgK4+U48XXhbBstk+/s4x8me103Hx9NlJ8GPJCRACi7GpLNnvsYWHXbn/S12Eah6YQn HHvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784804102; x=1785408902; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bqfqaFsHDwVvg1n0mFLME+pVcZeQc0JW7wTTIKnGDmM=; b=HC0OXklcIsq7XAuk7PswhWv2eJmVSoLwRAJrZk3XAMgfhLwKZy797aeEEUBDFptqkT wPWj3hJI4EPxMwCMe1b2IK5Len/w+JqxqvRb9SnZatnHGg3zD2ivuzeItyEWdtLVyRK0 /EAegQ4jXsQ2koStr1+qc4vd/VPYscHFLZWERP7vaOmCSvCKme6XMBDTN4RR62zi3vn4 H3dsgX6ShOwujA52lWNgHsMA3lUNxFPF8X++yRDsDQlngIzKK4n58QYsx5KulwkQZoZc J2CihC2i5GjhMwcUGjExhOAO6fQqqJ6wYII/ZL6SJKfeR6REbdDXbET0PtNDqYtQZZLb yp2Q== X-Forwarded-Encrypted: i=1; AHgh+Rpwg/tYEDdNOWnzF9dLqjOyNf84SyQF6mgcszHMBORE4zoKd7o4YD9Bg1RSmsVNPxssdbz0D7Myl+aHRc4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl5UmsEKVtkQKifFexW+xYPO5LHWv5dUqXyi42qsdGmyXfUDyM Le67GuaLlX0/Z2RTZKX2h9H2OGVHpohK6T8Io/d84N+kGRBYhr/gPIIzJ39le8zOb0BnUD3NaUO 0Ntuz7hMutMmD+Ib2xEo4NWGZ8BL0yZycd53+JxyryJ2ILi8sx06OHoQVmQS7qUYazvE= X-Gm-Gg: AR+sD13G9rp9ipofSoVf6km0Ito9qxJGjPi0Gg8nXKNrrAXI+4vsIixMBAiDUqgTixC pVIKesU9H/H9nvIriGVtfp/qf7HI+r1RSczqBWm+XM32GqmUf1BIAajC6MEirv6B/4HujsIbNuK uK5rXViqZPSB93hNUrCGIa4z5nsowqa5Zcy9pakDa+QwchwO4EaJu4/6WV9xhdjagvP5D8i5Rq4 caYEt68R/xLxe22va7DyDQ98dOSReGdMWecbGL5p31F8MbR9ybaTLlouV5I556/iCh+EjuOP3+M 5MajwVeWDcKv1QvUpmuE7VACbH+C9b5XUpVbgd4OysBT7Tzt6hHMuWaI7oUmil7g06Ff1H2g6Yd VQsboI71BhrL3nzp/ZHQGM6mi X-Received: by 2002:a05:620a:470e:b0:931:23a:83ca with SMTP id af79cd13be357-9310378b626mr218791085a.4.1784804102493; Thu, 23 Jul 2026 03:55:02 -0700 (PDT) X-Received: by 2002:a05:620a:470e:b0:931:23a:83ca with SMTP id af79cd13be357-9310378b626mr218789785a.4.1784804102018; Thu, 23 Jul 2026 03:55:02 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1c3260439esm214896266b.0.2026.07.23.03.54.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 03:55:01 -0700 (PDT) Message-ID: <413bcb02-4823-4c2f-8e0e-c9a40664caf9@oss.qualcomm.com> Date: Thu, 23 Jul 2026 12:54:58 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] remoteproc: Force shutdown during device removal To: Bjorn Andersson , Bjorn Andersson , Mathieu Poirier , Shengjiu Wang , Fernando Guzman Lugo , Ohad Ben-Cohen Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260723-rproc-rmmod-not-crashing-v1-0-546dfd5de0e6@oss.qualcomm.com> <20260723-rproc-rmmod-not-crashing-v1-3-546dfd5de0e6@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260723-rproc-rmmod-not-crashing-v1-3-546dfd5de0e6@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=DtZmPm/+ c=1 sm=1 tr=0 ts=6a61f307 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=B9Y8OgnbIiifJ16KBmAA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDEwNyBTYWx0ZWRfX/gY/OI27Ba7z zsYlYCpjqnCBoI/ttaNT0dhnAo2YRpGHuC8wzzM1LbBB9ewKBraU541vzSk0EaEEBb4HrHtNVkG f8irUzacv0nk4Gk9zdyDjFvA3jl6wtE= X-Proofpoint-GUID: kPfIJG2iv1squLKMFia4rhDXTzHRa-kW X-Proofpoint-ORIG-GUID: kPfIJG2iv1squLKMFia4rhDXTzHRa-kW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDEwNyBTYWx0ZWRfXxwFz2OmHJUxT +jGbdQytJJz9eX3iQb3ooA4nqUHEMn3coKifn1+Dn8LqhXmC4asPtaBCQEp+cda9Qj10osOLkqw LC9od7ZHizxgTrlLyr6BT1P7sFuQU1/P/9x15FnsoPD5LKu67NxBDrW1Z6lu1ldWXMf/jns3fN+ OsnHKhTLtdPQkP30K5guHzCNvNsWg2fs+1Rlzfy73iGuAtLy9H/YZUJgX01bZbXZkezgXmA3CYM I0SQsPPfs4g9Ygp3O9LOKVwRKc8zLhe8QgQIiKRiLZnAXR6yNkQtOrQkiQ5ltg2YKWSBWAixZmF QaeNs2X+sehlNbIOqHj5JL99wTiO04FTYKROxj4t6tr9nYrdq9ZZ+vWmKyxLDMzpG3zerb7pWXA pgNsUx3Rs9i0PKu9BRhAvxwWV42k3gCt0/JP8RxWtMZugzlkM87EQFils0tmZx89Eptc6aXiJp/ Jcaiw8aLRkH6+wkbJpg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_03,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230107 On 7/23/26 5:52 AM, Bjorn Andersson wrote: > rproc_del() is subjected to the reference counted shutdown path, as such > a remoteproc with more than one reference will be left running as its > resources are released underneath it. > > Refactor the shutdown path such that the reference count value is > ignored when called from rproc_del(). > > Assisted-by: OpenCode:GPT-5.5 > Signed-off-by: Bjorn Andersson > --- [...] > +static int __rproc_shutdown(struct rproc *rproc, bool force) > { > struct device *dev = &rproc->dev; > bool crashed; > @@ -2029,9 +2008,10 @@ int rproc_shutdown(struct rproc *rproc) > } > crashed = rproc->state == RPROC_CRASHED; > > - /* if the remote proc is still needed, bail out */ > - if (!atomic_dec_and_test(&rproc->power)) > + if (!atomic_dec_and_test(&rproc->power) && !force) { > + /* The remote processor is still needed by another user. */ > goto out; > + } GPT makes some unclear suggestions, effectively saying that rproc_shutdown(), unlike other paths, seems not to first check whether the rproc is deleting if the shutdown isn't forced. I think it's a valid concern. Konrad