Re: [PATCH v2 3/4] arm64: dts: qcom: talos: Add Talos Lyra EVK board

[Ruchira Revdekar <ruchira.revdekar@oss.qualcomm.com>]

Hi Dmitry,

On 12-10-2026 17:29, Dmitry Baryshkov wrote:
> On Mon, Oct 12, 2026 at 11:46:28AM +0530, Ruchira Revdekar wrote:
>> From: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
>>
>> Add the device tree for the Talos Lyra EVK platform which combines
>> the Talos Lyra EVK SoM and Lyra carrier board.
>>
>> This device tree adds board-specific peripheral configuration on top
>> of the SoM, including:
>>
>> - Native DisplayPort output
>> - GPIO expanders on i2c5
>> - SPI-attached TPM (ST33)
>> - USB host and peripheral controllers
>> - Power and reset keys
>>
>> Co-developed-by: Akash Kumar <akakum@qti.qualcomm.com>
>> Signed-off-by: Akash Kumar <akakum@qti.qualcomm.com>
>> Co-developed-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
>> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
>> Co-developed-by: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
>> Signed-off-by: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
>> Co-developed-by: Vishnu Saini <vishsain@qti.qualcomm.com>
>> Signed-off-by: Vishnu Saini <vishsain@qti.qualcomm.com>
>> Tested-by: Nirmesh Kumar Singh <nirmesh.singh@oss.qualcomm.com>
>> Signed-off-by: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
>> Signed-off-by: Ruchira Revdekar <ruchira.revdekar@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/Makefile           |   1 +
>>  arch/arm64/boot/dts/qcom/talos-lyra-evk.dts | 137 ++++++++++++++++++++++++++++
>>  2 files changed, 138 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index 88230c4e00ea..2f25575e6efe 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -456,6 +456,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8650-valve-deckard.dtb
>>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8750-mtp.dtb
>>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8750-qrd.dtb
>>  dtb-$(CONFIG_ARCH_QCOM)	+= talos-evk.dtb
>> +dtb-$(CONFIG_ARCH_QCOM)	+= talos-lyra-evk.dtb
>>  
>>  talos-evk-el2-dtbs	:= talos-evk.dtb talos-el2.dtbo
>>  
>> diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
>> new file mode 100644
>> index 000000000000..cfb563658fe0
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
>> @@ -0,0 +1,137 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>> + */
>> +/dts-v1/;
>> +
>> +#include "talos-lyra-evk-som.dtsi"
>> +
>> +/ {
>> +	model = "Qualcomm Technologies, Inc. QCS615 Talos lyra EVK";
> 
> Is it 'lyra' or 'Lyra'?
> 

Ack, it should be 'Lyra'. Will fix this in V3.

Thanks for the review.

Best regards,
Ruchira