From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932237AbcHDGY5 (ORCPT ); Thu, 4 Aug 2016 02:24:57 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34314 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753123AbcHDGYy (ORCPT ); Thu, 4 Aug 2016 02:24:54 -0400 Subject: Re: [patch] tty: amiserial.c: remove a double irq restore To: Dan Carpenter , Greg Kroah-Hartman References: <20160804053403.GL775@mwanda> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Jiri Slaby Message-ID: <41427059-b5e4-1b30-e577-5a1cf3f81b29@suse.cz> Date: Thu, 4 Aug 2016 08:24:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <20160804053403.GL775@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/04/2016, 07:34 AM, Dan Carpenter wrote: > We already called "local_irq_restore(flags);" so this isn't needed. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c > index 208f573..2f33cf1 100644 > --- a/drivers/tty/amiserial.c > +++ b/drivers/tty/amiserial.c > @@ -880,7 +880,6 @@ static int rs_write(struct tty_struct * tty, const unsigned char *buf, int count If I add a bit more context: local_irq_disable(); custom.intena = IF_SETCLR | IF_TBE; mb(); > /* set a pending Tx Interrupt, transmitter should restart now */ > custom.intreq = IF_SETCLR | IF_TBE; > mb(); > - local_irq_restore(flags); Really? thanks, -- js suse labs