From: "H. Peter Anvin" <hpa@zytor.com>
To: Josh Boyer <jwboyer@gmail.com>
Cc: Yinghai Lu <yinghai@kernel.org>, Robin Holt <holt@sgi.com>,
linux-kernel@vger.kernel.org, pjones@redhat.com
Subject: Re: Revert commit 5dcd14ecd4 - breaks EFI boot with SLES11 elilo.efi
Date: Wed, 06 Mar 2013 12:43:39 -0800 [thread overview]
Message-ID: <414399ca-2000-4120-88fb-af1d203990eb@email.android.com> (raw)
In-Reply-To: <CA+5PVA6pzop79bnixANhqBEBbP9i+01s8Ggida8Ui41aA6gDeQ@mail.gmail.com>
Yeah. I'll queue it up today and send to Linus in the next batch.
Josh Boyer <jwboyer@gmail.com> wrote:
>On Wed, Mar 6, 2013 at 12:37 PM, H. Peter Anvin <hpa@zytor.com> wrote:
>> On 03/06/2013 09:36 AM, Josh Boyer wrote:
>>>
>>> Something like this?
>>>
>>> Index: linux-2.6/arch/x86/include/asm/bootparam_utils.h
>>> ===================================================================
>>> --- linux-2.6.orig/arch/x86/include/asm/bootparam_utils.h
>>> +++ linux-2.6/arch/x86/include/asm/bootparam_utils.h
>>> @@ -20,8 +20,11 @@ static void sanitize_boot_params(struct
>>> if (boot_params->sentinel) {
>>> /*fields in boot_params are not valid, clear them */
>>> memset(&boot_params->olpc_ofw_header, 0,
>>> - (char *)&boot_params->alt_mem_k -
>>> + (char *)&boot_params->efi_info -
>>> (char *)&boot_params->olpc_ofw_header);
>>> memset(&boot_params->kbd_status, 0,
>>> (char *)&boot_params->hdr -
>>> (char *)&boot_params->kbd_status);
>>>
>>> I can try that in a bit.
>>>
>>
>> Right.
>
>OK. Doing that on top of 3.9-rc1 results in me having a booting
>machine
>again. I'd suggest we get that into upstream quick-ish.
>
>josh
--
Sent from my mobile phone. Please excuse brevity and lack of formatting.
next prev parent reply other threads:[~2013-03-06 20:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 20:52 Robin Holt
2013-02-28 21:05 ` H. Peter Anvin
2013-02-28 21:09 ` Robin Holt
2013-02-28 21:12 ` H. Peter Anvin
2013-02-28 23:02 ` Yinghai Lu
2013-02-28 23:09 ` H. Peter Anvin
2013-03-05 8:15 ` Robin Holt
2013-03-05 15:22 ` H. Peter Anvin
2013-03-05 19:12 ` Yinghai Lu
2013-03-05 19:52 ` Robin Holt
2013-03-05 20:14 ` Yinghai Lu
2013-03-05 20:22 ` Robin Holt
2013-03-06 16:53 ` Josh Boyer
2013-03-06 17:26 ` H. Peter Anvin
2013-03-06 17:36 ` Josh Boyer
2013-03-06 17:37 ` H. Peter Anvin
2013-03-06 20:40 ` Josh Boyer
2013-03-06 20:43 ` H. Peter Anvin [this message]
2013-03-07 4:53 ` [tip:x86/urgent] x86: Don' t clear efi_info even if the sentinel hits tip-bot for Josh Boyer
2013-03-06 18:00 ` [PATCH] Be explicit about what the x86 0x020c boot parameter version requires Peter Jones
2013-03-07 4:31 ` H. Peter Anvin
2013-03-07 8:39 ` Matt Fleming
2013-03-07 4:54 ` [tip:x86/urgent] x86, doc: Be explicit about what the x86 struct boot_params requires tip-bot for Peter Jones
2013-03-06 16:55 ` Revert commit 5dcd14ecd4 - breaks EFI boot with SLES11 elilo.efi Peter Jones
2013-03-06 17:14 ` H. Peter Anvin
2013-03-06 17:32 ` Peter Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=414399ca-2000-4120-88fb-af1d203990eb@email.android.com \
--to=hpa@zytor.com \
--cc=holt@sgi.com \
--cc=jwboyer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome