From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533AbcFWPzI (ORCPT ); Thu, 23 Jun 2016 11:55:08 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:54033 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbcFWPzF (ORCPT ); Thu, 23 Jun 2016 11:55:05 -0400 From: Arnd Bergmann To: Mel Gorman Cc: Vlastimil Babka , Johannes Weiner , Rik van Riel , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC, DEBUGGING 1/2] mm: pass NR_FILE_PAGES/NR_SHMEM into node_page_state Date: Thu, 23 Jun 2016 17:56:57 +0200 Message-ID: <4149446.1SMXVuGq6X@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160623135111.GX1868@techsingularity.net> References: <20160623100518.156662-1-arnd@arndb.de> <3817461.6pThRKgN9N@wuerfel> <20160623135111.GX1868@techsingularity.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:xukYSyJ1qECavzbeO3wK5mLEP+EJXhII0CRylVojXqOed9AY2sX qW/07J1mbdMrk7nKWO7gyRuIW1NgiyFe1C8vvssfSkAOfuqVdr2UhHCxvdQPnLOkQ0jm7Qb pMZ8Awd6cAe+IgJMG79QXdGXvQGIKPdDvsR9+7CgJ96EsdIZYO4P98eu2ewrbwlcqDuz221 mncUyahBg1/qH4NekH+GA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Z6l/pCxgOFU=:Gkg2q7rlH2zdQrZBszFAIy vYaTohqBjg20KXw50D0sWu1pTQFxwh5jPOvnpO9dz/F2zDOGMC1tuC2fFw/ncOfsOPYWgynbv mG1JffjLx9Y7D3uOWgljniDf3EkDhdLPoOaO2tyNfO4jWuGIvQqfvlMcekc07u+AQk4GIRWai QzBHtF76SG+bG/Fn+gmOCsoINNk5kN9TDf8MihTjl48qWuEFUw1LGCb1MvYhjuKH2g8383NRc vqi6LMXPs0IazN5WOlppqHdB770T9JBE689Kn1sO9Wv3AnveUaY4CF/h01fE/in6IErYaYj7K ZEadyIFSSCl6tpjYZ81L4zkNJjQoxWQo/uE+EybWxQSy+ntDJ1i7dcbexzid8QWdVhP9G5D3d vDGK7AIcSnykVsbj1m9FQnWJlGCj3sZGvjDPwiCXIi1Ggd71xsm5Nrc/FbPTfrd1wJbgAiuhu KK0Tuk24NO2zx9YOjxiifEA3p/osx7DaMASMatN5UnBJpFt0u71qukZcC5fAK25Kw03Udgi/e r54X4JBgegUZSKJHc80wJ6GrcTwMMR7BInEcwSEWAXaTzA3mlpRPRZq7Hy7YCuSqhLATlc7Nu Fie3toi5KR2goCM6uztBvMQc66ULV97oBn5n2H8EztSTVwxEl8kLWVytjrUT6kUiggb//odHd yiYHrU2PaNKTsXdLsOec0HeK4Lb3jcQsoBGi4wAEP5wH18VGbK+TT12WvqN/ada2PxPu6ZbFA tcVLfxSuSwPsx+dF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, June 23, 2016 2:51:11 PM CEST Mel Gorman wrote: > On Thu, Jun 23, 2016 at 03:17:43PM +0200, Arnd Bergmann wrote: > > > I have an alternative fix for this in a private tree. For now, I've asked > > > Andrew to withdraw the series entirely as there are non-trivial collisions > > > with OOM detection rework and huge page support for tmpfs. It'll be easier > > > and safer to resolve this outside of mmotm as it'll require a full round > > > of testing which takes 3-4 days. > > > > Ok. I've done a new version of my debug patch now, will follow up here > > so you can do some testing on top of that as well if you like. We probably > > don't want to apply my patch for the type checking, but you might find it > > useful for your own testing. > > > > It is useful. After fixing up a bunch of problems manually, it > identified two more errors. I probably won't merge it but I'll hang on > to it during development. I'm glad it helps. On my randconfig build machine, I've also now run into yet another finding that I originally didn't catch, not sure if you found this one already: In file included from ../include/linux/mm.h:999:0, from ../include/linux/highmem.h:7, from ../drivers/staging/lustre/lustre/osc/../../include/linux/libcfs/linux/libcfs.h:46, from ../drivers/staging/lustre/lustre/osc/../../include/linux/libcfs/libcfs.h:36, from ../drivers/staging/lustre/lustre/osc/osc_cl_internal.h:45, from ../drivers/staging/lustre/lustre/osc/osc_cache.c:40: ../drivers/staging/lustre/lustre/osc/osc_cache.c: In function 'osc_dec_unstable_pages': ../include/linux/vmstat.h:247:42: error: comparison between 'enum node_stat_item' and 'enum zone_stat_item' [-Werror=enum-compare] dec_zone_page_state_check(page, ((item) == (enum zone_stat_item )0) ? (item) : (item)) ^ ../drivers/staging/lustre/lustre/osc/osc_cache.c:1867:3: note: in expansion of macro 'dec_zone_page_state' dec_zone_page_state(desc->bd_iov[i].kiov_page, NR_UNSTABLE_NFS); ^~~~~~~~~~~~~~~~~~~ ../drivers/staging/lustre/lustre/osc/osc_cache.c: In function 'osc_inc_unstable_pages': ../include/linux/vmstat.h:245:42: error: comparison between 'enum node_stat_item' and 'enum zone_stat_item' [-Werror=enum-compare] inc_zone_page_state_check(page, ((item) == (enum zone_stat_item )0) ? (item) : (item)) ^ ../drivers/staging/lustre/lustre/osc/osc_cache.c:1901:3: note: in expansion of macro 'inc_zone_page_state' inc_zone_page_state(desc->bd_iov[i].kiov_page, NR_UNSTABLE_NFS); ^~~~~~~~~~~~~~~~~~~ Arnd